diff options
author | Ming Lei <tom.leiming@gmail.com> | 2014-04-06 13:36:08 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2014-04-08 07:15:54 -0400 |
commit | 553f809e23f00976caea7a1ebdabaa58a6383e7d (patch) | |
tree | 85cce570dee49945280cc4d5233616e1e1537961 /virt | |
parent | 467a9e1633043810259a7f5368fbcc1e84746137 (diff) |
arm, kvm: fix double lock on cpu_add_remove_lock
Commit 8146875de7d4 (arm, kvm: Fix CPU hotplug callback registration)
holds the lock before calling the two functions:
kvm_vgic_hyp_init()
kvm_timer_hyp_init()
and both the two functions are calling register_cpu_notifier()
to register cpu notifier, so cause double lock on cpu_add_remove_lock.
Considered that both two functions are only called inside
kvm_arch_init() with holding cpu_add_remove_lock, so simply use
__register_cpu_notifier() to fix the problem.
Fixes: 8146875de7d4 (arm, kvm: Fix CPU hotplug callback registration)
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'virt')
-rw-r--r-- | virt/kvm/arm/arch_timer.c | 2 | ||||
-rw-r--r-- | virt/kvm/arm/vgic.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c index 5081e809821f..22fa819a9b6a 100644 --- a/virt/kvm/arm/arch_timer.c +++ b/virt/kvm/arm/arch_timer.c | |||
@@ -277,7 +277,7 @@ int kvm_timer_hyp_init(void) | |||
277 | 277 | ||
278 | host_vtimer_irq = ppi; | 278 | host_vtimer_irq = ppi; |
279 | 279 | ||
280 | err = register_cpu_notifier(&kvm_timer_cpu_nb); | 280 | err = __register_cpu_notifier(&kvm_timer_cpu_nb); |
281 | if (err) { | 281 | if (err) { |
282 | kvm_err("Cannot register timer CPU notifier\n"); | 282 | kvm_err("Cannot register timer CPU notifier\n"); |
283 | goto out_free; | 283 | goto out_free; |
diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c index 8ca405cd7c1a..47b29834a6b6 100644 --- a/virt/kvm/arm/vgic.c +++ b/virt/kvm/arm/vgic.c | |||
@@ -1496,7 +1496,7 @@ int kvm_vgic_hyp_init(void) | |||
1496 | goto out; | 1496 | goto out; |
1497 | } | 1497 | } |
1498 | 1498 | ||
1499 | ret = register_cpu_notifier(&vgic_cpu_nb); | 1499 | ret = __register_cpu_notifier(&vgic_cpu_nb); |
1500 | if (ret) { | 1500 | if (ret) { |
1501 | kvm_err("Cannot register vgic CPU notifier\n"); | 1501 | kvm_err("Cannot register vgic CPU notifier\n"); |
1502 | goto out_free_irq; | 1502 | goto out_free_irq; |