diff options
author | Christoffer Dall <christoffer.dall@linaro.org> | 2014-11-24 04:41:56 -0500 |
---|---|---|
committer | Marc Zyngier <marc.zyngier@arm.com> | 2014-11-25 08:57:28 -0500 |
commit | b1e952b4e484ebc9ffad674c361d261a1af02a13 (patch) | |
tree | 24833551fcd373823e983c4c220251d6591c028c /virt/kvm | |
parent | 5100f9833e1881c800bc088e70afa4b9a1409f51 (diff) |
arm/arm64: vgic: Remove unreachable irq_clear_pending
When 'injecting' an edge-triggered interrupt with a falling edge we
shouldn't clear the pending state on the distributor. In fact, we
don't, because the check in vgic_validate_injection would prevent us
from ever reaching this bit of code.
Remove the unreachable snippet.
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Diffstat (limited to 'virt/kvm')
-rw-r--r-- | virt/kvm/arm/vgic.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c index 5acf2c93f616..631a472e41cf 100644 --- a/virt/kvm/arm/vgic.c +++ b/virt/kvm/arm/vgic.c | |||
@@ -1643,8 +1643,6 @@ static bool vgic_update_irq_pending(struct kvm *kvm, int cpuid, | |||
1643 | vgic_dist_irq_clear_level(vcpu, irq_num); | 1643 | vgic_dist_irq_clear_level(vcpu, irq_num); |
1644 | if (!vgic_dist_irq_soft_pend(vcpu, irq_num)) | 1644 | if (!vgic_dist_irq_soft_pend(vcpu, irq_num)) |
1645 | vgic_dist_irq_clear_pending(vcpu, irq_num); | 1645 | vgic_dist_irq_clear_pending(vcpu, irq_num); |
1646 | } else { | ||
1647 | vgic_dist_irq_clear_pending(vcpu, irq_num); | ||
1648 | } | 1646 | } |
1649 | 1647 | ||
1650 | ret = false; | 1648 | ret = false; |