Merge branch 'for_3.0/pm-fixes' of ssh://master.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm into fixes

14 files changed, 165 insertions, 22 deletions

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 1455413ec7a7..032ba6398a5c 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -215,11 +215,13 @@ LIB_FILE=$(OUTPUT)libperf.a
 LIB_H += ../../include/linux/perf_event.h
 LIB_H += ../../include/linux/rbtree.h
 LIB_H += ../../include/linux/list.h
+LIB_H += ../../include/linux/const.h
 LIB_H += ../../include/linux/hash.h
 LIB_H += ../../include/linux/stringify.h
 LIB_H += util/include/linux/bitmap.h
 LIB_H += util/include/linux/bitops.h
 LIB_H += util/include/linux/compiler.h
+LIB_H += util/include/linux/const.h
 LIB_H += util/include/linux/ctype.h
 LIB_H += util/include/linux/kernel.h
 LIB_H += util/include/linux/list.h
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index e18eb7ed30ae..7b139e1e7e86 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -8,8 +8,6 @@
 #include "builtin.h"
 
 #include "util/util.h"
-
-#include "util/util.h"
 #include "util/color.h"
 #include <linux/list.h>
 #include "util/cache.h"
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 0974f957b8fa..8e2c85798185 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -823,6 +823,16 @@ int cmd_record(int argc, const char **argv, const char *prefix __used)
 
         symbol__init();
 
+        if (symbol_conf.kptr_restrict)
+                pr_warning(
+"WARNING: Kernel address maps (/proc/{kallsyms,modules}) are restricted,\n"
+"check /proc/sys/kernel/kptr_restrict.\n\n"
+"Samples in kernel functions may not be resolved if a suitable vmlinux\n"
+"file is not found in the buildid cache or in the vmlinux path.\n\n"
+"Samples in kernel modules won't be resolved at all.\n\n"
+"If some relocation was applied (e.g. kexec) symbols may be misresolved\n"
+"even with a suitable vmlinux or kallsyms file.\n\n");
+
         if (no_buildid_cache || no_buildid)
                 disable_buildid_cache();
 
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 498c6f70a747..287a173523a7 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -116,6 +116,9 @@ static int process_sample_event(union perf_event *event,
         if (al.filtered || (hide_unresolved && al.sym == NULL))
                 return 0;
 
+        if (al.map != NULL)
+                al.map->dso->hit = 1;
+
         if (perf_session__add_hist_entry(session, &al, sample, evsel)) {
                 pr_debug("problem incrementing symbol period, skipping event\n");
                 return -1;
@@ -249,6 +252,8 @@ static int __cmd_report(void)
         u64 nr_samples;
         struct perf_session *session;
         struct perf_evsel *pos;
+        struct map *kernel_map;
+        struct kmap *kernel_kmap;
         const char *help = "For a higher level overview, try: perf report --sort comm,dso";
 
         signal(SIGINT, sig_handler);
@@ -268,6 +273,24 @@ static int __cmd_report(void)
         if (ret)
                 goto out_delete;
 
+        kernel_map = session->host_machine.vmlinux_maps[MAP__FUNCTION];
+        kernel_kmap = map__kmap(kernel_map);
+        if (kernel_map == NULL ||
+            (kernel_map->dso->hit &&
+             (kernel_kmap->ref_reloc_sym == NULL ||
+              kernel_kmap->ref_reloc_sym->addr == 0))) {
+                const struct dso *kdso = kernel_map->dso;
+
+                ui__warning(
+"Kernel address maps (/proc/{kallsyms,modules}) were restricted.\n\n"
+"Check /proc/sys/kernel/kptr_restrict before running 'perf record'.\n\n%s\n\n"
+"Samples in kernel modules can't be resolved as well.\n\n",
+                            RB_EMPTY_ROOT(&kdso->symbols[MAP__FUNCTION]) ?
+"As no suitable kallsyms nor vmlinux was found, kernel samples\n"
+"can't be resolved." :
+"If some relocation was applied (e.g. kexec) symbols may be misresolved.");
+        }
+
         if (dump_trace) {
                 perf_session__fprintf_nr_events(session, stdout);
                 goto out_delete;
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 974f6d3f4e53..22747de7234b 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -10,7 +10,6 @@
 #include "util/symbol.h"
 #include "util/thread.h"
 #include "util/trace-event.h"
-#include "util/parse-options.h"
 #include "util/util.h"
 #include "util/evlist.h"
 #include "util/evsel.h"
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 2d7934e9de38..f2f3f4937aa2 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -62,8 +62,6 @@
 #include <linux/unistd.h>
 #include <linux/types.h>
 
-#define FD(e, x, y) (*(int *)xyarray__entry(e->fd, x, y))
-
 static struct perf_top top = {
         .count_filter           = 5,
         .delay_secs             = 2,
@@ -82,6 +80,8 @@ static bool			use_tui, use_stdio;
 
 static int                      default_interval                =      0;
 
+static bool                     kptr_restrict_warned;
+static bool                     vmlinux_warned;
 static bool                     inherit                         =  false;
 static int                      realtime_prio                   =      0;
 static bool                     group                           =  false;
@@ -740,7 +740,22 @@ static void perf_event__process_sample(const union perf_event *event,
             al.filtered)
                 return;
 
+        if (!kptr_restrict_warned &&
+            symbol_conf.kptr_restrict &&
+            al.cpumode == PERF_RECORD_MISC_KERNEL) {
+                ui__warning(
+"Kernel address maps (/proc/{kallsyms,modules}) are restricted.\n\n"
+"Check /proc/sys/kernel/kptr_restrict.\n\n"
+"Kernel%s samples will not be resolved.\n",
+                          !RB_EMPTY_ROOT(&al.map->dso->symbols[MAP__FUNCTION]) ?
+                          " modules" : "");
+                if (use_browser <= 0)
+                        sleep(5);
+                kptr_restrict_warned = true;
+        }
+
         if (al.sym == NULL) {
+                const char *msg = "Kernel samples will not be resolved.\n";
                 /*
                  * As we do lazy loading of symtabs we only will know if the
                  * specified vmlinux file is invalid when we actually have a
@@ -752,12 +767,20 @@ static void perf_event__process_sample(const union perf_event *event,
                  * --hide-kernel-symbols, even if the user specifies an
                  * invalid --vmlinux ;-)
                  */
-                if (al.map == machine->vmlinux_maps[MAP__FUNCTION] &&
+                if (!kptr_restrict_warned && !vmlinux_warned &&
+                    al.map == machine->vmlinux_maps[MAP__FUNCTION] &&
                     RB_EMPTY_ROOT(&al.map->dso->symbols[MAP__FUNCTION])) {
-                        ui__warning("The %s file can't be used\n",
-                                    symbol_conf.vmlinux_name);
-                        exit_browser(0);
-                        exit(1);
+                        if (symbol_conf.vmlinux_name) {
+                                ui__warning("The %s file can't be used.\n%s",
+                                            symbol_conf.vmlinux_name, msg);
+                        } else {
+                                ui__warning("A vmlinux file was not found.\n%s",
+                                            msg);
+                        }
+
+                        if (use_browser <= 0)
+                                sleep(5);
+                        vmlinux_warned = true;
                 }
 
                 return;
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 6635fcd11ca5..0fe9adf76379 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -553,9 +553,18 @@ static int perf_event__process_kernel_mmap(union perf_event *event,
                         goto out_problem;
 
                 perf_event__set_kernel_mmap_len(event, machine->vmlinux_maps);
-                perf_session__set_kallsyms_ref_reloc_sym(machine->vmlinux_maps,
-                                                         symbol_name,
-                                                         event->mmap.pgoff);
+
+                /*
+                 * Avoid using a zero address (kptr_restrict) for the ref reloc
+                 * symbol. Effectively having zero here means that at record
+                 * time /proc/sys/kernel/kptr_restrict was non zero.
+                 */
+                if (event->mmap.pgoff != 0) {
+                        perf_session__set_kallsyms_ref_reloc_sym(machine->vmlinux_maps,
+                                                                 symbol_name,
+                                                                 event->mmap.pgoff);
+                }
+
                 if (machine__is_default_guest(machine)) {
                         /*
                          * preload dso of guest kernel and modules
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index ee0fe0dffa71..cca29ededb5b 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -35,7 +35,17 @@ struct perf_evsel *perf_evsel__new(struct perf_event_attr *attr, int idx)
 
 int perf_evsel__alloc_fd(struct perf_evsel *evsel, int ncpus, int nthreads)
 {
+        int cpu, thread;
         evsel->fd = xyarray__new(ncpus, nthreads, sizeof(int));
+
+        if (evsel->fd) {
+                for (cpu = 0; cpu < ncpus; cpu++) {
+                        for (thread = 0; thread < nthreads; thread++) {
+                                FD(evsel, cpu, thread) = -1;
+                        }
+                }
+        }
+
         return evsel->fd != NULL ? 0 : -ENOMEM;
 }
 
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 0717bebc7649..afb0849fe530 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -193,9 +193,13 @@ int build_id_cache__add_s(const char *sbuild_id, const char *debugdir,
              *linkname = malloc(size), *targetname;
         int len, err = -1;
 
-        if (is_kallsyms)
+        if (is_kallsyms) {
+                if (symbol_conf.kptr_restrict) {
+                        pr_debug("Not caching a kptr_restrict'ed /proc/kallsyms\n");
+                        return 0;
+                }
                 realname = (char *)name;
-        else
+        } else
                 realname = realpath(name, NULL);
 
         if (realname == NULL || filename == NULL || linkname == NULL)
diff --git a/tools/perf/util/include/linux/const.h b/tools/perf/util/include/linux/const.h
new file mode 100644
index 000000000000..1b476c9ae649
--- /dev/null
+++ b/tools/perf/util/include/linux/const.h
@@ -0,0 +1 @@
+#include "../../../../include/linux/const.h"
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 516876dfbe52..eec196329fd9 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -676,9 +676,30 @@ discard_symbol:		rb_erase(&pos->rb_node, root);
         return count + moved;
 }
 
+static bool symbol__restricted_filename(const char *filename,
+                                        const char *restricted_filename)
+{
+        bool restricted = false;
+
+        if (symbol_conf.kptr_restrict) {
+                char *r = realpath(filename, NULL);
+
+                if (r != NULL) {
+                        restricted = strcmp(r, restricted_filename) == 0;
+                        free(r);
+                        return restricted;
+                }
+        }
+
+        return restricted;
+}
+
 int dso__load_kallsyms(struct dso *dso, const char *filename,
                        struct map *map, symbol_filter_t filter)
 {
+        if (symbol__restricted_filename(filename, "/proc/kallsyms"))
+                return -1;
+
         if (dso__load_all_kallsyms(dso, filename, map) < 0)
                 return -1;
 
@@ -1790,6 +1811,9 @@ static int machine__create_modules(struct machine *machine)
                 modules = path;
         }
 
+        if (symbol__restricted_filename(path, "/proc/modules"))
+                return -1;
+
         file = fopen(modules, "r");
         if (file == NULL)
                 return -1;
@@ -2239,6 +2263,9 @@ static u64 machine__get_kernel_start_addr(struct machine *machine)
                 }
         }
 
+        if (symbol__restricted_filename(filename, "/proc/kallsyms"))
+                return 0;
+
         if (kallsyms__parse(filename, &args, symbol__in_kernel) <= 0)
                 return 0;
 
@@ -2410,6 +2437,25 @@ static int setup_list(struct strlist **list, const char *list_str,
         return 0;
 }
 
+static bool symbol__read_kptr_restrict(void)
+{
+        bool value = false;
+
+        if (geteuid() != 0) {
+                FILE *fp = fopen("/proc/sys/kernel/kptr_restrict", "r");
+                if (fp != NULL) {
+                        char line[8];
+
+                        if (fgets(line, sizeof(line), fp) != NULL)
+                                value = atoi(line) != 0;
+
+                        fclose(fp);
+                }
+        }
+
+        return value;
+}
+
 int symbol__init(void)
 {
         const char *symfs;
@@ -2456,6 +2502,8 @@ int symbol__init(void)
         if (symfs != symbol_conf.symfs)
                 free((void *)symfs);
 
+        symbol_conf.kptr_restrict = symbol__read_kptr_restrict();
+
         symbol_conf.initialized = true;
         return 0;
 
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
index 242de0101a86..325ee36a9d29 100644
--- a/tools/perf/util/symbol.h
+++ b/tools/perf/util/symbol.h
@@ -75,7 +75,8 @@ struct symbol_conf {
                         use_callchain,
                         exclude_other,
                         show_cpu_utilization,
-                        initialized;
+                        initialized,
+                        kptr_restrict;
         const char      *vmlinux_name,
                         *kallsyms_name,
                         *source_prefix,
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 1fd29b2daa92..cef28e6632b9 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -788,7 +788,7 @@ sub wait_for_input
 
 sub reboot_to {
     if ($reboot_type eq "grub") {
-        run_ssh "'(echo \"savedefault --default=$grub_number --once\" | grub --batch; reboot)'";
+        run_ssh "'(echo \"savedefault --default=$grub_number --once\" | grub --batch && reboot)'";
         return;
     }
 
@@ -1480,7 +1480,7 @@ sub process_config_ignore {
         or dodie "Failed to read $config";
 
     while (<IN>) {
-        if (/^(.*?(CONFIG\S*)(=.*| is not set))/) {
+        if (/^((CONFIG\S*)=.*)/) {
             $config_ignore{$2} = $1;
         }
     }
@@ -1638,7 +1638,7 @@ sub run_config_bisect {
         if (!$found) {
             # try the other half
             doprint "Top half produced no set configs, trying bottom half\n";
-            @tophalf = @start_list[$half .. $#start_list];
+            @tophalf = @start_list[$half + 1 .. $#start_list];
             create_config @tophalf;
             read_current_config \%current_config;
             foreach my $config (@tophalf) {
@@ -1690,7 +1690,7 @@ sub run_config_bisect {
         # remove half the configs we are looking at and see if
         # they are good.
         $half = int($#start_list / 2);
-    } while ($half > 0);
+    } while ($#start_list > 0);
 
     # we found a single config, try it again unless we are running manually
 
diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
index df0c6d2c3860..74d3331bdaf9 100644
--- a/tools/virtio/virtio_test.c
+++ b/tools/virtio/virtio_test.c
@@ -198,6 +198,14 @@ const struct option longopts[] = {
                 .val = 'h',
         },
         {
+                .name = "event-idx",
+                .val = 'E',
+        },
+        {
+                .name = "no-event-idx",
+                .val = 'e',
+        },
+        {
                 .name = "indirect",
                 .val = 'I',
         },
@@ -211,13 +219,17 @@ const struct option longopts[] = {
 
 static void help()
 {
-        fprintf(stderr, "Usage: virtio_test [--help] [--no-indirect]\n");
+        fprintf(stderr, "Usage: virtio_test [--help]"
+                " [--no-indirect]"
+                " [--no-event-idx]"
+                "\n");
 }
 
 int main(int argc, char **argv)
 {
         struct vdev_info dev;
-        unsigned long long features = 1ULL << VIRTIO_RING_F_INDIRECT_DESC;
+        unsigned long long features = (1ULL << VIRTIO_RING_F_INDIRECT_DESC) |
+                (1ULL << VIRTIO_RING_F_EVENT_IDX);
         int o;
 
         for (;;) {
@@ -228,6 +240,9 @@ int main(int argc, char **argv)
                 case '?':
                         help();
                         exit(2);
+                case 'e':
+                        features &= ~(1ULL << VIRTIO_RING_F_EVENT_IDX);
+                        break;
                 case 'h':
                         help();
                         goto done;