diff options
author | Yunlong Song <yunlong.song@huawei.com> | 2015-03-18 09:35:52 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-03-19 12:49:38 -0400 |
commit | 01b7160bc6674912f6b7043bbf58d66e62e41054 (patch) | |
tree | 270f27ff5c6cf2a4572fa25fe2cb41a51eac8f1b /tools | |
parent | e003ce54d2ccbb8da0fd4f421e1cc9686ef25add (diff) |
perf tools: Add the bash completion for listing subsubcommands of perf data
The bash completion does not support listing subsubcommands for 'perf
data <TAB>', so fix it.
Example:
Before this patch:
$ perf data <TAB>
$
As shown above, the subsubcommands of perf data does not come out.
After this patch:
$ perf data <TAB>
convert
As shown above, the subsubcommands of perf data can come out now.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1426685758-25488-8-git-send-email-yunlong.song@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/perf/builtin-data.c | 6 | ||||
-rw-r--r-- | tools/perf/perf-completion.sh | 2 |
2 files changed, 5 insertions, 3 deletions
diff --git a/tools/perf/builtin-data.c b/tools/perf/builtin-data.c index 155cf75b8199..709152a7b408 100644 --- a/tools/perf/builtin-data.c +++ b/tools/perf/builtin-data.c | |||
@@ -22,7 +22,9 @@ static const struct option data_options[] = { | |||
22 | OPT_END() | 22 | OPT_END() |
23 | }; | 23 | }; |
24 | 24 | ||
25 | static const char * const data_usage[] = { | 25 | static const char * const data_subcommands[] = { "convert", NULL }; |
26 | |||
27 | static const char *data_usage[] = { | ||
26 | "perf data [<common options>] <command> [<options>]", | 28 | "perf data [<common options>] <command> [<options>]", |
27 | NULL | 29 | NULL |
28 | }; | 30 | }; |
@@ -98,7 +100,7 @@ int cmd_data(int argc, const char **argv, const char *prefix) | |||
98 | if (argc < 2) | 100 | if (argc < 2) |
99 | goto usage; | 101 | goto usage; |
100 | 102 | ||
101 | argc = parse_options(argc, argv, data_options, data_usage, | 103 | argc = parse_options_subcommand(argc, argv, data_options, data_subcommands, data_usage, |
102 | PARSE_OPT_STOP_AT_NON_OPTION); | 104 | PARSE_OPT_STOP_AT_NON_OPTION); |
103 | if (argc < 1) | 105 | if (argc < 1) |
104 | goto usage; | 106 | goto usage; |
diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh index 7b98ae48f0bf..535ff72babc7 100644 --- a/tools/perf/perf-completion.sh +++ b/tools/perf/perf-completion.sh | |||
@@ -143,7 +143,7 @@ __perf_main () | |||
143 | __perfcomp_colon "$evts" "$cur" | 143 | __perfcomp_colon "$evts" "$cur" |
144 | else | 144 | else |
145 | # List subcommands for perf commands | 145 | # List subcommands for perf commands |
146 | if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched) ]]; then | 146 | if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched|data) ]]; then |
147 | subcmds=$($cmd $prev_skip_opts --list-cmds) | 147 | subcmds=$($cmd $prev_skip_opts --list-cmds) |
148 | __perfcomp_colon "$subcmds" "$cur" | 148 | __perfcomp_colon "$subcmds" "$cur" |
149 | fi | 149 | fi |