aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorAdrian Hunter <adrian.hunter@intel.com>2013-12-03 02:23:08 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2013-12-04 11:46:36 -0500
commit0058aef65eda9c9dde8253af702d542ba7eef697 (patch)
treebd140e8170b3404d6963464b0e1a0ec820fa7cfe /tools
parent454ff00f969e515c4cbfd52718ec5e01c7d9aeef (diff)
perf symbols: Retain symbol source file name to lookup source line numbers
Currently, lookup of an ip's source file name and line number is done using the dso file name. Instead retain the file name used to lookup the dso's symbols and use that. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/r/1386055390-13757-6-git-send-email-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/perf/util/dso.c1
-rw-r--r--tools/perf/util/dso.h1
-rw-r--r--tools/perf/util/srcline.c7
-rw-r--r--tools/perf/util/symbol.c2
4 files changed, 10 insertions, 1 deletions
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 68aa55aa5c17..49da9684f635 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -470,6 +470,7 @@ void dso__delete(struct dso *dso)
470 free(dso->long_name); 470 free(dso->long_name);
471 dso_cache__free(&dso->cache); 471 dso_cache__free(&dso->cache);
472 dso__free_a2l(dso); 472 dso__free_a2l(dso);
473 free(dso->symsrc_filename);
473 free(dso); 474 free(dso);
474} 475}
475 476
diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h
index d8613dc3ca8f..7142e5261266 100644
--- a/tools/perf/util/dso.h
+++ b/tools/perf/util/dso.h
@@ -78,6 +78,7 @@ struct dso {
78 struct rb_root symbol_names[MAP__NR_TYPES]; 78 struct rb_root symbol_names[MAP__NR_TYPES];
79 struct rb_root cache; 79 struct rb_root cache;
80 void *a2l; 80 void *a2l;
81 char *symsrc_filename;
81 enum dso_kernel_type kernel; 82 enum dso_kernel_type kernel;
82 enum dso_swap_type needs_swap; 83 enum dso_swap_type needs_swap;
83 enum dso_binary_type symtab_type; 84 enum dso_binary_type symtab_type;
diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
index 25b85b28301b..93795f9c2480 100644
--- a/tools/perf/util/srcline.c
+++ b/tools/perf/util/srcline.c
@@ -249,11 +249,16 @@ char *get_srcline(struct dso *dso, unsigned long addr)
249 char *file = NULL; 249 char *file = NULL;
250 unsigned line = 0; 250 unsigned line = 0;
251 char *srcline; 251 char *srcline;
252 char *dso_name = dso->long_name; 252 char *dso_name;
253 253
254 if (!dso->has_srcline) 254 if (!dso->has_srcline)
255 return SRCLINE_UNKNOWN; 255 return SRCLINE_UNKNOWN;
256 256
257 if (dso->symsrc_filename)
258 dso_name = dso->symsrc_filename;
259 else
260 dso_name = dso->long_name;
261
257 if (dso_name[0] == '[') 262 if (dso_name[0] == '[')
258 goto out; 263 goto out;
259 264
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 360eefecb81d..de87dbac50a0 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1336,6 +1336,8 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter)
1336 if (!syms_ss && symsrc__has_symtab(ss)) { 1336 if (!syms_ss && symsrc__has_symtab(ss)) {
1337 syms_ss = ss; 1337 syms_ss = ss;
1338 next_slot = true; 1338 next_slot = true;
1339 if (!dso->symsrc_filename)
1340 dso->symsrc_filename = strdup(name);
1339 } 1341 }
1340 1342
1341 if (!runtime_ss && symsrc__possibly_runtime(ss)) { 1343 if (!runtime_ss && symsrc__possibly_runtime(ss)) {