diff options
author | Borislav Petkov <bp@suse.de> | 2013-12-09 11:14:24 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-02-18 07:34:49 -0500 |
commit | cd0cfad74eb88e54ba9d205da3ed376e48981448 (patch) | |
tree | 5eb32d93129d48be57b9b9e933e14c62c6f0d435 /tools/perf | |
parent | c9b951c4d12f0b2e9a07dd459c554bc05628d092 (diff) |
perf tools: Move fs.* to lib/api/fs/
Move to generic library and kill magic.h as it is needed only in fs.h.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <rric@kernel.org>
Cc: Stanislav Fomichev <stfomichev@yandex-team.ru>
Cc: Stephane Eranian <eranian@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1386605664-24041-3-git-send-email-bp@alien8.de
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
-rw-r--r-- | tools/perf/Makefile.perf | 3 | ||||
-rw-r--r-- | tools/perf/tests/parse-events.c | 2 | ||||
-rw-r--r-- | tools/perf/util/cpumap.c | 2 | ||||
-rw-r--r-- | tools/perf/util/fs.c | 119 | ||||
-rw-r--r-- | tools/perf/util/fs.h | 7 | ||||
-rw-r--r-- | tools/perf/util/include/linux/magic.h | 16 | ||||
-rw-r--r-- | tools/perf/util/pmu.c | 2 | ||||
-rw-r--r-- | tools/perf/util/python-ext-sources | 2 | ||||
-rw-r--r-- | tools/perf/util/record.c | 2 | ||||
-rw-r--r-- | tools/perf/util/util.c | 2 |
10 files changed, 6 insertions, 151 deletions
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index f99a392d20be..869b34a51c8c 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf | |||
@@ -218,7 +218,6 @@ LIB_H += util/include/linux/ctype.h | |||
218 | LIB_H += util/include/linux/kernel.h | 218 | LIB_H += util/include/linux/kernel.h |
219 | LIB_H += util/include/linux/list.h | 219 | LIB_H += util/include/linux/list.h |
220 | LIB_H += util/include/linux/export.h | 220 | LIB_H += util/include/linux/export.h |
221 | LIB_H += util/include/linux/magic.h | ||
222 | LIB_H += util/include/linux/poison.h | 221 | LIB_H += util/include/linux/poison.h |
223 | LIB_H += util/include/linux/prefetch.h | 222 | LIB_H += util/include/linux/prefetch.h |
224 | LIB_H += util/include/linux/rbtree.h | 223 | LIB_H += util/include/linux/rbtree.h |
@@ -244,7 +243,6 @@ LIB_H += util/cache.h | |||
244 | LIB_H += util/callchain.h | 243 | LIB_H += util/callchain.h |
245 | LIB_H += util/build-id.h | 244 | LIB_H += util/build-id.h |
246 | LIB_H += util/debug.h | 245 | LIB_H += util/debug.h |
247 | LIB_H += util/fs.h | ||
248 | LIB_H += util/pmu.h | 246 | LIB_H += util/pmu.h |
249 | LIB_H += util/event.h | 247 | LIB_H += util/event.h |
250 | LIB_H += util/evsel.h | 248 | LIB_H += util/evsel.h |
@@ -306,7 +304,6 @@ LIB_OBJS += $(OUTPUT)util/annotate.o | |||
306 | LIB_OBJS += $(OUTPUT)util/build-id.o | 304 | LIB_OBJS += $(OUTPUT)util/build-id.o |
307 | LIB_OBJS += $(OUTPUT)util/config.o | 305 | LIB_OBJS += $(OUTPUT)util/config.o |
308 | LIB_OBJS += $(OUTPUT)util/ctype.o | 306 | LIB_OBJS += $(OUTPUT)util/ctype.o |
309 | LIB_OBJS += $(OUTPUT)util/fs.o | ||
310 | LIB_OBJS += $(OUTPUT)util/pmu.o | 307 | LIB_OBJS += $(OUTPUT)util/pmu.o |
311 | LIB_OBJS += $(OUTPUT)util/environment.o | 308 | LIB_OBJS += $(OUTPUT)util/environment.o |
312 | LIB_OBJS += $(OUTPUT)util/event.o | 309 | LIB_OBJS += $(OUTPUT)util/event.o |
diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c index 4db0ae617d70..8605ff5572ae 100644 --- a/tools/perf/tests/parse-events.c +++ b/tools/perf/tests/parse-events.c | |||
@@ -2,7 +2,7 @@ | |||
2 | #include "parse-events.h" | 2 | #include "parse-events.h" |
3 | #include "evsel.h" | 3 | #include "evsel.h" |
4 | #include "evlist.h" | 4 | #include "evlist.h" |
5 | #include "fs.h" | 5 | #include <api/fs/fs.h> |
6 | #include <api/fs/debugfs.h> | 6 | #include <api/fs/debugfs.h> |
7 | #include "tests.h" | 7 | #include "tests.h" |
8 | #include <linux/hw_breakpoint.h> | 8 | #include <linux/hw_breakpoint.h> |
diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c index a9b48c42e81e..7fe4994eeb63 100644 --- a/tools/perf/util/cpumap.c +++ b/tools/perf/util/cpumap.c | |||
@@ -1,5 +1,5 @@ | |||
1 | #include "util.h" | 1 | #include "util.h" |
2 | #include "fs.h" | 2 | #include <api/fs/fs.h> |
3 | #include "../perf.h" | 3 | #include "../perf.h" |
4 | #include "cpumap.h" | 4 | #include "cpumap.h" |
5 | #include <assert.h> | 5 | #include <assert.h> |
diff --git a/tools/perf/util/fs.c b/tools/perf/util/fs.c deleted file mode 100644 index f5be1f26e724..000000000000 --- a/tools/perf/util/fs.c +++ /dev/null | |||
@@ -1,119 +0,0 @@ | |||
1 | |||
2 | /* TODO merge/factor into tools/lib/lk/debugfs.c */ | ||
3 | |||
4 | #include "util.h" | ||
5 | #include "util/fs.h" | ||
6 | |||
7 | static const char * const sysfs__fs_known_mountpoints[] = { | ||
8 | "/sys", | ||
9 | 0, | ||
10 | }; | ||
11 | |||
12 | static const char * const procfs__known_mountpoints[] = { | ||
13 | "/proc", | ||
14 | 0, | ||
15 | }; | ||
16 | |||
17 | struct fs { | ||
18 | const char *name; | ||
19 | const char * const *mounts; | ||
20 | char path[PATH_MAX + 1]; | ||
21 | bool found; | ||
22 | long magic; | ||
23 | }; | ||
24 | |||
25 | enum { | ||
26 | FS__SYSFS = 0, | ||
27 | FS__PROCFS = 1, | ||
28 | }; | ||
29 | |||
30 | static struct fs fs__entries[] = { | ||
31 | [FS__SYSFS] = { | ||
32 | .name = "sysfs", | ||
33 | .mounts = sysfs__fs_known_mountpoints, | ||
34 | .magic = SYSFS_MAGIC, | ||
35 | }, | ||
36 | [FS__PROCFS] = { | ||
37 | .name = "proc", | ||
38 | .mounts = procfs__known_mountpoints, | ||
39 | .magic = PROC_SUPER_MAGIC, | ||
40 | }, | ||
41 | }; | ||
42 | |||
43 | static bool fs__read_mounts(struct fs *fs) | ||
44 | { | ||
45 | bool found = false; | ||
46 | char type[100]; | ||
47 | FILE *fp; | ||
48 | |||
49 | fp = fopen("/proc/mounts", "r"); | ||
50 | if (fp == NULL) | ||
51 | return NULL; | ||
52 | |||
53 | while (!found && | ||
54 | fscanf(fp, "%*s %" STR(PATH_MAX) "s %99s %*s %*d %*d\n", | ||
55 | fs->path, type) == 2) { | ||
56 | |||
57 | if (strcmp(type, fs->name) == 0) | ||
58 | found = true; | ||
59 | } | ||
60 | |||
61 | fclose(fp); | ||
62 | return fs->found = found; | ||
63 | } | ||
64 | |||
65 | static int fs__valid_mount(const char *fs, long magic) | ||
66 | { | ||
67 | struct statfs st_fs; | ||
68 | |||
69 | if (statfs(fs, &st_fs) < 0) | ||
70 | return -ENOENT; | ||
71 | else if (st_fs.f_type != magic) | ||
72 | return -ENOENT; | ||
73 | |||
74 | return 0; | ||
75 | } | ||
76 | |||
77 | static bool fs__check_mounts(struct fs *fs) | ||
78 | { | ||
79 | const char * const *ptr; | ||
80 | |||
81 | ptr = fs->mounts; | ||
82 | while (*ptr) { | ||
83 | if (fs__valid_mount(*ptr, fs->magic) == 0) { | ||
84 | fs->found = true; | ||
85 | strcpy(fs->path, *ptr); | ||
86 | return true; | ||
87 | } | ||
88 | ptr++; | ||
89 | } | ||
90 | |||
91 | return false; | ||
92 | } | ||
93 | |||
94 | static const char *fs__get_mountpoint(struct fs *fs) | ||
95 | { | ||
96 | if (fs__check_mounts(fs)) | ||
97 | return fs->path; | ||
98 | |||
99 | return fs__read_mounts(fs) ? fs->path : NULL; | ||
100 | } | ||
101 | |||
102 | static const char *fs__mountpoint(int idx) | ||
103 | { | ||
104 | struct fs *fs = &fs__entries[idx]; | ||
105 | |||
106 | if (fs->found) | ||
107 | return (const char *)fs->path; | ||
108 | |||
109 | return fs__get_mountpoint(fs); | ||
110 | } | ||
111 | |||
112 | #define FS__MOUNTPOINT(name, idx) \ | ||
113 | const char *name##__mountpoint(void) \ | ||
114 | { \ | ||
115 | return fs__mountpoint(idx); \ | ||
116 | } | ||
117 | |||
118 | FS__MOUNTPOINT(sysfs, FS__SYSFS); | ||
119 | FS__MOUNTPOINT(procfs, FS__PROCFS); | ||
diff --git a/tools/perf/util/fs.h b/tools/perf/util/fs.h deleted file mode 100644 index 5e09ce1bab0e..000000000000 --- a/tools/perf/util/fs.h +++ /dev/null | |||
@@ -1,7 +0,0 @@ | |||
1 | #ifndef __PERF_FS | ||
2 | #define __PERF_FS | ||
3 | |||
4 | const char *sysfs__mountpoint(void); | ||
5 | const char *procfs__mountpoint(void); | ||
6 | |||
7 | #endif /* __PERF_FS */ | ||
diff --git a/tools/perf/util/include/linux/magic.h b/tools/perf/util/include/linux/magic.h deleted file mode 100644 index 07d63cf3e0f6..000000000000 --- a/tools/perf/util/include/linux/magic.h +++ /dev/null | |||
@@ -1,16 +0,0 @@ | |||
1 | #ifndef _PERF_LINUX_MAGIC_H_ | ||
2 | #define _PERF_LINUX_MAGIC_H_ | ||
3 | |||
4 | #ifndef DEBUGFS_MAGIC | ||
5 | #define DEBUGFS_MAGIC 0x64626720 | ||
6 | #endif | ||
7 | |||
8 | #ifndef SYSFS_MAGIC | ||
9 | #define SYSFS_MAGIC 0x62656572 | ||
10 | #endif | ||
11 | |||
12 | #ifndef PROC_SUPER_MAGIC | ||
13 | #define PROC_SUPER_MAGIC 0x9fa0 | ||
14 | #endif | ||
15 | |||
16 | #endif | ||
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index b752ecb40d86..00a7dcb2f55c 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c | |||
@@ -3,7 +3,7 @@ | |||
3 | #include <unistd.h> | 3 | #include <unistd.h> |
4 | #include <stdio.h> | 4 | #include <stdio.h> |
5 | #include <dirent.h> | 5 | #include <dirent.h> |
6 | #include "fs.h" | 6 | #include <api/fs/fs.h> |
7 | #include <locale.h> | 7 | #include <locale.h> |
8 | #include "util.h" | 8 | #include "util.h" |
9 | #include "pmu.h" | 9 | #include "pmu.h" |
diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources index 595bfc73d2ed..16a475a7d492 100644 --- a/tools/perf/util/python-ext-sources +++ b/tools/perf/util/python-ext-sources | |||
@@ -17,6 +17,6 @@ util/xyarray.c | |||
17 | util/cgroup.c | 17 | util/cgroup.c |
18 | util/rblist.c | 18 | util/rblist.c |
19 | util/strlist.c | 19 | util/strlist.c |
20 | util/fs.c | 20 | ../lib/api/fs/fs.c |
21 | util/trace-event.c | 21 | util/trace-event.c |
22 | ../../lib/rbtree.c | 22 | ../../lib/rbtree.c |
diff --git a/tools/perf/util/record.c b/tools/perf/util/record.c index 373762501dad..049e0a09ccd3 100644 --- a/tools/perf/util/record.c +++ b/tools/perf/util/record.c | |||
@@ -2,7 +2,7 @@ | |||
2 | #include "evsel.h" | 2 | #include "evsel.h" |
3 | #include "cpumap.h" | 3 | #include "cpumap.h" |
4 | #include "parse-events.h" | 4 | #include "parse-events.h" |
5 | #include "fs.h" | 5 | #include <api/fs/fs.h> |
6 | #include "util.h" | 6 | #include "util.h" |
7 | 7 | ||
8 | typedef void (*setup_probe_fn_t)(struct perf_evsel *evsel); | 8 | typedef void (*setup_probe_fn_t)(struct perf_evsel *evsel); |
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c index 42ad667bb317..9f66549562bd 100644 --- a/tools/perf/util/util.c +++ b/tools/perf/util/util.c | |||
@@ -1,6 +1,6 @@ | |||
1 | #include "../perf.h" | 1 | #include "../perf.h" |
2 | #include "util.h" | 2 | #include "util.h" |
3 | #include "fs.h" | 3 | #include <api/fs/fs.h> |
4 | #include <sys/mman.h> | 4 | #include <sys/mman.h> |
5 | #ifdef HAVE_BACKTRACE_SUPPORT | 5 | #ifdef HAVE_BACKTRACE_SUPPORT |
6 | #include <execinfo.h> | 6 | #include <execinfo.h> |