diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-09-21 06:02:48 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-09-21 08:28:04 -0400 |
commit | cdd6c482c9ff9c55475ee7392ec8f672eddb7be6 (patch) | |
tree | 81f98a3ab46c589792057fe2392c1e10f8ad7893 /tools/perf/util | |
parent | dfc65094d0313cc48969fa60bcf33d693aeb05a7 (diff) |
perf: Do the big rename: Performance Counters -> Performance Events
Bye-bye Performance Counters, welcome Performance Events!
In the past few months the perfcounters subsystem has grown out its
initial role of counting hardware events, and has become (and is
becoming) a much broader generic event enumeration, reporting, logging,
monitoring, analysis facility.
Naming its core object 'perf_counter' and naming the subsystem
'perfcounters' has become more and more of a misnomer. With pending
code like hw-breakpoints support the 'counter' name is less and
less appropriate.
All in one, we've decided to rename the subsystem to 'performance
events' and to propagate this rename through all fields, variables
and API names. (in an ABI compatible fashion)
The word 'event' is also a bit shorter than 'counter' - which makes
it slightly more convenient to write/handle as well.
Thanks goes to Stephane Eranian who first observed this misnomer and
suggested a rename.
User-space tooling and ABI compatibility is not affected - this patch
should be function-invariant. (Also, defconfigs were not touched to
keep the size down.)
This patch has been generated via the following script:
FILES=$(find * -type f | grep -vE 'oprofile|[^K]config')
sed -i \
-e 's/PERF_EVENT_/PERF_RECORD_/g' \
-e 's/PERF_COUNTER/PERF_EVENT/g' \
-e 's/perf_counter/perf_event/g' \
-e 's/nb_counters/nb_events/g' \
-e 's/swcounter/swevent/g' \
-e 's/tpcounter_event/tp_event/g' \
$FILES
for N in $(find . -name perf_counter.[ch]); do
M=$(echo $N | sed 's/perf_counter/perf_event/g')
mv $N $M
done
FILES=$(find . -name perf_event.*)
sed -i \
-e 's/COUNTER_MASK/REG_MASK/g' \
-e 's/COUNTER/EVENT/g' \
-e 's/\<event\>/event_id/g' \
-e 's/counter/event/g' \
-e 's/Counter/Event/g' \
$FILES
... to keep it as correct as possible. This script can also be
used by anyone who has pending perfcounters patches - it converts
a Linux kernel tree over to the new naming. We tried to time this
change to the point in time where the amount of pending patches
is the smallest: the end of the merge window.
Namespace clashes were fixed up in a preparatory patch - and some
stylistic fallout will be fixed up in a subsequent patch.
( NOTE: 'counters' are still the proper terminology when we deal
with hardware registers - and these sed scripts are a bit
over-eager in renaming them. I've undone some of that, but
in case there's something left where 'counter' would be
better than 'event' we can undo that on an individual basis
instead of touching an otherwise nicely automated patch. )
Suggested-by: Stephane Eranian <eranian@google.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Paul Mackerras <paulus@samba.org>
Reviewed-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: <linux-arch@vger.kernel.org>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/util')
-rw-r--r-- | tools/perf/util/event.h | 4 | ||||
-rw-r--r-- | tools/perf/util/header.c | 6 | ||||
-rw-r--r-- | tools/perf/util/header.h | 8 | ||||
-rw-r--r-- | tools/perf/util/parse-events.c | 32 | ||||
-rw-r--r-- | tools/perf/util/parse-events.h | 2 | ||||
-rw-r--r-- | tools/perf/util/trace-event-info.c | 8 | ||||
-rw-r--r-- | tools/perf/util/trace-event.h | 2 |
7 files changed, 31 insertions, 31 deletions
diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h index 018d414a09d1..2c9c26d6ded0 100644 --- a/tools/perf/util/event.h +++ b/tools/perf/util/event.h | |||
@@ -1,5 +1,5 @@ | |||
1 | #ifndef __PERF_EVENT_H | 1 | #ifndef __PERF_RECORD_H |
2 | #define __PERF_EVENT_H | 2 | #define __PERF_RECORD_H |
3 | #include "../perf.h" | 3 | #include "../perf.h" |
4 | #include "util.h" | 4 | #include "util.h" |
5 | #include <linux/list.h> | 5 | #include <linux/list.h> |
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index bb4fca3efcc3..e306857b2c2b 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c | |||
@@ -9,7 +9,7 @@ | |||
9 | /* | 9 | /* |
10 | * Create new perf.data header attribute: | 10 | * Create new perf.data header attribute: |
11 | */ | 11 | */ |
12 | struct perf_header_attr *perf_header_attr__new(struct perf_counter_attr *attr) | 12 | struct perf_header_attr *perf_header_attr__new(struct perf_event_attr *attr) |
13 | { | 13 | { |
14 | struct perf_header_attr *self = malloc(sizeof(*self)); | 14 | struct perf_header_attr *self = malloc(sizeof(*self)); |
15 | 15 | ||
@@ -134,7 +134,7 @@ struct perf_file_section { | |||
134 | }; | 134 | }; |
135 | 135 | ||
136 | struct perf_file_attr { | 136 | struct perf_file_attr { |
137 | struct perf_counter_attr attr; | 137 | struct perf_event_attr attr; |
138 | struct perf_file_section ids; | 138 | struct perf_file_section ids; |
139 | }; | 139 | }; |
140 | 140 | ||
@@ -320,7 +320,7 @@ u64 perf_header__sample_type(struct perf_header *header) | |||
320 | return type; | 320 | return type; |
321 | } | 321 | } |
322 | 322 | ||
323 | struct perf_counter_attr * | 323 | struct perf_event_attr * |
324 | perf_header__find_attr(u64 id, struct perf_header *header) | 324 | perf_header__find_attr(u64 id, struct perf_header *header) |
325 | { | 325 | { |
326 | int i; | 326 | int i; |
diff --git a/tools/perf/util/header.h b/tools/perf/util/header.h index 7b0e84a87179..a0761bc7863c 100644 --- a/tools/perf/util/header.h +++ b/tools/perf/util/header.h | |||
@@ -1,12 +1,12 @@ | |||
1 | #ifndef _PERF_HEADER_H | 1 | #ifndef _PERF_HEADER_H |
2 | #define _PERF_HEADER_H | 2 | #define _PERF_HEADER_H |
3 | 3 | ||
4 | #include "../../../include/linux/perf_counter.h" | 4 | #include "../../../include/linux/perf_event.h" |
5 | #include <sys/types.h> | 5 | #include <sys/types.h> |
6 | #include "types.h" | 6 | #include "types.h" |
7 | 7 | ||
8 | struct perf_header_attr { | 8 | struct perf_header_attr { |
9 | struct perf_counter_attr attr; | 9 | struct perf_event_attr attr; |
10 | int ids, size; | 10 | int ids, size; |
11 | u64 *id; | 11 | u64 *id; |
12 | off_t id_offset; | 12 | off_t id_offset; |
@@ -34,11 +34,11 @@ char *perf_header__find_event(u64 id); | |||
34 | 34 | ||
35 | 35 | ||
36 | struct perf_header_attr * | 36 | struct perf_header_attr * |
37 | perf_header_attr__new(struct perf_counter_attr *attr); | 37 | perf_header_attr__new(struct perf_event_attr *attr); |
38 | void perf_header_attr__add_id(struct perf_header_attr *self, u64 id); | 38 | void perf_header_attr__add_id(struct perf_header_attr *self, u64 id); |
39 | 39 | ||
40 | u64 perf_header__sample_type(struct perf_header *header); | 40 | u64 perf_header__sample_type(struct perf_header *header); |
41 | struct perf_counter_attr * | 41 | struct perf_event_attr * |
42 | perf_header__find_attr(u64 id, struct perf_header *header); | 42 | perf_header__find_attr(u64 id, struct perf_header *header); |
43 | 43 | ||
44 | 44 | ||
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 89172fd0038b..13ab4b842d49 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c | |||
@@ -10,7 +10,7 @@ | |||
10 | 10 | ||
11 | int nr_counters; | 11 | int nr_counters; |
12 | 12 | ||
13 | struct perf_counter_attr attrs[MAX_COUNTERS]; | 13 | struct perf_event_attr attrs[MAX_COUNTERS]; |
14 | 14 | ||
15 | struct event_symbol { | 15 | struct event_symbol { |
16 | u8 type; | 16 | u8 type; |
@@ -48,13 +48,13 @@ static struct event_symbol event_symbols[] = { | |||
48 | { CSW(CPU_MIGRATIONS), "cpu-migrations", "migrations" }, | 48 | { CSW(CPU_MIGRATIONS), "cpu-migrations", "migrations" }, |
49 | }; | 49 | }; |
50 | 50 | ||
51 | #define __PERF_COUNTER_FIELD(config, name) \ | 51 | #define __PERF_EVENT_FIELD(config, name) \ |
52 | ((config & PERF_COUNTER_##name##_MASK) >> PERF_COUNTER_##name##_SHIFT) | 52 | ((config & PERF_EVENT_##name##_MASK) >> PERF_EVENT_##name##_SHIFT) |
53 | 53 | ||
54 | #define PERF_COUNTER_RAW(config) __PERF_COUNTER_FIELD(config, RAW) | 54 | #define PERF_EVENT_RAW(config) __PERF_EVENT_FIELD(config, RAW) |
55 | #define PERF_COUNTER_CONFIG(config) __PERF_COUNTER_FIELD(config, CONFIG) | 55 | #define PERF_EVENT_CONFIG(config) __PERF_EVENT_FIELD(config, CONFIG) |
56 | #define PERF_COUNTER_TYPE(config) __PERF_COUNTER_FIELD(config, TYPE) | 56 | #define PERF_EVENT_TYPE(config) __PERF_EVENT_FIELD(config, TYPE) |
57 | #define PERF_COUNTER_ID(config) __PERF_COUNTER_FIELD(config, EVENT) | 57 | #define PERF_EVENT_ID(config) __PERF_EVENT_FIELD(config, EVENT) |
58 | 58 | ||
59 | static const char *hw_event_names[] = { | 59 | static const char *hw_event_names[] = { |
60 | "cycles", | 60 | "cycles", |
@@ -352,7 +352,7 @@ static int parse_aliases(const char **str, const char *names[][MAX_ALIASES], int | |||
352 | } | 352 | } |
353 | 353 | ||
354 | static enum event_result | 354 | static enum event_result |
355 | parse_generic_hw_event(const char **str, struct perf_counter_attr *attr) | 355 | parse_generic_hw_event(const char **str, struct perf_event_attr *attr) |
356 | { | 356 | { |
357 | const char *s = *str; | 357 | const char *s = *str; |
358 | int cache_type = -1, cache_op = -1, cache_result = -1; | 358 | int cache_type = -1, cache_op = -1, cache_result = -1; |
@@ -417,7 +417,7 @@ parse_single_tracepoint_event(char *sys_name, | |||
417 | const char *evt_name, | 417 | const char *evt_name, |
418 | unsigned int evt_length, | 418 | unsigned int evt_length, |
419 | char *flags, | 419 | char *flags, |
420 | struct perf_counter_attr *attr, | 420 | struct perf_event_attr *attr, |
421 | const char **strp) | 421 | const char **strp) |
422 | { | 422 | { |
423 | char evt_path[MAXPATHLEN]; | 423 | char evt_path[MAXPATHLEN]; |
@@ -505,7 +505,7 @@ parse_subsystem_tracepoint_event(char *sys_name, char *flags) | |||
505 | 505 | ||
506 | 506 | ||
507 | static enum event_result parse_tracepoint_event(const char **strp, | 507 | static enum event_result parse_tracepoint_event(const char **strp, |
508 | struct perf_counter_attr *attr) | 508 | struct perf_event_attr *attr) |
509 | { | 509 | { |
510 | const char *evt_name; | 510 | const char *evt_name; |
511 | char *flags; | 511 | char *flags; |
@@ -563,7 +563,7 @@ static int check_events(const char *str, unsigned int i) | |||
563 | } | 563 | } |
564 | 564 | ||
565 | static enum event_result | 565 | static enum event_result |
566 | parse_symbolic_event(const char **strp, struct perf_counter_attr *attr) | 566 | parse_symbolic_event(const char **strp, struct perf_event_attr *attr) |
567 | { | 567 | { |
568 | const char *str = *strp; | 568 | const char *str = *strp; |
569 | unsigned int i; | 569 | unsigned int i; |
@@ -582,7 +582,7 @@ parse_symbolic_event(const char **strp, struct perf_counter_attr *attr) | |||
582 | } | 582 | } |
583 | 583 | ||
584 | static enum event_result | 584 | static enum event_result |
585 | parse_raw_event(const char **strp, struct perf_counter_attr *attr) | 585 | parse_raw_event(const char **strp, struct perf_event_attr *attr) |
586 | { | 586 | { |
587 | const char *str = *strp; | 587 | const char *str = *strp; |
588 | u64 config; | 588 | u64 config; |
@@ -601,7 +601,7 @@ parse_raw_event(const char **strp, struct perf_counter_attr *attr) | |||
601 | } | 601 | } |
602 | 602 | ||
603 | static enum event_result | 603 | static enum event_result |
604 | parse_numeric_event(const char **strp, struct perf_counter_attr *attr) | 604 | parse_numeric_event(const char **strp, struct perf_event_attr *attr) |
605 | { | 605 | { |
606 | const char *str = *strp; | 606 | const char *str = *strp; |
607 | char *endp; | 607 | char *endp; |
@@ -623,7 +623,7 @@ parse_numeric_event(const char **strp, struct perf_counter_attr *attr) | |||
623 | } | 623 | } |
624 | 624 | ||
625 | static enum event_result | 625 | static enum event_result |
626 | parse_event_modifier(const char **strp, struct perf_counter_attr *attr) | 626 | parse_event_modifier(const char **strp, struct perf_event_attr *attr) |
627 | { | 627 | { |
628 | const char *str = *strp; | 628 | const char *str = *strp; |
629 | int eu = 1, ek = 1, eh = 1; | 629 | int eu = 1, ek = 1, eh = 1; |
@@ -656,7 +656,7 @@ parse_event_modifier(const char **strp, struct perf_counter_attr *attr) | |||
656 | * Symbolic names are (almost) exactly matched. | 656 | * Symbolic names are (almost) exactly matched. |
657 | */ | 657 | */ |
658 | static enum event_result | 658 | static enum event_result |
659 | parse_event_symbols(const char **str, struct perf_counter_attr *attr) | 659 | parse_event_symbols(const char **str, struct perf_event_attr *attr) |
660 | { | 660 | { |
661 | enum event_result ret; | 661 | enum event_result ret; |
662 | 662 | ||
@@ -711,7 +711,7 @@ static void store_event_type(const char *orgname) | |||
711 | 711 | ||
712 | int parse_events(const struct option *opt __used, const char *str, int unset __used) | 712 | int parse_events(const struct option *opt __used, const char *str, int unset __used) |
713 | { | 713 | { |
714 | struct perf_counter_attr attr; | 714 | struct perf_event_attr attr; |
715 | enum event_result ret; | 715 | enum event_result ret; |
716 | 716 | ||
717 | if (strchr(str, ':')) | 717 | if (strchr(str, ':')) |
diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h index 60704c15961f..30c608112845 100644 --- a/tools/perf/util/parse-events.h +++ b/tools/perf/util/parse-events.h | |||
@@ -16,7 +16,7 @@ extern struct tracepoint_path *tracepoint_id_to_path(u64 config); | |||
16 | 16 | ||
17 | extern int nr_counters; | 17 | extern int nr_counters; |
18 | 18 | ||
19 | extern struct perf_counter_attr attrs[MAX_COUNTERS]; | 19 | extern struct perf_event_attr attrs[MAX_COUNTERS]; |
20 | 20 | ||
21 | extern const char *event_name(int ctr); | 21 | extern const char *event_name(int ctr); |
22 | extern const char *__event_name(int type, u64 config); | 22 | extern const char *__event_name(int type, u64 config); |
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c index 1fd824c1f1c4..af4b0573b37f 100644 --- a/tools/perf/util/trace-event-info.c +++ b/tools/perf/util/trace-event-info.c | |||
@@ -480,12 +480,12 @@ out: | |||
480 | } | 480 | } |
481 | 481 | ||
482 | static struct tracepoint_path * | 482 | static struct tracepoint_path * |
483 | get_tracepoints_path(struct perf_counter_attr *pattrs, int nb_counters) | 483 | get_tracepoints_path(struct perf_event_attr *pattrs, int nb_events) |
484 | { | 484 | { |
485 | struct tracepoint_path path, *ppath = &path; | 485 | struct tracepoint_path path, *ppath = &path; |
486 | int i; | 486 | int i; |
487 | 487 | ||
488 | for (i = 0; i < nb_counters; i++) { | 488 | for (i = 0; i < nb_events; i++) { |
489 | if (pattrs[i].type != PERF_TYPE_TRACEPOINT) | 489 | if (pattrs[i].type != PERF_TYPE_TRACEPOINT) |
490 | continue; | 490 | continue; |
491 | ppath->next = tracepoint_id_to_path(pattrs[i].config); | 491 | ppath->next = tracepoint_id_to_path(pattrs[i].config); |
@@ -496,7 +496,7 @@ get_tracepoints_path(struct perf_counter_attr *pattrs, int nb_counters) | |||
496 | 496 | ||
497 | return path.next; | 497 | return path.next; |
498 | } | 498 | } |
499 | void read_tracing_data(struct perf_counter_attr *pattrs, int nb_counters) | 499 | void read_tracing_data(struct perf_event_attr *pattrs, int nb_events) |
500 | { | 500 | { |
501 | char buf[BUFSIZ]; | 501 | char buf[BUFSIZ]; |
502 | struct tracepoint_path *tps; | 502 | struct tracepoint_path *tps; |
@@ -530,7 +530,7 @@ void read_tracing_data(struct perf_counter_attr *pattrs, int nb_counters) | |||
530 | page_size = getpagesize(); | 530 | page_size = getpagesize(); |
531 | write_or_die(&page_size, 4); | 531 | write_or_die(&page_size, 4); |
532 | 532 | ||
533 | tps = get_tracepoints_path(pattrs, nb_counters); | 533 | tps = get_tracepoints_path(pattrs, nb_events); |
534 | 534 | ||
535 | read_header_files(); | 535 | read_header_files(); |
536 | read_ftrace_files(tps); | 536 | read_ftrace_files(tps); |
diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h index d35ebf1e29ff..693f815c9429 100644 --- a/tools/perf/util/trace-event.h +++ b/tools/perf/util/trace-event.h | |||
@@ -240,6 +240,6 @@ unsigned long long | |||
240 | raw_field_value(struct event *event, const char *name, void *data); | 240 | raw_field_value(struct event *event, const char *name, void *data); |
241 | void *raw_field_ptr(struct event *event, const char *name, void *data); | 241 | void *raw_field_ptr(struct event *event, const char *name, void *data); |
242 | 242 | ||
243 | void read_tracing_data(struct perf_counter_attr *pattrs, int nb_counters); | 243 | void read_tracing_data(struct perf_event_attr *pattrs, int nb_events); |
244 | 244 | ||
245 | #endif /* _TRACE_EVENTS_H */ | 245 | #endif /* _TRACE_EVENTS_H */ |