diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-02-23 09:08:59 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-02-23 10:13:39 -0500 |
commit | 170ae6bc24e1d7f9bd921a484ec9ea2825497970 (patch) | |
tree | 1bb087d36ced6cca9beabee151f8095617ebfd48 /tools/perf/util/ui/browsers/hists.c | |
parent | 9848caf26dafefcec7881f0e3c35fc81c454ba59 (diff) |
perf annotate: Show better message when no vmlinux is found
In both --tui and --stdio, in 'annotate', 'top', 'report' when trying to
annotate a kernel symbol having just access to a kallsyms file, that
doesn't have the DWARF info needed for annotation.
Suggested-by: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/ui/browsers/hists.c')
-rw-r--r-- | tools/perf/util/ui/browsers/hists.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/tools/perf/util/ui/browsers/hists.c b/tools/perf/util/ui/browsers/hists.c index 294b49538522..497b3c4076a3 100644 --- a/tools/perf/util/ui/browsers/hists.c +++ b/tools/perf/util/ui/browsers/hists.c | |||
@@ -924,14 +924,6 @@ int hists__browse(struct hists *self, const char *helpline, | |||
924 | if (choice == annotate) { | 924 | if (choice == annotate) { |
925 | struct hist_entry *he; | 925 | struct hist_entry *he; |
926 | do_annotate: | 926 | do_annotate: |
927 | if (browser->selection->map->dso->origin == DSO__ORIG_KERNEL) { | ||
928 | browser->selection->map->dso->annotate_warned = 1; | ||
929 | ui_helpline__puts("No vmlinux file found, can't " | ||
930 | "annotate with just a " | ||
931 | "kallsyms file"); | ||
932 | continue; | ||
933 | } | ||
934 | |||
935 | he = hist_browser__selected_entry(browser); | 927 | he = hist_browser__selected_entry(browser); |
936 | if (he == NULL) | 928 | if (he == NULL) |
937 | continue; | 929 | continue; |