diff options
author | Avi Kivity <avi@cloudius-systems.com> | 2014-09-13 00:15:05 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-09-17 16:08:09 -0400 |
commit | 763122ade725592402190f5ff3b8d2edf42b87e8 (patch) | |
tree | 1ce5493cc830c0cd23c221665e7c143e668e43ac /tools/perf/util/symbol-elf.c | |
parent | 29a3ce31c38c8f73f4e076b7ffc0876b4f5dd6c3 (diff) |
perf tools: Disable kernel symbol demangling by default
Some Linux symbols (for example __vt_event_wait) are interpreted by the
demangler as C++ mangled names, which of course they aren't.
Disable kernel symbol demangling by default to avoid this, and allow
enabling it with a new option --demangle-kernel for those who wish it.
Reported-by: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1410581705-26968-1-git-send-email-avi@cloudius-systems.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/symbol-elf.c')
-rw-r--r-- | tools/perf/util/symbol-elf.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 9fb5e9e9f161..9c9b27fbc78d 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c | |||
@@ -680,6 +680,11 @@ static u64 ref_reloc(struct kmap *kmap) | |||
680 | return 0; | 680 | return 0; |
681 | } | 681 | } |
682 | 682 | ||
683 | static bool want_demangle(bool is_kernel_sym) | ||
684 | { | ||
685 | return is_kernel_sym ? symbol_conf.demangle_kernel : symbol_conf.demangle; | ||
686 | } | ||
687 | |||
683 | int dso__load_sym(struct dso *dso, struct map *map, | 688 | int dso__load_sym(struct dso *dso, struct map *map, |
684 | struct symsrc *syms_ss, struct symsrc *runtime_ss, | 689 | struct symsrc *syms_ss, struct symsrc *runtime_ss, |
685 | symbol_filter_t filter, int kmodule) | 690 | symbol_filter_t filter, int kmodule) |
@@ -938,7 +943,7 @@ new_symbol: | |||
938 | * DWARF DW_compile_unit has this, but we don't always have access | 943 | * DWARF DW_compile_unit has this, but we don't always have access |
939 | * to it... | 944 | * to it... |
940 | */ | 945 | */ |
941 | if (symbol_conf.demangle) { | 946 | if (want_demangle(dso->kernel || kmodule)) { |
942 | int demangle_flags = DMGL_NO_OPTS; | 947 | int demangle_flags = DMGL_NO_OPTS; |
943 | if (verbose) | 948 | if (verbose) |
944 | demangle_flags = DMGL_PARAMS | DMGL_ANSI; | 949 | demangle_flags = DMGL_PARAMS | DMGL_ANSI; |