diff options
author | Namhyung Kim <namhyung@kernel.org> | 2015-01-29 03:06:42 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-01-29 14:56:54 -0500 |
commit | 0b064f43001fc2627ff8c3020647b85db040235f (patch) | |
tree | efa0b06cbd345d8bff4d0272e6e6ae7b4030ce6d /tools/perf/util/symbol-elf.c | |
parent | 62e503b7ed98fcdf16308cda0b5378e7840f4339 (diff) |
perf symbols: Support to read compressed module from build-id cache
The commit c00c48fc6e6e ("perf symbols: Preparation for compressed
kernel module support") added support for compressed kernel modules but
it only supports system path DSOs. When a dso is read from build-id
cache, its filename doesn't end with ".gz" but has build-id. In this
case, we should fallback to the original dso->name.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1422518843-25818-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/symbol-elf.c')
-rw-r--r-- | tools/perf/util/symbol-elf.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 06fcd1bf98b6..b24f9d8727a8 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c | |||
@@ -574,13 +574,16 @@ static int decompress_kmodule(struct dso *dso, const char *name, | |||
574 | const char *ext = strrchr(name, '.'); | 574 | const char *ext = strrchr(name, '.'); |
575 | char tmpbuf[] = "/tmp/perf-kmod-XXXXXX"; | 575 | char tmpbuf[] = "/tmp/perf-kmod-XXXXXX"; |
576 | 576 | ||
577 | if ((type != DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE_COMP && | 577 | if (type != DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE_COMP && |
578 | type != DSO_BINARY_TYPE__GUEST_KMODULE_COMP) || | 578 | type != DSO_BINARY_TYPE__GUEST_KMODULE_COMP && |
579 | type != dso->symtab_type) | 579 | type != DSO_BINARY_TYPE__BUILD_ID_CACHE) |
580 | return -1; | 580 | return -1; |
581 | 581 | ||
582 | if (!ext || !is_supported_compression(ext + 1)) | 582 | if (!ext || !is_supported_compression(ext + 1)) { |
583 | return -1; | 583 | ext = strrchr(dso->name, '.'); |
584 | if (!ext || !is_supported_compression(ext + 1)) | ||
585 | return -1; | ||
586 | } | ||
584 | 587 | ||
585 | fd = mkstemp(tmpbuf); | 588 | fd = mkstemp(tmpbuf); |
586 | if (fd < 0) | 589 | if (fd < 0) |