Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core

Pull perf/core improvements and fixes from Arnaldo Carvalho de Melo:

User visible fixes:

 - Fallback to kallsyms when using the minimal 'ELF' loader (Arnaldo Carvalho de Melo)

 - Fix annotation with kcore (Adrian Hunter)

 - Fix up srcline histogram key formatting (Arnaldo Carvalho de Melo)

 - Add missing handler for PERF_RECORD_MMAP2 events in 'perf diff' (Kan Liang)

User visible changes/new features:

 - Only print base source file for srcline histogram sort key (Andi Kleen)

 - Support source line numbers in annotate using a hotkey (Andi Kleen)

Infrastructure changes and fixes:

 - Do not poll events that use the system_wide flag (Adrian Hunter)

 - Add perf-read-vdso32 and perf-read-vdsox32 to .gitignore (Adrian Hunter)

 - Only override the default :tid comm entry (Adrian Hunter)

 - Factor out adding new call chain entries (Andi Kleen)

 - Use al.addr to set up call chain (Andi Kleen)

 - Use a common function to resolve symbol or name (Andi Kleen)

 - Fix ftrace:function event recording (Jiri Olsa)

 - Move disable_buildid_cache() to util/build-id.c (Namhyung Kim)

 - Clean up libelf feature support code (Namhyung Kim)

 - Fix typo in python 'perf test' (WANG Chao)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>

1 files changed, 32 insertions, 19 deletions

diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 52e94902afb1..d97309c87bd6 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -1381,6 +1381,34 @@ struct mem_info *sample__resolve_mem(struct perf_sample *sample,
         return mi;
 }
 
+static int add_callchain_ip(struct thread *thread,
+                            struct symbol **parent,
+                            struct addr_location *root_al,
+                            int cpumode,
+                            u64 ip)
+{
+        struct addr_location al;
+
+        al.filtered = 0;
+        al.sym = NULL;
+        thread__find_addr_location(thread, cpumode, MAP__FUNCTION,
+                                   ip, &al);
+        if (al.sym != NULL) {
+                if (sort__has_parent && !*parent &&
+                    symbol__match_regex(al.sym, &parent_regex))
+                        *parent = al.sym;
+                else if (have_ignore_callees && root_al &&
+                  symbol__match_regex(al.sym, &ignore_callees_regex)) {
+                        /* Treat this symbol as the root,
+                           forgetting its callees. */
+                        *root_al = al;
+                        callchain_cursor_reset(&callchain_cursor);
+                }
+        }
+
+        return callchain_cursor_append(&callchain_cursor, al.addr, al.map, al.sym);
+}
+
 struct branch_info *sample__resolve_bstack(struct perf_sample *sample,
                                            struct addr_location *al)
 {
@@ -1427,7 +1455,6 @@ static int thread__resolve_callchain_sample(struct thread *thread,
 
         for (i = 0; i < chain_nr; i++) {
                 u64 ip;
-                struct addr_location al;
 
                 if (callchain_param.order == ORDER_CALLEE)
                         j = i;
@@ -1464,24 +1491,10 @@ static int thread__resolve_callchain_sample(struct thread *thread,
                         continue;
                 }
 
-                al.filtered = 0;
-                thread__find_addr_location(thread, cpumode,
-                                           MAP__FUNCTION, ip, &al);
-                if (al.sym != NULL) {
-                        if (sort__has_parent && !*parent &&
-                            symbol__match_regex(al.sym, &parent_regex))
-                                *parent = al.sym;
-                        else if (have_ignore_callees && root_al &&
-                          symbol__match_regex(al.sym, &ignore_callees_regex)) {
-                                /* Treat this symbol as the root,
-                                   forgetting its callees. */
-                                *root_al = al;
-                                callchain_cursor_reset(&callchain_cursor);
-                        }
-                }
-
-                err = callchain_cursor_append(&callchain_cursor,
-                                              ip, al.map, al.sym);
+                err = add_callchain_ip(thread, parent, root_al,
+                                       cpumode, ip);
+                if (err == -EINVAL)
+                        break;
                 if (err)
                         return err;
         }