perf ui progress: Per progress bar state

That will ease using a progress bar across multiple functions, like in
the upcoming patches that will present a progress bar when collapsing
histograms.

Based on a previous patch by Namhyung Kim.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-cr7lq7ud9fj21bg7wvq27w1u@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

4 files changed, 36 insertions, 17 deletions

diff --git a/tools/perf/ui/gtk/progress.c b/tools/perf/ui/gtk/progress.c
index 195c7f94f98e..b656655fbc39 100644
--- a/tools/perf/ui/gtk/progress.c
+++ b/tools/perf/ui/gtk/progress.c
@@ -7,14 +7,14 @@
 static GtkWidget *dialog;
 static GtkWidget *progress;
 
-static void gtk_ui_progress__update(u64 curr, u64 total, const char *title)
+static void gtk_ui_progress__update(struct ui_progress *p)
 {
-        double fraction = total ? 1.0 * curr / total : 0.0;
+        double fraction = p->total ? 1.0 * p->curr / p->total : 0.0;
         char buf[1024];
 
         if (dialog == NULL) {
                 GtkWidget *vbox = gtk_vbox_new(TRUE, 5);
-                GtkWidget *label = gtk_label_new(title);
+                GtkWidget *label = gtk_label_new(p->title);
 
                 dialog = gtk_window_new(GTK_WINDOW_TOPLEVEL);
                 progress = gtk_progress_bar_new();
@@ -32,7 +32,7 @@ static void gtk_ui_progress__update(u64 curr, u64 total, const char *title)
         }
 
         gtk_progress_bar_set_fraction(GTK_PROGRESS_BAR(progress), fraction);
-        snprintf(buf, sizeof(buf), "%"PRIu64" / %"PRIu64, curr, total);
+        snprintf(buf, sizeof(buf), "%"PRIu64" / %"PRIu64, p->curr, p->total);
         gtk_progress_bar_set_text(GTK_PROGRESS_BAR(progress), buf);
 
         /* we didn't call gtk_main yet, so do it manually */
diff --git a/tools/perf/ui/progress.c b/tools/perf/ui/progress.c
index d753821b6e0b..a0f24c7115c5 100644
--- a/tools/perf/ui/progress.c
+++ b/tools/perf/ui/progress.c
@@ -1,9 +1,7 @@
 #include "../cache.h"
 #include "progress.h"
 
-static void null_progress__update(u64 curr __maybe_unused,
-                                  u64 total __maybe_unused,
-                                  const char *title __maybe_unused)
+static void null_progress__update(struct ui_progress *p __maybe_unused)
 {
 }
 
@@ -14,9 +12,23 @@ static struct ui_progress_ops null_progress__ops =
 
 struct ui_progress_ops *ui_progress__ops = &null_progress__ops;
 
-void ui_progress__update(u64 curr, u64 total, const char *title)
+void ui_progress__update(struct ui_progress *p, u64 adv)
 {
-        return ui_progress__ops->update(curr, total, title);
+        p->curr += adv;
+
+        if (p->curr >= p->next) {
+                p->next += p->step;
+                ui_progress__ops->update(p);
+        }
+}
+
+void ui_progress__init(struct ui_progress *p, u64 total, const char *title)
+{
+        p->curr = 0;
+        p->next = p->step = total / 16;
+        p->total = total;
+        p->title = title;
+
 }
 
 void ui_progress__finish(void)
diff --git a/tools/perf/ui/progress.h b/tools/perf/ui/progress.h
index d41bde5908a6..29ec8efffefb 100644
--- a/tools/perf/ui/progress.h
+++ b/tools/perf/ui/progress.h
@@ -3,14 +3,21 @@
 
 #include <../types.h>
 
+void ui_progress__finish(void);
+ 
+struct ui_progress {
+        const char *title;
+        u64 curr, next, step, total;
+};
+ 
+void ui_progress__init(struct ui_progress *p, u64 total, const char *title);
+void ui_progress__update(struct ui_progress *p, u64 adv);
+
 struct ui_progress_ops {
-        void (*update)(u64, u64, const char *);
+        void (*update)(struct ui_progress *p);
         void (*finish)(void);
 };
 
 extern struct ui_progress_ops *ui_progress__ops;
 
-void ui_progress__update(u64 curr, u64 total, const char *title);
-void ui_progress__finish(void);
-
 #endif
diff --git a/tools/perf/ui/tui/progress.c b/tools/perf/ui/tui/progress.c
index 0fcc5a1f525a..3e2d936d7443 100644
--- a/tools/perf/ui/tui/progress.c
+++ b/tools/perf/ui/tui/progress.c
@@ -5,7 +5,7 @@
 #include "tui.h"
 #include "../browser.h"
 
-static void tui_progress__update(u64 curr, u64 total, const char *title)
+static void tui_progress__update(struct ui_progress *p)
 {
         int bar, y;
         /*
@@ -15,7 +15,7 @@ static void tui_progress__update(u64 curr, u64 total, const char *title)
         if (use_browser <= 0)
                 return;
 
-        if (total == 0)
+        if (p->total == 0)
                 return;
 
         ui__refresh_dimensions(true);
@@ -24,9 +24,9 @@ static void tui_progress__update(u64 curr, u64 total, const char *title)
         SLsmg_set_color(0);
         SLsmg_draw_box(y, 0, 3, SLtt_Screen_Cols);
         SLsmg_gotorc(y++, 1);
-        SLsmg_write_string((char *)title);
+        SLsmg_write_string((char *)p->title);
         SLsmg_set_color(HE_COLORSET_SELECTED);
-        bar = ((SLtt_Screen_Cols - 2) * curr) / total;
+        bar = ((SLtt_Screen_Cols - 2) * p->curr) / p->total;
         SLsmg_fill_region(y, 1, 1, bar, ' ');
         SLsmg_refresh();
         pthread_mutex_unlock(&ui__lock);