diff options
author | Adrian Hunter <adrian.hunter@intel.com> | 2013-08-27 04:23:03 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-08-29 10:51:31 -0400 |
commit | 314add6b1f045b59ca39683bd0cbc5310cd203f2 (patch) | |
tree | e0583a022963b6e02b6f587db07f8b52985b4532 /tools/perf/tests | |
parent | 00e4cb1ced1b17c35465defafe86d156cbd7544e (diff) |
perf tools: change machine__findnew_thread() to set thread pid
Add a new parameter for 'pid' to machine__findnew_thread().
Change callers to pass 'pid' when it is known.
Note that callers sometimes want to find the main thread
which has the memory maps. The main thread has tid == pid
so the usage in that case is:
machine__findnew_thread(machine, pid, pid)
whereas the usage to find the specific thread is:
machine__findnew_thread(machine, pid, tid)
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1377591794-30553-2-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/tests')
-rw-r--r-- | tools/perf/tests/code-reading.c | 4 | ||||
-rw-r--r-- | tools/perf/tests/hists_link.c | 3 |
2 files changed, 4 insertions, 3 deletions
diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c index df9afd9cab4c..6fb781d5586c 100644 --- a/tools/perf/tests/code-reading.c +++ b/tools/perf/tests/code-reading.c | |||
@@ -257,7 +257,7 @@ static int process_sample_event(struct machine *machine, | |||
257 | return -1; | 257 | return -1; |
258 | } | 258 | } |
259 | 259 | ||
260 | thread = machine__findnew_thread(machine, sample.pid); | 260 | thread = machine__findnew_thread(machine, sample.pid, sample.pid); |
261 | if (!thread) { | 261 | if (!thread) { |
262 | pr_debug("machine__findnew_thread failed\n"); | 262 | pr_debug("machine__findnew_thread failed\n"); |
263 | return -1; | 263 | return -1; |
@@ -446,7 +446,7 @@ static int do_test_code_reading(bool try_kcore) | |||
446 | goto out_err; | 446 | goto out_err; |
447 | } | 447 | } |
448 | 448 | ||
449 | thread = machine__findnew_thread(machine, pid); | 449 | thread = machine__findnew_thread(machine, pid, pid); |
450 | if (!thread) { | 450 | if (!thread) { |
451 | pr_debug("machine__findnew_thread failed\n"); | 451 | pr_debug("machine__findnew_thread failed\n"); |
452 | goto out_err; | 452 | goto out_err; |
diff --git a/tools/perf/tests/hists_link.c b/tools/perf/tests/hists_link.c index 50bfb01183ea..87f9f7280c40 100644 --- a/tools/perf/tests/hists_link.c +++ b/tools/perf/tests/hists_link.c | |||
@@ -88,7 +88,8 @@ static struct machine *setup_fake_machine(struct machines *machines) | |||
88 | for (i = 0; i < ARRAY_SIZE(fake_threads); i++) { | 88 | for (i = 0; i < ARRAY_SIZE(fake_threads); i++) { |
89 | struct thread *thread; | 89 | struct thread *thread; |
90 | 90 | ||
91 | thread = machine__findnew_thread(machine, fake_threads[i].pid); | 91 | thread = machine__findnew_thread(machine, fake_threads[i].pid, |
92 | fake_threads[i].pid); | ||
92 | if (thread == NULL) | 93 | if (thread == NULL) |
93 | goto out; | 94 | goto out; |
94 | 95 | ||