diff options
author | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2012-12-09 10:22:29 -0500 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2012-12-09 10:22:29 -0500 |
commit | 95dd6d906651a239c3d6a393743602d9f1f84c00 (patch) | |
tree | 786150ce6e1e87d1dd25e0c4ce3325a9ac0d057d /sound | |
parent | 13100628881a329f0cc78461b4330bb79d067c07 (diff) | |
parent | eb781f78006e67fa1a3a2f58b42be0dd97ac1a0e (diff) |
Merge remote-tracking branch 'asoc/topic/wm8753' into asoc-next
Diffstat (limited to 'sound')
-rw-r--r-- | sound/soc/codecs/wm8753.c | 33 |
1 files changed, 6 insertions, 27 deletions
diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c index 2e4a775ae560..50a5dc7974e1 100644 --- a/sound/soc/codecs/wm8753.c +++ b/sound/soc/codecs/wm8753.c | |||
@@ -1562,36 +1562,25 @@ static int __devinit wm8753_spi_probe(struct spi_device *spi) | |||
1562 | 1562 | ||
1563 | spi_set_drvdata(spi, wm8753); | 1563 | spi_set_drvdata(spi, wm8753); |
1564 | 1564 | ||
1565 | wm8753->regmap = regmap_init_spi(spi, &wm8753_regmap); | 1565 | wm8753->regmap = devm_regmap_init_spi(spi, &wm8753_regmap); |
1566 | if (IS_ERR(wm8753->regmap)) { | 1566 | if (IS_ERR(wm8753->regmap)) { |
1567 | ret = PTR_ERR(wm8753->regmap); | 1567 | ret = PTR_ERR(wm8753->regmap); |
1568 | dev_err(&spi->dev, "Failed to allocate register map: %d\n", | 1568 | dev_err(&spi->dev, "Failed to allocate register map: %d\n", |
1569 | ret); | 1569 | ret); |
1570 | goto err; | 1570 | return ret; |
1571 | } | 1571 | } |
1572 | 1572 | ||
1573 | ret = snd_soc_register_codec(&spi->dev, &soc_codec_dev_wm8753, | 1573 | ret = snd_soc_register_codec(&spi->dev, &soc_codec_dev_wm8753, |
1574 | wm8753_dai, ARRAY_SIZE(wm8753_dai)); | 1574 | wm8753_dai, ARRAY_SIZE(wm8753_dai)); |
1575 | if (ret != 0) { | 1575 | if (ret != 0) |
1576 | dev_err(&spi->dev, "Failed to register CODEC: %d\n", ret); | 1576 | dev_err(&spi->dev, "Failed to register CODEC: %d\n", ret); |
1577 | goto err_regmap; | ||
1578 | } | ||
1579 | 1577 | ||
1580 | return 0; | ||
1581 | |||
1582 | err_regmap: | ||
1583 | regmap_exit(wm8753->regmap); | ||
1584 | err: | ||
1585 | return ret; | 1578 | return ret; |
1586 | } | 1579 | } |
1587 | 1580 | ||
1588 | static int __devexit wm8753_spi_remove(struct spi_device *spi) | 1581 | static int __devexit wm8753_spi_remove(struct spi_device *spi) |
1589 | { | 1582 | { |
1590 | struct wm8753_priv *wm8753 = spi_get_drvdata(spi); | ||
1591 | |||
1592 | snd_soc_unregister_codec(&spi->dev); | 1583 | snd_soc_unregister_codec(&spi->dev); |
1593 | regmap_exit(wm8753->regmap); | ||
1594 | kfree(wm8753); | ||
1595 | return 0; | 1584 | return 0; |
1596 | } | 1585 | } |
1597 | 1586 | ||
@@ -1620,35 +1609,25 @@ static __devinit int wm8753_i2c_probe(struct i2c_client *i2c, | |||
1620 | 1609 | ||
1621 | i2c_set_clientdata(i2c, wm8753); | 1610 | i2c_set_clientdata(i2c, wm8753); |
1622 | 1611 | ||
1623 | wm8753->regmap = regmap_init_i2c(i2c, &wm8753_regmap); | 1612 | wm8753->regmap = devm_regmap_init_i2c(i2c, &wm8753_regmap); |
1624 | if (IS_ERR(wm8753->regmap)) { | 1613 | if (IS_ERR(wm8753->regmap)) { |
1625 | ret = PTR_ERR(wm8753->regmap); | 1614 | ret = PTR_ERR(wm8753->regmap); |
1626 | dev_err(&i2c->dev, "Failed to allocate register map: %d\n", | 1615 | dev_err(&i2c->dev, "Failed to allocate register map: %d\n", |
1627 | ret); | 1616 | ret); |
1628 | goto err; | 1617 | return ret; |
1629 | } | 1618 | } |
1630 | 1619 | ||
1631 | ret = snd_soc_register_codec(&i2c->dev, &soc_codec_dev_wm8753, | 1620 | ret = snd_soc_register_codec(&i2c->dev, &soc_codec_dev_wm8753, |
1632 | wm8753_dai, ARRAY_SIZE(wm8753_dai)); | 1621 | wm8753_dai, ARRAY_SIZE(wm8753_dai)); |
1633 | if (ret != 0) { | 1622 | if (ret != 0) |
1634 | dev_err(&i2c->dev, "Failed to register CODEC: %d\n", ret); | 1623 | dev_err(&i2c->dev, "Failed to register CODEC: %d\n", ret); |
1635 | goto err_regmap; | ||
1636 | } | ||
1637 | 1624 | ||
1638 | return 0; | ||
1639 | |||
1640 | err_regmap: | ||
1641 | regmap_exit(wm8753->regmap); | ||
1642 | err: | ||
1643 | return ret; | 1625 | return ret; |
1644 | } | 1626 | } |
1645 | 1627 | ||
1646 | static __devexit int wm8753_i2c_remove(struct i2c_client *client) | 1628 | static __devexit int wm8753_i2c_remove(struct i2c_client *client) |
1647 | { | 1629 | { |
1648 | struct wm8753_priv *wm8753 = i2c_get_clientdata(client); | ||
1649 | |||
1650 | snd_soc_unregister_codec(&client->dev); | 1630 | snd_soc_unregister_codec(&client->dev); |
1651 | regmap_exit(wm8753->regmap); | ||
1652 | return 0; | 1631 | return 0; |
1653 | } | 1632 | } |
1654 | 1633 | ||