aboutsummaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2014-02-25 11:16:16 -0500
committerTakashi Iwai <tiwai@suse.de>2014-02-26 10:45:27 -0500
commit6dfb5aff7d922ba7ce2f4155c55a921c7ee45e7d (patch)
tree6b3ace99ee7498a15867db032ad9223683039bee /sound
parent6f002b02166cc037025c0d1600a0e638a82145ac (diff)
ALSA: ice17xx: Use standard printk helpers
Convert with dev_err() and co from snd_printk(), etc. Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
-rw-r--r--sound/pci/ice1712/aureon.c7
-rw-r--r--sound/pci/ice1712/delta.c5
-rw-r--r--sound/pci/ice1712/ews.c12
-rw-r--r--sound/pci/ice1712/ice1712.c33
-rw-r--r--sound/pci/ice1712/ice1724.c45
-rw-r--r--sound/pci/ice1712/juli.c14
-rw-r--r--sound/pci/ice1712/prodigy192.c13
-rw-r--r--sound/pci/ice1712/quartet.c6
8 files changed, 76 insertions, 59 deletions
diff --git a/sound/pci/ice1712/aureon.c b/sound/pci/ice1712/aureon.c
index 55902ec40344..3b3cf4ac9060 100644
--- a/sound/pci/ice1712/aureon.c
+++ b/sound/pci/ice1712/aureon.c
@@ -1937,9 +1937,12 @@ static int aureon_add_controls(struct snd_ice1712 *ice)
1937 snd_ice1712_save_gpio_status(ice); 1937 snd_ice1712_save_gpio_status(ice);
1938 id = aureon_cs8415_get(ice, CS8415_ID); 1938 id = aureon_cs8415_get(ice, CS8415_ID);
1939 if (id != 0x41) 1939 if (id != 0x41)
1940 snd_printk(KERN_INFO "No CS8415 chip. Skipping CS8415 controls.\n"); 1940 dev_info(ice->card->dev,
1941 "No CS8415 chip. Skipping CS8415 controls.\n");
1941 else if ((id & 0x0F) != 0x01) 1942 else if ((id & 0x0F) != 0x01)
1942 snd_printk(KERN_INFO "Detected unsupported CS8415 rev. (%c)\n", (char)((id & 0x0F) + 'A' - 1)); 1943 dev_info(ice->card->dev,
1944 "Detected unsupported CS8415 rev. (%c)\n",
1945 (char)((id & 0x0F) + 'A' - 1));
1943 else { 1946 else {
1944 for (i = 0; i < ARRAY_SIZE(cs8415_controls); i++) { 1947 for (i = 0; i < ARRAY_SIZE(cs8415_controls); i++) {
1945 struct snd_kcontrol *kctl; 1948 struct snd_kcontrol *kctl;
diff --git a/sound/pci/ice1712/delta.c b/sound/pci/ice1712/delta.c
index 9e28cc12969b..98e5e955261e 100644
--- a/sound/pci/ice1712/delta.c
+++ b/sound/pci/ice1712/delta.c
@@ -425,7 +425,8 @@ static int snd_ice1712_delta1010lt_wordclock_status_get(struct snd_kcontrol *kco
425 struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol); 425 struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
426 426
427 if (snd_i2c_sendbytes(ice->cs8427, &reg, 1) != 1) 427 if (snd_i2c_sendbytes(ice->cs8427, &reg, 1) != 1)
428 snd_printk(KERN_ERR "unable to send register 0x%x byte to CS8427\n", reg); 428 dev_err(ice->card->dev,
429 "unable to send register 0x%x byte to CS8427\n", reg);
429 snd_i2c_readbytes(ice->cs8427, &reg, 1); 430 snd_i2c_readbytes(ice->cs8427, &reg, 1);
430 ucontrol->value.integer.value[0] = (reg & CS8427_UNLOCK) ? 1 : 0; 431 ucontrol->value.integer.value[0] = (reg & CS8427_UNLOCK) ? 1 : 0;
431 return 0; 432 return 0;
@@ -637,7 +638,7 @@ static int snd_ice1712_delta_init(struct snd_ice1712 *ice)
637 case ICE1712_SUBDEVICE_VX442: 638 case ICE1712_SUBDEVICE_VX442:
638 case ICE1712_SUBDEVICE_DELTA66E: 639 case ICE1712_SUBDEVICE_DELTA66E:
639 if ((err = snd_i2c_bus_create(ice->card, "ICE1712 GPIO 1", NULL, &ice->i2c)) < 0) { 640 if ((err = snd_i2c_bus_create(ice->card, "ICE1712 GPIO 1", NULL, &ice->i2c)) < 0) {
640 snd_printk(KERN_ERR "unable to create I2C bus\n"); 641 dev_err(ice->card->dev, "unable to create I2C bus\n");
641 return err; 642 return err;
642 } 643 }
643 ice->i2c->private_data = ice; 644 ice->i2c->private_data = ice;
diff --git a/sound/pci/ice1712/ews.c b/sound/pci/ice1712/ews.c
index bc2e7011c55d..817a1bc50a60 100644
--- a/sound/pci/ice1712/ews.c
+++ b/sound/pci/ice1712/ews.c
@@ -163,7 +163,8 @@ static int snd_ice1712_ews88mt_chip_select(struct snd_ice1712 *ice, int chip_mas
163 163
164 __error: 164 __error:
165 snd_i2c_unlock(ice->i2c); 165 snd_i2c_unlock(ice->i2c);
166 snd_printk(KERN_ERR "AK4524 chip select failed, check cable to the front module\n"); 166 dev_err(ice->card->dev,
167 "AK4524 chip select failed, check cable to the front module\n");
167 return -EIO; 168 return -EIO;
168} 169}
169 170
@@ -174,7 +175,7 @@ static void ews88mt_ak4524_lock(struct snd_akm4xxx *ak, int chip)
174 unsigned char tmp; 175 unsigned char tmp;
175 /* assert AK4524 CS */ 176 /* assert AK4524 CS */
176 if (snd_ice1712_ews88mt_chip_select(ice, ~(1 << chip) & 0x0f) < 0) 177 if (snd_ice1712_ews88mt_chip_select(ice, ~(1 << chip) & 0x0f) < 0)
177 snd_printk(KERN_ERR "fatal error (ews88mt chip select)\n"); 178 dev_err(ice->card->dev, "fatal error (ews88mt chip select)\n");
178 snd_ice1712_save_gpio_status(ice); 179 snd_ice1712_save_gpio_status(ice);
179 tmp = ICE1712_EWS88_SERIAL_DATA | 180 tmp = ICE1712_EWS88_SERIAL_DATA |
180 ICE1712_EWS88_SERIAL_CLOCK | 181 ICE1712_EWS88_SERIAL_CLOCK |
@@ -456,7 +457,7 @@ static int snd_ice1712_ews_init(struct snd_ice1712 *ice)
456 457
457 /* create i2c */ 458 /* create i2c */
458 if ((err = snd_i2c_bus_create(ice->card, "ICE1712 GPIO 1", NULL, &ice->i2c)) < 0) { 459 if ((err = snd_i2c_bus_create(ice->card, "ICE1712 GPIO 1", NULL, &ice->i2c)) < 0) {
459 snd_printk(KERN_ERR "unable to create I2C bus\n"); 460 dev_err(ice->card->dev, "unable to create I2C bus\n");
460 return err; 461 return err;
461 } 462 }
462 ice->i2c->private_data = ice; 463 ice->i2c->private_data = ice;
@@ -469,7 +470,8 @@ static int snd_ice1712_ews_init(struct snd_ice1712 *ice)
469 ICE1712_6FIRE_PCF9554_ADDR, 470 ICE1712_6FIRE_PCF9554_ADDR,
470 &spec->i2cdevs[EWS_I2C_6FIRE]); 471 &spec->i2cdevs[EWS_I2C_6FIRE]);
471 if (err < 0) { 472 if (err < 0) {
472 snd_printk(KERN_ERR "PCF9554 initialization failed\n"); 473 dev_err(ice->card->dev,
474 "PCF9554 initialization failed\n");
473 return err; 475 return err;
474 } 476 }
475 snd_ice1712_6fire_write_pca(ice, PCF9554_REG_CONFIG, 0x80); 477 snd_ice1712_6fire_write_pca(ice, PCF9554_REG_CONFIG, 0x80);
@@ -834,7 +836,7 @@ static int snd_ice1712_6fire_read_pca(struct snd_ice1712 *ice, unsigned char reg
834 byte = 0; 836 byte = 0;
835 if (snd_i2c_readbytes(spec->i2cdevs[EWS_I2C_6FIRE], &byte, 1) != 1) { 837 if (snd_i2c_readbytes(spec->i2cdevs[EWS_I2C_6FIRE], &byte, 1) != 1) {
836 snd_i2c_unlock(ice->i2c); 838 snd_i2c_unlock(ice->i2c);
837 printk(KERN_ERR "cannot read pca\n"); 839 dev_err(ice->card->dev, "cannot read pca\n");
838 return -EIO; 840 return -EIO;
839 } 841 }
840 snd_i2c_unlock(ice->i2c); 842 snd_i2c_unlock(ice->i2c);
diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
index 99c022a0d612..0710ec7e69d3 100644
--- a/sound/pci/ice1712/ice1712.c
+++ b/sound/pci/ice1712/ice1712.c
@@ -394,7 +394,7 @@ int snd_ice1712_init_cs8427(struct snd_ice1712 *ice, int addr)
394 err = snd_cs8427_create(ice->i2c, addr, 394 err = snd_cs8427_create(ice->i2c, addr,
395 (ice->cs8427_timeout * HZ) / 1000, &ice->cs8427); 395 (ice->cs8427_timeout * HZ) / 1000, &ice->cs8427);
396 if (err < 0) { 396 if (err < 0) {
397 snd_printk(KERN_ERR "CS8427 initialization failed\n"); 397 dev_err(ice->card->dev, "CS8427 initialization failed\n");
398 return err; 398 return err;
399 } 399 }
400 ice->spdif.ops.open = open_cs8427; 400 ice->spdif.ops.open = open_cs8427;
@@ -467,7 +467,7 @@ static irqreturn_t snd_ice1712_interrupt(int irq, void *dev_id)
467 u16 pbkstatus; 467 u16 pbkstatus;
468 struct snd_pcm_substream *substream; 468 struct snd_pcm_substream *substream;
469 pbkstatus = inw(ICEDS(ice, INTSTAT)); 469 pbkstatus = inw(ICEDS(ice, INTSTAT));
470 /* printk(KERN_DEBUG "pbkstatus = 0x%x\n", pbkstatus); */ 470 /* dev_dbg(ice->card->dev, "pbkstatus = 0x%x\n", pbkstatus); */
471 for (idx = 0; idx < 6; idx++) { 471 for (idx = 0; idx < 6; idx++) {
472 if ((pbkstatus & (3 << (idx * 2))) == 0) 472 if ((pbkstatus & (3 << (idx * 2))) == 0)
473 continue; 473 continue;
@@ -903,7 +903,8 @@ static int snd_ice1712_pcm(struct snd_ice1712 *ice, int device, struct snd_pcm *
903 if (rpcm) 903 if (rpcm)
904 *rpcm = pcm; 904 *rpcm = pcm;
905 905
906 printk(KERN_WARNING "Consumer PCM code does not work well at the moment --jk\n"); 906 dev_warn(ice->card->dev,
907 "Consumer PCM code does not work well at the moment --jk\n");
907 908
908 return 0; 909 return 0;
909} 910}
@@ -1534,7 +1535,8 @@ static int snd_ice1712_ac97_mixer(struct snd_ice1712 *ice)
1534 ac97.private_free = snd_ice1712_mixer_free_ac97; 1535 ac97.private_free = snd_ice1712_mixer_free_ac97;
1535 err = snd_ac97_mixer(pbus, &ac97, &ice->ac97); 1536 err = snd_ac97_mixer(pbus, &ac97, &ice->ac97);
1536 if (err < 0) 1537 if (err < 0)
1537 printk(KERN_WARNING "ice1712: cannot initialize ac97 for consumer, skipped\n"); 1538 dev_warn(ice->card->dev,
1539 "cannot initialize ac97 for consumer, skipped\n");
1538 else { 1540 else {
1539 err = snd_ctl_add(ice->card, snd_ctl_new1(&snd_ice1712_mixer_digmix_route_ac97, ice)); 1541 err = snd_ctl_add(ice->card, snd_ctl_new1(&snd_ice1712_mixer_digmix_route_ac97, ice));
1540 if (err < 0) 1542 if (err < 0)
@@ -1552,7 +1554,8 @@ static int snd_ice1712_ac97_mixer(struct snd_ice1712 *ice)
1552 ac97.private_free = snd_ice1712_mixer_free_ac97; 1554 ac97.private_free = snd_ice1712_mixer_free_ac97;
1553 err = snd_ac97_mixer(pbus, &ac97, &ice->ac97); 1555 err = snd_ac97_mixer(pbus, &ac97, &ice->ac97);
1554 if (err < 0) 1556 if (err < 0)
1555 printk(KERN_WARNING "ice1712: cannot initialize pro ac97, skipped\n"); 1557 dev_warn(ice->card->dev,
1558 "cannot initialize pro ac97, skipped\n");
1556 else 1559 else
1557 return 0; 1560 return 0;
1558 } 1561 }
@@ -2332,7 +2335,8 @@ static int snd_ice1712_read_eeprom(struct snd_ice1712 *ice,
2332 pci_read_config_word(ice->pci, PCI_SUBSYSTEM_ID, &device); 2335 pci_read_config_word(ice->pci, PCI_SUBSYSTEM_ID, &device);
2333 ice->eeprom.subvendor = ((unsigned int)swab16(vendor) << 16) | swab16(device); 2336 ice->eeprom.subvendor = ((unsigned int)swab16(vendor) << 16) | swab16(device);
2334 if (ice->eeprom.subvendor == 0 || ice->eeprom.subvendor == (unsigned int)-1) { 2337 if (ice->eeprom.subvendor == 0 || ice->eeprom.subvendor == (unsigned int)-1) {
2335 printk(KERN_ERR "ice1712: No valid ID is found\n"); 2338 dev_err(ice->card->dev,
2339 "No valid ID is found\n");
2336 return -ENXIO; 2340 return -ENXIO;
2337 } 2341 }
2338 } 2342 }
@@ -2340,21 +2344,22 @@ static int snd_ice1712_read_eeprom(struct snd_ice1712 *ice,
2340 for (tbl = card_tables; *tbl; tbl++) { 2344 for (tbl = card_tables; *tbl; tbl++) {
2341 for (c = *tbl; c->subvendor; c++) { 2345 for (c = *tbl; c->subvendor; c++) {
2342 if (modelname && c->model && !strcmp(modelname, c->model)) { 2346 if (modelname && c->model && !strcmp(modelname, c->model)) {
2343 printk(KERN_INFO "ice1712: Using board model %s\n", c->name); 2347 dev_info(ice->card->dev,
2348 "Using board model %s\n", c->name);
2344 ice->eeprom.subvendor = c->subvendor; 2349 ice->eeprom.subvendor = c->subvendor;
2345 } else if (c->subvendor != ice->eeprom.subvendor) 2350 } else if (c->subvendor != ice->eeprom.subvendor)
2346 continue; 2351 continue;
2347 if (!c->eeprom_size || !c->eeprom_data) 2352 if (!c->eeprom_size || !c->eeprom_data)
2348 goto found; 2353 goto found;
2349 /* if the EEPROM is given by the driver, use it */ 2354 /* if the EEPROM is given by the driver, use it */
2350 snd_printdd("using the defined eeprom..\n"); 2355 dev_dbg(ice->card->dev, "using the defined eeprom..\n");
2351 ice->eeprom.version = 1; 2356 ice->eeprom.version = 1;
2352 ice->eeprom.size = c->eeprom_size + 6; 2357 ice->eeprom.size = c->eeprom_size + 6;
2353 memcpy(ice->eeprom.data, c->eeprom_data, c->eeprom_size); 2358 memcpy(ice->eeprom.data, c->eeprom_data, c->eeprom_size);
2354 goto read_skipped; 2359 goto read_skipped;
2355 } 2360 }
2356 } 2361 }
2357 printk(KERN_WARNING "ice1712: No matching model found for ID 0x%x\n", 2362 dev_warn(ice->card->dev, "No matching model found for ID 0x%x\n",
2358 ice->eeprom.subvendor); 2363 ice->eeprom.subvendor);
2359 2364
2360 found: 2365 found:
@@ -2362,12 +2367,13 @@ static int snd_ice1712_read_eeprom(struct snd_ice1712 *ice,
2362 if (ice->eeprom.size < 6) 2367 if (ice->eeprom.size < 6)
2363 ice->eeprom.size = 32; /* FIXME: any cards without the correct size? */ 2368 ice->eeprom.size = 32; /* FIXME: any cards without the correct size? */
2364 else if (ice->eeprom.size > 32) { 2369 else if (ice->eeprom.size > 32) {
2365 snd_printk(KERN_ERR "invalid EEPROM (size = %i)\n", ice->eeprom.size); 2370 dev_err(ice->card->dev,
2371 "invalid EEPROM (size = %i)\n", ice->eeprom.size);
2366 return -EIO; 2372 return -EIO;
2367 } 2373 }
2368 ice->eeprom.version = snd_ice1712_read_i2c(ice, dev, 0x05); 2374 ice->eeprom.version = snd_ice1712_read_i2c(ice, dev, 0x05);
2369 if (ice->eeprom.version != 1) { 2375 if (ice->eeprom.version != 1) {
2370 snd_printk(KERN_ERR "invalid EEPROM version %i\n", 2376 dev_err(ice->card->dev, "invalid EEPROM version %i\n",
2371 ice->eeprom.version); 2377 ice->eeprom.version);
2372 /* return -EIO; */ 2378 /* return -EIO; */
2373 } 2379 }
@@ -2553,7 +2559,8 @@ static int snd_ice1712_create(struct snd_card *card,
2553 /* check, if we can restrict PCI DMA transfers to 28 bits */ 2559 /* check, if we can restrict PCI DMA transfers to 28 bits */
2554 if (pci_set_dma_mask(pci, DMA_BIT_MASK(28)) < 0 || 2560 if (pci_set_dma_mask(pci, DMA_BIT_MASK(28)) < 0 ||
2555 pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(28)) < 0) { 2561 pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(28)) < 0) {
2556 snd_printk(KERN_ERR "architecture does not support 28bit PCI busmaster DMA\n"); 2562 dev_err(card->dev,
2563 "architecture does not support 28bit PCI busmaster DMA\n");
2557 pci_disable_device(pci); 2564 pci_disable_device(pci);
2558 return -ENXIO; 2565 return -ENXIO;
2559 } 2566 }
@@ -2609,7 +2616,7 @@ static int snd_ice1712_create(struct snd_card *card,
2609 2616
2610 if (request_irq(pci->irq, snd_ice1712_interrupt, IRQF_SHARED, 2617 if (request_irq(pci->irq, snd_ice1712_interrupt, IRQF_SHARED,
2611 KBUILD_MODNAME, ice)) { 2618 KBUILD_MODNAME, ice)) {
2612 snd_printk(KERN_ERR "unable to grab IRQ %d\n", pci->irq); 2619 dev_err(card->dev, "unable to grab IRQ %d\n", pci->irq);
2613 snd_ice1712_free(ice); 2620 snd_ice1712_free(ice);
2614 return -EIO; 2621 return -EIO;
2615 } 2622 }
diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c
index cf1ba116a772..5e7948f3efe9 100644
--- a/sound/pci/ice1712/ice1724.c
+++ b/sound/pci/ice1712/ice1724.c
@@ -146,7 +146,7 @@ static unsigned char snd_vt1724_ac97_ready(struct snd_ice1712 *ice)
146 continue; 146 continue;
147 return old_cmd; 147 return old_cmd;
148 } 148 }
149 snd_printd(KERN_ERR "snd_vt1724_ac97_ready: timeout\n"); 149 dev_dbg(ice->card->dev, "snd_vt1724_ac97_ready: timeout\n");
150 return old_cmd; 150 return old_cmd;
151} 151}
152 152
@@ -156,7 +156,7 @@ static int snd_vt1724_ac97_wait_bit(struct snd_ice1712 *ice, unsigned char bit)
156 for (tm = 0; tm < 0x10000; tm++) 156 for (tm = 0; tm < 0x10000; tm++)
157 if ((inb(ICEMT1724(ice, AC97_CMD)) & bit) == 0) 157 if ((inb(ICEMT1724(ice, AC97_CMD)) & bit) == 0)
158 return 0; 158 return 0;
159 snd_printd(KERN_ERR "snd_vt1724_ac97_wait_bit: timeout\n"); 159 dev_dbg(ice->card->dev, "snd_vt1724_ac97_wait_bit: timeout\n");
160 return -EIO; 160 return -EIO;
161} 161}
162 162
@@ -430,10 +430,10 @@ static irqreturn_t snd_vt1724_interrupt(int irq, void *dev_id)
430 spin_lock(&ice->reg_lock); 430 spin_lock(&ice->reg_lock);
431 if (++timeout > 10) { 431 if (++timeout > 10) {
432 status = inb(ICEREG1724(ice, IRQSTAT)); 432 status = inb(ICEREG1724(ice, IRQSTAT));
433 printk(KERN_ERR "ice1724: Too long irq loop, " 433 dev_err(ice->card->dev,
434 "status = 0x%x\n", status); 434 "Too long irq loop, status = 0x%x\n", status);
435 if (status & VT1724_IRQ_MPU_TX) { 435 if (status & VT1724_IRQ_MPU_TX) {
436 printk(KERN_ERR "ice1724: Disabling MPU_TX\n"); 436 dev_err(ice->card->dev, "Disabling MPU_TX\n");
437 enable_midi_irq(ice, VT1724_IRQ_MPU_TX, 0); 437 enable_midi_irq(ice, VT1724_IRQ_MPU_TX, 0);
438 } 438 }
439 spin_unlock(&ice->reg_lock); 439 spin_unlock(&ice->reg_lock);
@@ -801,7 +801,7 @@ static int snd_vt1724_playback_pro_prepare(struct snd_pcm_substream *substream)
801 spin_unlock_irq(&ice->reg_lock); 801 spin_unlock_irq(&ice->reg_lock);
802 802
803 /* 803 /*
804 printk(KERN_DEBUG "pro prepare: ch = %d, addr = 0x%x, " 804 dev_dbg(ice->card->dev, "pro prepare: ch = %d, addr = 0x%x, "
805 "buffer = 0x%x, period = 0x%x\n", 805 "buffer = 0x%x, period = 0x%x\n",
806 substream->runtime->channels, 806 substream->runtime->channels,
807 (unsigned int)substream->runtime->dma_addr, 807 (unsigned int)substream->runtime->dma_addr,
@@ -821,13 +821,13 @@ static snd_pcm_uframes_t snd_vt1724_playback_pro_pointer(struct snd_pcm_substrea
821#if 0 /* read PLAYBACK_ADDR */ 821#if 0 /* read PLAYBACK_ADDR */
822 ptr = inl(ICEMT1724(ice, PLAYBACK_ADDR)); 822 ptr = inl(ICEMT1724(ice, PLAYBACK_ADDR));
823 if (ptr < substream->runtime->dma_addr) { 823 if (ptr < substream->runtime->dma_addr) {
824 snd_printd("ice1724: invalid negative ptr\n"); 824 dev_dbg(ice->card->dev, "invalid negative ptr\n");
825 return 0; 825 return 0;
826 } 826 }
827 ptr -= substream->runtime->dma_addr; 827 ptr -= substream->runtime->dma_addr;
828 ptr = bytes_to_frames(substream->runtime, ptr); 828 ptr = bytes_to_frames(substream->runtime, ptr);
829 if (ptr >= substream->runtime->buffer_size) { 829 if (ptr >= substream->runtime->buffer_size) {
830 snd_printd("ice1724: invalid ptr %d (size=%d)\n", 830 dev_dbg(ice->card->dev, "invalid ptr %d (size=%d)\n",
831 (int)ptr, (int)substream->runtime->period_size); 831 (int)ptr, (int)substream->runtime->period_size);
832 return 0; 832 return 0;
833 } 833 }
@@ -840,7 +840,7 @@ static snd_pcm_uframes_t snd_vt1724_playback_pro_pointer(struct snd_pcm_substrea
840 else if (ptr <= substream->runtime->buffer_size) 840 else if (ptr <= substream->runtime->buffer_size)
841 ptr = substream->runtime->buffer_size - ptr; 841 ptr = substream->runtime->buffer_size - ptr;
842 else { 842 else {
843 snd_printd("ice1724: invalid ptr %d (size=%d)\n", 843 dev_dbg(ice->card->dev, "invalid ptr %d (size=%d)\n",
844 (int)ptr, (int)substream->runtime->buffer_size); 844 (int)ptr, (int)substream->runtime->buffer_size);
845 ptr = 0; 845 ptr = 0;
846 } 846 }
@@ -884,7 +884,7 @@ static snd_pcm_uframes_t snd_vt1724_pcm_pointer(struct snd_pcm_substream *substr
884 else if (ptr <= substream->runtime->buffer_size) 884 else if (ptr <= substream->runtime->buffer_size)
885 ptr = substream->runtime->buffer_size - ptr; 885 ptr = substream->runtime->buffer_size - ptr;
886 else { 886 else {
887 snd_printd("ice1724: invalid ptr %d (size=%d)\n", 887 dev_dbg(ice->card->dev, "invalid ptr %d (size=%d)\n",
888 (int)ptr, (int)substream->runtime->buffer_size); 888 (int)ptr, (int)substream->runtime->buffer_size);
889 ptr = 0; 889 ptr = 0;
890 } 890 }
@@ -1508,7 +1508,8 @@ static int snd_vt1724_ac97_mixer(struct snd_ice1712 *ice)
1508 ac97.private_data = ice; 1508 ac97.private_data = ice;
1509 err = snd_ac97_mixer(pbus, &ac97, &ice->ac97); 1509 err = snd_ac97_mixer(pbus, &ac97, &ice->ac97);
1510 if (err < 0) 1510 if (err < 0)
1511 printk(KERN_WARNING "ice1712: cannot initialize pro ac97, skipped\n"); 1511 dev_warn(ice->card->dev,
1512 "cannot initialize pro ac97, skipped\n");
1512 else 1513 else
1513 return 0; 1514 return 0;
1514 } 1515 }
@@ -2271,7 +2272,7 @@ static void wait_i2c_busy(struct snd_ice1712 *ice)
2271 while ((inb(ICEREG1724(ice, I2C_CTRL)) & VT1724_I2C_BUSY) && t--) 2272 while ((inb(ICEREG1724(ice, I2C_CTRL)) & VT1724_I2C_BUSY) && t--)
2272 ; 2273 ;
2273 if (t == -1) 2274 if (t == -1)
2274 printk(KERN_ERR "ice1724: i2c busy timeout\n"); 2275 dev_err(ice->card->dev, "i2c busy timeout\n");
2275} 2276}
2276 2277
2277unsigned char snd_vt1724_read_i2c(struct snd_ice1712 *ice, 2278unsigned char snd_vt1724_read_i2c(struct snd_ice1712 *ice,
@@ -2287,7 +2288,7 @@ unsigned char snd_vt1724_read_i2c(struct snd_ice1712 *ice,
2287 val = inb(ICEREG1724(ice, I2C_DATA)); 2288 val = inb(ICEREG1724(ice, I2C_DATA));
2288 mutex_unlock(&ice->i2c_mutex); 2289 mutex_unlock(&ice->i2c_mutex);
2289 /* 2290 /*
2290 printk(KERN_DEBUG "i2c_read: [0x%x,0x%x] = 0x%x\n", dev, addr, val); 2291 dev_dbg(ice->card->dev, "i2c_read: [0x%x,0x%x] = 0x%x\n", dev, addr, val);
2291 */ 2292 */
2292 return val; 2293 return val;
2293} 2294}
@@ -2298,7 +2299,7 @@ void snd_vt1724_write_i2c(struct snd_ice1712 *ice,
2298 mutex_lock(&ice->i2c_mutex); 2299 mutex_lock(&ice->i2c_mutex);
2299 wait_i2c_busy(ice); 2300 wait_i2c_busy(ice);
2300 /* 2301 /*
2301 printk(KERN_DEBUG "i2c_write: [0x%x,0x%x] = 0x%x\n", dev, addr, data); 2302 dev_dbg(ice->card->dev, "i2c_write: [0x%x,0x%x] = 0x%x\n", dev, addr, data);
2302 */ 2303 */
2303 outb(addr, ICEREG1724(ice, I2C_BYTE_ADDR)); 2304 outb(addr, ICEREG1724(ice, I2C_BYTE_ADDR));
2304 outb(data, ICEREG1724(ice, I2C_DATA)); 2305 outb(data, ICEREG1724(ice, I2C_DATA));
@@ -2335,7 +2336,8 @@ static int snd_vt1724_read_eeprom(struct snd_ice1712 *ice,
2335 ((unsigned int)swab16(vendor) << 16) | swab16(device); 2336 ((unsigned int)swab16(vendor) << 16) | swab16(device);
2336 if (ice->eeprom.subvendor == 0 || 2337 if (ice->eeprom.subvendor == 0 ||
2337 ice->eeprom.subvendor == (unsigned int)-1) { 2338 ice->eeprom.subvendor == (unsigned int)-1) {
2338 printk(KERN_ERR "ice1724: No valid ID is found\n"); 2339 dev_err(ice->card->dev,
2340 "No valid ID is found\n");
2339 return -ENXIO; 2341 return -ENXIO;
2340 } 2342 }
2341 } 2343 }
@@ -2344,7 +2346,8 @@ static int snd_vt1724_read_eeprom(struct snd_ice1712 *ice,
2344 for (c = *tbl; c->name; c++) { 2346 for (c = *tbl; c->name; c++) {
2345 if (modelname && c->model && 2347 if (modelname && c->model &&
2346 !strcmp(modelname, c->model)) { 2348 !strcmp(modelname, c->model)) {
2347 printk(KERN_INFO "ice1724: Using board model %s\n", 2349 dev_info(ice->card->dev,
2350 "Using board model %s\n",
2348 c->name); 2351 c->name);
2349 ice->eeprom.subvendor = c->subvendor; 2352 ice->eeprom.subvendor = c->subvendor;
2350 } else if (c->subvendor != ice->eeprom.subvendor) 2353 } else if (c->subvendor != ice->eeprom.subvendor)
@@ -2353,14 +2356,14 @@ static int snd_vt1724_read_eeprom(struct snd_ice1712 *ice,
2353 if (!c->eeprom_size || !c->eeprom_data) 2356 if (!c->eeprom_size || !c->eeprom_data)
2354 goto found; 2357 goto found;
2355 /* if the EEPROM is given by the driver, use it */ 2358 /* if the EEPROM is given by the driver, use it */
2356 snd_printdd("using the defined eeprom..\n"); 2359 dev_dbg(ice->card->dev, "using the defined eeprom..\n");
2357 ice->eeprom.version = 2; 2360 ice->eeprom.version = 2;
2358 ice->eeprom.size = c->eeprom_size + 6; 2361 ice->eeprom.size = c->eeprom_size + 6;
2359 memcpy(ice->eeprom.data, c->eeprom_data, c->eeprom_size); 2362 memcpy(ice->eeprom.data, c->eeprom_data, c->eeprom_size);
2360 goto read_skipped; 2363 goto read_skipped;
2361 } 2364 }
2362 } 2365 }
2363 printk(KERN_WARNING "ice1724: No matching model found for ID 0x%x\n", 2366 dev_warn(ice->card->dev, "No matching model found for ID 0x%x\n",
2364 ice->eeprom.subvendor); 2367 ice->eeprom.subvendor);
2365#ifdef CONFIG_PM_SLEEP 2368#ifdef CONFIG_PM_SLEEP
2366 /* assume AC97-only card which can suspend without additional code */ 2369 /* assume AC97-only card which can suspend without additional code */
@@ -2372,13 +2375,13 @@ static int snd_vt1724_read_eeprom(struct snd_ice1712 *ice,
2372 if (ice->eeprom.size < 6) 2375 if (ice->eeprom.size < 6)
2373 ice->eeprom.size = 32; 2376 ice->eeprom.size = 32;
2374 else if (ice->eeprom.size > 32) { 2377 else if (ice->eeprom.size > 32) {
2375 printk(KERN_ERR "ice1724: Invalid EEPROM (size = %i)\n", 2378 dev_err(ice->card->dev, "Invalid EEPROM (size = %i)\n",
2376 ice->eeprom.size); 2379 ice->eeprom.size);
2377 return -EIO; 2380 return -EIO;
2378 } 2381 }
2379 ice->eeprom.version = snd_vt1724_read_i2c(ice, dev, 0x05); 2382 ice->eeprom.version = snd_vt1724_read_i2c(ice, dev, 0x05);
2380 if (ice->eeprom.version != 1 && ice->eeprom.version != 2) 2383 if (ice->eeprom.version != 1 && ice->eeprom.version != 2)
2381 printk(KERN_WARNING "ice1724: Invalid EEPROM version %i\n", 2384 dev_warn(ice->card->dev, "Invalid EEPROM version %i\n",
2382 ice->eeprom.version); 2385 ice->eeprom.version);
2383 size = ice->eeprom.size - 6; 2386 size = ice->eeprom.size - 6;
2384 for (i = 0; i < size; i++) 2387 for (i = 0; i < size; i++)
@@ -2586,7 +2589,7 @@ static int snd_vt1724_create(struct snd_card *card,
2586 2589
2587 if (request_irq(pci->irq, snd_vt1724_interrupt, 2590 if (request_irq(pci->irq, snd_vt1724_interrupt,
2588 IRQF_SHARED, KBUILD_MODNAME, ice)) { 2591 IRQF_SHARED, KBUILD_MODNAME, ice)) {
2589 snd_printk(KERN_ERR "unable to grab IRQ %d\n", pci->irq); 2592 dev_err(card->dev, "unable to grab IRQ %d\n", pci->irq);
2590 snd_vt1724_free(ice); 2593 snd_vt1724_free(ice);
2591 return -EIO; 2594 return -EIO;
2592 } 2595 }
diff --git a/sound/pci/ice1712/juli.c b/sound/pci/ice1712/juli.c
index 8855933e710d..7a6c0786c55c 100644
--- a/sound/pci/ice1712/juli.c
+++ b/sound/pci/ice1712/juli.c
@@ -244,7 +244,7 @@ static void juli_akm_set_rate_val(struct snd_akm4xxx *ak, unsigned int rate)
244 /* AK5385 first, since it requires cold reset affecting both codecs */ 244 /* AK5385 first, since it requires cold reset affecting both codecs */
245 old_gpio = ice->gpio.get_data(ice); 245 old_gpio = ice->gpio.get_data(ice);
246 new_gpio = (old_gpio & ~GPIO_AK5385A_MASK) | ak5385_pins; 246 new_gpio = (old_gpio & ~GPIO_AK5385A_MASK) | ak5385_pins;
247 /* printk(KERN_DEBUG "JULI - ak5385 set_rate_val: new gpio 0x%x\n", 247 /* dev_dbg(ice->card->dev, "JULI - ak5385 set_rate_val: new gpio 0x%x\n",
248 new_gpio); */ 248 new_gpio); */
249 ice->gpio.set_data(ice, new_gpio); 249 ice->gpio.set_data(ice, new_gpio);
250 250
@@ -344,7 +344,7 @@ static int juli_mute_put(struct snd_kcontrol *kcontrol,
344 new_gpio = old_gpio & 344 new_gpio = old_gpio &
345 ~((unsigned int) kcontrol->private_value); 345 ~((unsigned int) kcontrol->private_value);
346 } 346 }
347 /* printk(KERN_DEBUG 347 /* dev_dbg(ice->card->dev,
348 "JULI - mute/unmute: control_value: 0x%x, old_gpio: 0x%x, " 348 "JULI - mute/unmute: control_value: 0x%x, old_gpio: 0x%x, "
349 "new_gpio 0x%x\n", 349 "new_gpio 0x%x\n",
350 (unsigned int)ucontrol->value.integer.value[0], old_gpio, 350 (unsigned int)ucontrol->value.integer.value[0], old_gpio,
@@ -439,9 +439,9 @@ static void add_slaves(struct snd_card *card,
439{ 439{
440 for (; *list; list++) { 440 for (; *list; list++) {
441 struct snd_kcontrol *slave = ctl_find(card, *list); 441 struct snd_kcontrol *slave = ctl_find(card, *list);
442 /* printk(KERN_DEBUG "add_slaves - %s\n", *list); */ 442 /* dev_dbg(card->dev, "add_slaves - %s\n", *list); */
443 if (slave) { 443 if (slave) {
444 /* printk(KERN_DEBUG "slave %s found\n", *list); */ 444 /* dev_dbg(card->dev, "slave %s found\n", *list); */
445 snd_ctl_add_slave(master, slave); 445 snd_ctl_add_slave(master, slave);
446 } 446 }
447 } 447 }
@@ -536,7 +536,7 @@ static void juli_set_rate(struct snd_ice1712 *ice, unsigned int rate)
536 536
537 old = ice->gpio.get_data(ice); 537 old = ice->gpio.get_data(ice);
538 new = (old & ~GPIO_RATE_MASK) | get_gpio_val(rate); 538 new = (old & ~GPIO_RATE_MASK) | get_gpio_val(rate);
539 /* printk(KERN_DEBUG "JULI - set_rate: old %x, new %x\n", 539 /* dev_dbg(ice->card->dev, "JULI - set_rate: old %x, new %x\n",
540 old & GPIO_RATE_MASK, 540 old & GPIO_RATE_MASK,
541 new & GPIO_RATE_MASK); */ 541 new & GPIO_RATE_MASK); */
542 542
@@ -573,7 +573,7 @@ static void juli_ak4114_change(struct ak4114 *ak4114, unsigned char c0,
573 if (ice->is_spdif_master(ice) && c1) { 573 if (ice->is_spdif_master(ice) && c1) {
574 /* only for SPDIF master mode, rate was changed */ 574 /* only for SPDIF master mode, rate was changed */
575 rate = snd_ak4114_external_rate(ak4114); 575 rate = snd_ak4114_external_rate(ak4114);
576 /* printk(KERN_DEBUG "ak4114 - input rate changed to %d\n", 576 /* dev_dbg(ice->card->dev, "ak4114 - input rate changed to %d\n",
577 rate); */ 577 rate); */
578 juli_akm_set_rate_val(ice->akm, rate); 578 juli_akm_set_rate_val(ice->akm, rate);
579 } 579 }
@@ -628,7 +628,7 @@ static int juli_init(struct snd_ice1712 *ice)
628#endif 628#endif
629 629
630 if (spec->analog) { 630 if (spec->analog) {
631 printk(KERN_INFO "juli@: analog I/O detected\n"); 631 dev_info(ice->card->dev, "juli@: analog I/O detected\n");
632 ice->num_total_dacs = 2; 632 ice->num_total_dacs = 2;
633 ice->num_total_adcs = 2; 633 ice->num_total_adcs = 2;
634 634
diff --git a/sound/pci/ice1712/prodigy192.c b/sound/pci/ice1712/prodigy192.c
index e610339f7601..f3b491aa3e22 100644
--- a/sound/pci/ice1712/prodigy192.c
+++ b/sound/pci/ice1712/prodigy192.c
@@ -98,7 +98,7 @@ static int stac9460_dac_mute(struct snd_ice1712 *ice, int idx,
98 new = (~mute << 7 & 0x80) | (old & ~0x80); 98 new = (~mute << 7 & 0x80) | (old & ~0x80);
99 change = (new != old); 99 change = (new != old);
100 if (change) 100 if (change)
101 /*printk ("Volume register 0x%02x: 0x%02x\n", idx, new);*/ 101 /* dev_dbg(ice->card->dev, "Volume register 0x%02x: 0x%02x\n", idx, new);*/
102 stac9460_put(ice, idx, new); 102 stac9460_put(ice, idx, new);
103 return change; 103 return change;
104} 104}
@@ -133,7 +133,7 @@ static int stac9460_dac_mute_put(struct snd_kcontrol *kcontrol, struct snd_ctl_e
133 /* due to possible conflicts with stac9460_set_rate_val, mutexing */ 133 /* due to possible conflicts with stac9460_set_rate_val, mutexing */
134 mutex_lock(&spec->mute_mutex); 134 mutex_lock(&spec->mute_mutex);
135 /* 135 /*
136 printk(KERN_DEBUG "Mute put: reg 0x%02x, ctrl value: 0x%02x\n", idx, 136 dev_dbg(ice->card->dev, "Mute put: reg 0x%02x, ctrl value: 0x%02x\n", idx,
137 ucontrol->value.integer.value[0]); 137 ucontrol->value.integer.value[0]);
138 */ 138 */
139 change = stac9460_dac_mute(ice, idx, ucontrol->value.integer.value[0]); 139 change = stac9460_dac_mute(ice, idx, ucontrol->value.integer.value[0]);
@@ -187,7 +187,7 @@ static int stac9460_dac_vol_put(struct snd_kcontrol *kcontrol, struct snd_ctl_el
187 if (change) { 187 if (change) {
188 ovol = (0x7f - nvol) | (tmp & 0x80); 188 ovol = (0x7f - nvol) | (tmp & 0x80);
189 /* 189 /*
190 printk(KERN_DEBUG "DAC Volume: reg 0x%02x: 0x%02x\n", 190 dev_dbg(ice->card->dev, "DAC Volume: reg 0x%02x: 0x%02x\n",
191 idx, ovol); 191 idx, ovol);
192 */ 192 */
193 stac9460_put(ice, idx, (0x7f - nvol) | (tmp & 0x80)); 193 stac9460_put(ice, idx, (0x7f - nvol) | (tmp & 0x80));
@@ -348,7 +348,7 @@ static void stac9460_set_rate_val(struct snd_ice1712 *ice, unsigned int rate)
348 for (idx = 0; idx < 7 ; ++idx) 348 for (idx = 0; idx < 7 ; ++idx)
349 changed[idx] = stac9460_dac_mute(ice, 349 changed[idx] = stac9460_dac_mute(ice,
350 STAC946X_MASTER_VOLUME + idx, 0); 350 STAC946X_MASTER_VOLUME + idx, 0);
351 /*printk(KERN_DEBUG "Rate change: %d, new MC: 0x%02x\n", rate, new);*/ 351 /*dev_dbg(ice->card->dev, "Rate change: %d, new MC: 0x%02x\n", rate, new);*/
352 stac9460_put(ice, STAC946X_MASTER_CLOCKING, new); 352 stac9460_put(ice, STAC946X_MASTER_CLOCKING, new);
353 udelay(10); 353 udelay(10);
354 /* unmuting - only originally unmuted dacs - 354 /* unmuting - only originally unmuted dacs -
@@ -768,9 +768,10 @@ static int prodigy192_init(struct snd_ice1712 *ice)
768 /* from this moment if err = 0 then 768 /* from this moment if err = 0 then
769 * spec->ak4114 should not be null 769 * spec->ak4114 should not be null
770 */ 770 */
771 snd_printdd("AK4114 initialized with status %d\n", err); 771 dev_dbg(ice->card->dev,
772 "AK4114 initialized with status %d\n", err);
772 } else 773 } else
773 snd_printdd("AK4114 not found\n"); 774 dev_dbg(ice->card->dev, "AK4114 not found\n");
774 if (err < 0) 775 if (err < 0)
775 return err; 776 return err;
776 777
diff --git a/sound/pci/ice1712/quartet.c b/sound/pci/ice1712/quartet.c
index 71c6003ef338..2c2df4b74e01 100644
--- a/sound/pci/ice1712/quartet.c
+++ b/sound/pci/ice1712/quartet.c
@@ -280,7 +280,7 @@ static void qtet_akm_write(struct snd_akm4xxx *ak, int chip,
280 280
281 if (snd_BUG_ON(chip < 0 || chip >= 4)) 281 if (snd_BUG_ON(chip < 0 || chip >= 4))
282 return; 282 return;
283 /*printk(KERN_DEBUG "Writing to AK4620: chip=%d, addr=0x%x, 283 /*dev_dbg(ice->card->dev, "Writing to AK4620: chip=%d, addr=0x%x,
284 data=0x%x\n", chip, addr, data);*/ 284 data=0x%x\n", chip, addr, data);*/
285 orig_dir = ice->gpio.get_dir(ice); 285 orig_dir = ice->gpio.get_dir(ice);
286 ice->gpio.set_dir(ice, orig_dir | GPIO_SPI_ALL); 286 ice->gpio.set_dir(ice, orig_dir | GPIO_SPI_ALL);
@@ -898,7 +898,7 @@ static void qtet_set_rate(struct snd_ice1712 *ice, unsigned int rate)
898 new = (get_cpld(ice) & ~CPLD_CKS_MASK) | get_cks_val(rate); 898 new = (get_cpld(ice) & ~CPLD_CKS_MASK) | get_cks_val(rate);
899 /* switch to internal clock, drop CPLD_SYNC_SEL */ 899 /* switch to internal clock, drop CPLD_SYNC_SEL */
900 new &= ~CPLD_SYNC_SEL; 900 new &= ~CPLD_SYNC_SEL;
901 /* printk(KERN_DEBUG "QT - set_rate: old %x, new %x\n", 901 /* dev_dbg(ice->card->dev, "QT - set_rate: old %x, new %x\n",
902 get_cpld(ice), new); */ 902 get_cpld(ice), new); */
903 set_cpld(ice, new); 903 set_cpld(ice, new);
904} 904}
@@ -978,7 +978,7 @@ static void qtet_ak4113_change(struct ak4113 *ak4113, unsigned char c0,
978 c1) { 978 c1) {
979 /* only for SPDIF master mode, rate was changed */ 979 /* only for SPDIF master mode, rate was changed */
980 rate = snd_ak4113_external_rate(ak4113); 980 rate = snd_ak4113_external_rate(ak4113);
981 /* printk(KERN_DEBUG "ak4113 - input rate changed to %d\n", 981 /* dev_dbg(ice->card->dev, "ak4113 - input rate changed to %d\n",
982 rate); */ 982 rate); */
983 qtet_akm_set_rate_val(ice->akm, rate); 983 qtet_akm_set_rate_val(ice->akm, rate);
984 } 984 }