aboutsummaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>2014-07-31 02:52:26 -0400
committerMark Brown <broonie@linaro.org>2014-07-31 15:36:33 -0400
commit1cc7195929501b96fccce42646f1ad0ffe2598a6 (patch)
treec95106a51b948efff338dae5be397be05ad4e937 /sound
parent054cd7f4b986a941b56372b743602f7df6569c98 (diff)
ASoC: rsnd: care audio local bus data format consistency
R-Car sound uses Audio Local Bus which uses Lch/Rch format. This bus is used if driver uses BUSIF. But sound data is written as Rch/Lch format in register. This means Rch <-> Lch will be inverted. SSIU :: BUSIF_DALIGN is used to controlling data format. Reported-by: Jun Watanabe <jun.watanabe.ue@renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/sh/rcar/gen.c1
-rw-r--r--sound/soc/sh/rcar/rsnd.h2
-rw-r--r--sound/soc/sh/rcar/src.c19
3 files changed, 22 insertions, 0 deletions
diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c
index 5f9e0722abcf..5db055750991 100644
--- a/sound/soc/sh/rcar/gen.c
+++ b/sound/soc/sh/rcar/gen.c
@@ -284,6 +284,7 @@ static int rsnd_gen2_probe(struct platform_device *pdev,
284 /* FIXME: it needs SSI_MODE2/3 in the future */ 284 /* FIXME: it needs SSI_MODE2/3 in the future */
285 RSND_GEN_M_REG(SSI_BUSIF_MODE, 0x0, 0x80), 285 RSND_GEN_M_REG(SSI_BUSIF_MODE, 0x0, 0x80),
286 RSND_GEN_M_REG(SSI_BUSIF_ADINR, 0x4, 0x80), 286 RSND_GEN_M_REG(SSI_BUSIF_ADINR, 0x4, 0x80),
287 RSND_GEN_M_REG(BUSIF_DALIGN, 0x8, 0x80),
287 RSND_GEN_M_REG(SSI_CTRL, 0x10, 0x80), 288 RSND_GEN_M_REG(SSI_CTRL, 0x10, 0x80),
288 RSND_GEN_M_REG(INT_ENABLE, 0x18, 0x80), 289 RSND_GEN_M_REG(INT_ENABLE, 0x18, 0x80),
289 }; 290 };
diff --git a/sound/soc/sh/rcar/rsnd.h b/sound/soc/sh/rcar/rsnd.h
index 631b149df08f..d119adf97c9c 100644
--- a/sound/soc/sh/rcar/rsnd.h
+++ b/sound/soc/sh/rcar/rsnd.h
@@ -90,6 +90,7 @@ enum rsnd_reg {
90 RSND_REG_SHARE19, 90 RSND_REG_SHARE19,
91 RSND_REG_SHARE20, 91 RSND_REG_SHARE20,
92 RSND_REG_SHARE21, 92 RSND_REG_SHARE21,
93 RSND_REG_SHARE22,
93 94
94 RSND_REG_MAX, 95 RSND_REG_MAX,
95}; 96};
@@ -127,6 +128,7 @@ enum rsnd_reg {
127#define RSND_REG_AUDIO_CLK_SEL2 RSND_REG_SHARE19 128#define RSND_REG_AUDIO_CLK_SEL2 RSND_REG_SHARE19
128#define RSND_REG_CMD_CTRL RSND_REG_SHARE20 129#define RSND_REG_CMD_CTRL RSND_REG_SHARE20
129#define RSND_REG_CMDOUT_TIMSEL RSND_REG_SHARE21 130#define RSND_REG_CMDOUT_TIMSEL RSND_REG_SHARE21
131#define RSND_REG_BUSIF_DALIGN RSND_REG_SHARE22
130 132
131struct rsnd_of_data; 133struct rsnd_of_data;
132struct rsnd_priv; 134struct rsnd_priv;
diff --git a/sound/soc/sh/rcar/src.c b/sound/soc/sh/rcar/src.c
index 1ef811a26bd7..9183e0145503 100644
--- a/sound/soc/sh/rcar/src.c
+++ b/sound/soc/sh/rcar/src.c
@@ -110,6 +110,8 @@ int rsnd_src_ssiu_start(struct rsnd_mod *ssi_mod,
110 struct rsnd_dai *rdai, 110 struct rsnd_dai *rdai,
111 int use_busif) 111 int use_busif)
112{ 112{
113 struct rsnd_dai_stream *io = rsnd_mod_to_io(ssi_mod);
114 struct snd_pcm_runtime *runtime = rsnd_io_to_runtime(io);
113 int ssi_id = rsnd_mod_id(ssi_mod); 115 int ssi_id = rsnd_mod_id(ssi_mod);
114 116
115 /* 117 /*
@@ -146,10 +148,27 @@ int rsnd_src_ssiu_start(struct rsnd_mod *ssi_mod,
146 * DMA settings for SSIU 148 * DMA settings for SSIU
147 */ 149 */
148 if (use_busif) { 150 if (use_busif) {
151 u32 val = 0x76543210;
152 u32 mask = ~0;
153
149 rsnd_mod_write(ssi_mod, SSI_BUSIF_ADINR, 154 rsnd_mod_write(ssi_mod, SSI_BUSIF_ADINR,
150 rsnd_get_adinr(ssi_mod)); 155 rsnd_get_adinr(ssi_mod));
151 rsnd_mod_write(ssi_mod, SSI_BUSIF_MODE, 1); 156 rsnd_mod_write(ssi_mod, SSI_BUSIF_MODE, 1);
152 rsnd_mod_write(ssi_mod, SSI_CTRL, 0x1); 157 rsnd_mod_write(ssi_mod, SSI_CTRL, 0x1);
158
159 mask <<= runtime->channels * 4;
160 val = val & mask;
161
162 switch (runtime->sample_bits) {
163 case 16:
164 val |= 0x67452301 & ~mask;
165 break;
166 case 32:
167 val |= 0x76543210 & ~mask;
168 break;
169 }
170 rsnd_mod_write(ssi_mod, BUSIF_DALIGN, val);
171
153 } 172 }
154 173
155 return 0; 174 return 0;