diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-05-01 20:51:54 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-05-01 20:51:54 -0400 |
commit | 20b4fb485227404329e41ad15588afad3df23050 (patch) | |
tree | f3e099f0ab3da8a93b447203e294d2bb22f6dc05 /sound/sound_firmware.c | |
parent | b9394d8a657cd3c064fa432aa0905c1b58b38fe9 (diff) | |
parent | ac3e3c5b1164397656df81b9e9ab4991184d3236 (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull VFS updates from Al Viro,
Misc cleanups all over the place, mainly wrt /proc interfaces (switch
create_proc_entry to proc_create(), get rid of the deprecated
create_proc_read_entry() in favor of using proc_create_data() and
seq_file etc).
7kloc removed.
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (204 commits)
don't bother with deferred freeing of fdtables
proc: Move non-public stuff from linux/proc_fs.h to fs/proc/internal.h
proc: Make the PROC_I() and PDE() macros internal to procfs
proc: Supply a function to remove a proc entry by PDE
take cgroup_open() and cpuset_open() to fs/proc/base.c
ppc: Clean up scanlog
ppc: Clean up rtas_flash driver somewhat
hostap: proc: Use remove_proc_subtree()
drm: proc: Use remove_proc_subtree()
drm: proc: Use minor->index to label things, not PDE->name
drm: Constify drm_proc_list[]
zoran: Don't print proc_dir_entry data in debug
reiserfs: Don't access the proc_dir_entry in r_open(), r_start() r_show()
proc: Supply an accessor for getting the data from a PDE's parent
airo: Use remove_proc_subtree()
rtl8192u: Don't need to save device proc dir PDE
rtl8187se: Use a dir under /proc/net/r8180/
proc: Add proc_mkdir_data()
proc: Move some bits from linux/proc_fs.h to linux/{of.h,signal.h,tty.h}
proc: Move PDE_NET() to fs/proc/proc_net.c
...
Diffstat (limited to 'sound/sound_firmware.c')
-rw-r--r-- | sound/sound_firmware.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/sound/sound_firmware.c b/sound/sound_firmware.c index e14903468051..b155137ee312 100644 --- a/sound/sound_firmware.c +++ b/sound/sound_firmware.c | |||
@@ -1,6 +1,7 @@ | |||
1 | #include <linux/vmalloc.h> | 1 | #include <linux/vmalloc.h> |
2 | #include <linux/module.h> | 2 | #include <linux/module.h> |
3 | #include <linux/fs.h> | 3 | #include <linux/fs.h> |
4 | #include <linux/file.h> | ||
4 | #include <linux/mm.h> | 5 | #include <linux/mm.h> |
5 | #include <linux/sched.h> | 6 | #include <linux/sched.h> |
6 | #include <asm/uaccess.h> | 7 | #include <asm/uaccess.h> |
@@ -23,14 +24,14 @@ static int do_mod_firmware_load(const char *fn, char **fp) | |||
23 | if (l <= 0 || l > 131072) | 24 | if (l <= 0 || l > 131072) |
24 | { | 25 | { |
25 | printk(KERN_INFO "Invalid firmware '%s'\n", fn); | 26 | printk(KERN_INFO "Invalid firmware '%s'\n", fn); |
26 | filp_close(filp, NULL); | 27 | fput(filp); |
27 | return 0; | 28 | return 0; |
28 | } | 29 | } |
29 | dp = vmalloc(l); | 30 | dp = vmalloc(l); |
30 | if (dp == NULL) | 31 | if (dp == NULL) |
31 | { | 32 | { |
32 | printk(KERN_INFO "Out of memory loading '%s'.\n", fn); | 33 | printk(KERN_INFO "Out of memory loading '%s'.\n", fn); |
33 | filp_close(filp, NULL); | 34 | fput(filp); |
34 | return 0; | 35 | return 0; |
35 | } | 36 | } |
36 | pos = 0; | 37 | pos = 0; |
@@ -38,10 +39,10 @@ static int do_mod_firmware_load(const char *fn, char **fp) | |||
38 | { | 39 | { |
39 | printk(KERN_INFO "Failed to read '%s'.\n", fn); | 40 | printk(KERN_INFO "Failed to read '%s'.\n", fn); |
40 | vfree(dp); | 41 | vfree(dp); |
41 | filp_close(filp, NULL); | 42 | fput(filp); |
42 | return 0; | 43 | return 0; |
43 | } | 44 | } |
44 | filp_close(filp, NULL); | 45 | fput(filp); |
45 | *fp = dp; | 46 | *fp = dp; |
46 | return (int) l; | 47 | return (int) l; |
47 | } | 48 | } |