ASoC: wm_adsp: Fix memory leak in wm_adsp_setup_algs

Signed-off-by: JS Park <aitdark.park@samsung.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

1 files changed, 20 insertions, 10 deletions

diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index 0a08ef5e27c8..6a2a03570977 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -1053,8 +1053,10 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp)
                                   be32_to_cpu(adsp1_alg[i].zm));
 
                         region = kzalloc(sizeof(*region), GFP_KERNEL);
-                        if (!region)
-                                return -ENOMEM;
+                        if (!region) {
+                                ret = -ENOMEM;
+                                goto out;
+                        }
                         region->type = WMFW_ADSP1_DM;
                         region->alg = be32_to_cpu(adsp1_alg[i].alg.id);
                         region->base = be32_to_cpu(adsp1_alg[i].dm);
@@ -1071,8 +1073,10 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp)
                         }
 
                         region = kzalloc(sizeof(*region), GFP_KERNEL);
-                        if (!region)
-                                return -ENOMEM;
+                        if (!region) {
+                                ret = -ENOMEM;
+                                goto out;
+                        }
                         region->type = WMFW_ADSP1_ZM;
                         region->alg = be32_to_cpu(adsp1_alg[i].alg.id);
                         region->base = be32_to_cpu(adsp1_alg[i].zm);
@@ -1101,8 +1105,10 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp)
                                   be32_to_cpu(adsp2_alg[i].zm));
 
                         region = kzalloc(sizeof(*region), GFP_KERNEL);
-                        if (!region)
-                                return -ENOMEM;
+                        if (!region) {
+                                ret = -ENOMEM;
+                                goto out;
+                        }
                         region->type = WMFW_ADSP2_XM;
                         region->alg = be32_to_cpu(adsp2_alg[i].alg.id);
                         region->base = be32_to_cpu(adsp2_alg[i].xm);
@@ -1119,8 +1125,10 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp)
                         }
 
                         region = kzalloc(sizeof(*region), GFP_KERNEL);
-                        if (!region)
-                                return -ENOMEM;
+                        if (!region) {
+                                ret = -ENOMEM;
+                                goto out;
+                        }
                         region->type = WMFW_ADSP2_YM;
                         region->alg = be32_to_cpu(adsp2_alg[i].alg.id);
                         region->base = be32_to_cpu(adsp2_alg[i].ym);
@@ -1137,8 +1145,10 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp)
                         }
 
                         region = kzalloc(sizeof(*region), GFP_KERNEL);
-                        if (!region)
-                                return -ENOMEM;
+                        if (!region) {
+                                ret = -ENOMEM;
+                                goto out;
+                        }
                         region->type = WMFW_ADSP2_ZM;
                         region->alg = be32_to_cpu(adsp2_alg[i].alg.id);
                         region->base = be32_to_cpu(adsp2_alg[i].zm);