aboutsummaryrefslogtreecommitdiffstats
path: root/sound/pci/maestro3.c
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2014-02-25 08:43:41 -0500
committerTakashi Iwai <tiwai@suse.de>2014-02-26 10:45:19 -0500
commit747ce5b36c2920a46cc22813f5ce1b9ba324f80d (patch)
tree9da6fd4e10f5b996e69c79f41a73bbb4e5c5a4fe /sound/pci/maestro3.c
parent813bdba37560e13448b09514feadcf063f914b97 (diff)
ALSA: maestro3: Use standard printk helpers
Convert with dev_err() and co from snd_printk(), etc. Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/maestro3.c')
-rw-r--r--sound/pci/maestro3.c37
1 files changed, 19 insertions, 18 deletions
diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c
index 076c3ec000c0..0d3ea3e79952 100644
--- a/sound/pci/maestro3.c
+++ b/sound/pci/maestro3.c
@@ -1403,7 +1403,7 @@ static int snd_m3_pcm_hw_params(struct snd_pcm_substream *substream,
1403 /* set buffer address */ 1403 /* set buffer address */
1404 s->buffer_addr = substream->runtime->dma_addr; 1404 s->buffer_addr = substream->runtime->dma_addr;
1405 if (s->buffer_addr & 0x3) { 1405 if (s->buffer_addr & 0x3) {
1406 snd_printk(KERN_ERR "oh my, not aligned\n"); 1406 dev_err(substream->pcm->card->dev, "oh my, not aligned\n");
1407 s->buffer_addr = s->buffer_addr & ~0x3; 1407 s->buffer_addr = s->buffer_addr & ~0x3;
1408 } 1408 }
1409 return 0; 1409 return 0;
@@ -1900,7 +1900,7 @@ static int snd_m3_ac97_wait(struct snd_m3 *chip)
1900 cpu_relax(); 1900 cpu_relax();
1901 } while (i-- > 0); 1901 } while (i-- > 0);
1902 1902
1903 snd_printk(KERN_ERR "ac97 serial bus busy\n"); 1903 dev_err(chip->card->dev, "ac97 serial bus busy\n");
1904 return 1; 1904 return 1;
1905} 1905}
1906 1906
@@ -2015,7 +2015,8 @@ static void snd_m3_ac97_reset(struct snd_m3 *chip)
2015 delay1 += 10; 2015 delay1 += 10;
2016 delay2 += 100; 2016 delay2 += 100;
2017 2017
2018 snd_printd("maestro3: retrying codec reset with delays of %d and %d ms\n", 2018 dev_dbg(chip->card->dev,
2019 "retrying codec reset with delays of %d and %d ms\n",
2019 delay1, delay2); 2020 delay1, delay2);
2020 } 2021 }
2021 2022
@@ -2194,7 +2195,8 @@ static int snd_m3_assp_client_init(struct snd_m3 *chip, struct m3_dma *s, int in
2194 address = 0x1100 + ((data_bytes/2) * index); 2195 address = 0x1100 + ((data_bytes/2) * index);
2195 2196
2196 if ((address + (data_bytes/2)) >= 0x1c00) { 2197 if ((address + (data_bytes/2)) >= 0x1c00) {
2197 snd_printk(KERN_ERR "no memory for %d bytes at ind %d (addr 0x%x)\n", 2198 dev_err(chip->card->dev,
2199 "no memory for %d bytes at ind %d (addr 0x%x)\n",
2198 data_bytes, index, address); 2200 data_bytes, index, address);
2199 return -ENOMEM; 2201 return -ENOMEM;
2200 } 2202 }
@@ -2439,8 +2441,7 @@ static int m3_resume(struct device *dev)
2439 pci_set_power_state(pci, PCI_D0); 2441 pci_set_power_state(pci, PCI_D0);
2440 pci_restore_state(pci); 2442 pci_restore_state(pci);
2441 if (pci_enable_device(pci) < 0) { 2443 if (pci_enable_device(pci) < 0) {
2442 printk(KERN_ERR "maestor3: pci_enable_device failed, " 2444 dev_err(dev, "pci_enable_device failed, disabling device\n");
2443 "disabling device\n");
2444 snd_card_disconnect(card); 2445 snd_card_disconnect(card);
2445 return -EIO; 2446 return -EIO;
2446 } 2447 }
@@ -2553,7 +2554,8 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci,
2553 /* check, if we can restrict PCI DMA transfers to 28 bits */ 2554 /* check, if we can restrict PCI DMA transfers to 28 bits */
2554 if (pci_set_dma_mask(pci, DMA_BIT_MASK(28)) < 0 || 2555 if (pci_set_dma_mask(pci, DMA_BIT_MASK(28)) < 0 ||
2555 pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(28)) < 0) { 2556 pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(28)) < 0) {
2556 snd_printk(KERN_ERR "architecture does not support 28bit PCI busmaster DMA\n"); 2557 dev_err(card->dev,
2558 "architecture does not support 28bit PCI busmaster DMA\n");
2557 pci_disable_device(pci); 2559 pci_disable_device(pci);
2558 return -ENXIO; 2560 return -ENXIO;
2559 } 2561 }
@@ -2586,9 +2588,8 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci,
2586 else { 2588 else {
2587 quirk = snd_pci_quirk_lookup(pci, m3_amp_quirk_list); 2589 quirk = snd_pci_quirk_lookup(pci, m3_amp_quirk_list);
2588 if (quirk) { 2590 if (quirk) {
2589 snd_printdd(KERN_INFO 2591 dev_info(card->dev, "set amp-gpio for '%s'\n",
2590 "maestro3: set amp-gpio for '%s'\n", 2592 snd_pci_quirk_name(quirk));
2591 snd_pci_quirk_name(quirk));
2592 chip->amp_gpio = quirk->value; 2593 chip->amp_gpio = quirk->value;
2593 } else if (chip->allegro_flag) 2594 } else if (chip->allegro_flag)
2594 chip->amp_gpio = GPO_EXT_AMP_ALLEGRO; 2595 chip->amp_gpio = GPO_EXT_AMP_ALLEGRO;
@@ -2598,9 +2599,8 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci,
2598 2599
2599 quirk = snd_pci_quirk_lookup(pci, m3_irda_quirk_list); 2600 quirk = snd_pci_quirk_lookup(pci, m3_irda_quirk_list);
2600 if (quirk) { 2601 if (quirk) {
2601 snd_printdd(KERN_INFO 2602 dev_info(card->dev, "enabled irda workaround for '%s'\n",
2602 "maestro3: enabled irda workaround for '%s'\n", 2603 snd_pci_quirk_name(quirk));
2603 snd_pci_quirk_name(quirk));
2604 chip->irda_workaround = 1; 2604 chip->irda_workaround = 1;
2605 } 2605 }
2606 quirk = snd_pci_quirk_lookup(pci, m3_hv_quirk_list); 2606 quirk = snd_pci_quirk_lookup(pci, m3_hv_quirk_list);
@@ -2652,7 +2652,7 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci,
2652 2652
2653 if (request_irq(pci->irq, snd_m3_interrupt, IRQF_SHARED, 2653 if (request_irq(pci->irq, snd_m3_interrupt, IRQF_SHARED,
2654 KBUILD_MODNAME, chip)) { 2654 KBUILD_MODNAME, chip)) {
2655 snd_printk(KERN_ERR "unable to grab IRQ %d\n", pci->irq); 2655 dev_err(card->dev, "unable to grab IRQ %d\n", pci->irq);
2656 snd_m3_free(chip); 2656 snd_m3_free(chip);
2657 return -ENOMEM; 2657 return -ENOMEM;
2658 } 2658 }
@@ -2661,7 +2661,7 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci,
2661#ifdef CONFIG_PM_SLEEP 2661#ifdef CONFIG_PM_SLEEP
2662 chip->suspend_mem = vmalloc(sizeof(u16) * (REV_B_CODE_MEMORY_LENGTH + REV_B_DATA_MEMORY_LENGTH)); 2662 chip->suspend_mem = vmalloc(sizeof(u16) * (REV_B_CODE_MEMORY_LENGTH + REV_B_DATA_MEMORY_LENGTH));
2663 if (chip->suspend_mem == NULL) 2663 if (chip->suspend_mem == NULL)
2664 snd_printk(KERN_WARNING "can't allocate apm buffer\n"); 2664 dev_warn(card->dev, "can't allocate apm buffer\n");
2665#endif 2665#endif
2666 2666
2667 if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops)) < 0) { 2667 if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops)) < 0) {
@@ -2685,8 +2685,9 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci,
2685 if (chip->hv_config & HV_CTRL_ENABLE) { 2685 if (chip->hv_config & HV_CTRL_ENABLE) {
2686 err = snd_m3_input_register(chip); 2686 err = snd_m3_input_register(chip);
2687 if (err) 2687 if (err)
2688 snd_printk(KERN_WARNING "Input device registration " 2688 dev_warn(card->dev,
2689 "failed with error %i", err); 2689 "Input device registration failed with error %i",
2690 err);
2690 } 2691 }
2691#endif 2692#endif
2692 2693
@@ -2763,7 +2764,7 @@ snd_m3_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
2763 MPU401_INFO_INTEGRATED | MPU401_INFO_IRQ_HOOK, 2764 MPU401_INFO_INTEGRATED | MPU401_INFO_IRQ_HOOK,
2764 -1, &chip->rmidi); 2765 -1, &chip->rmidi);
2765 if (err < 0) 2766 if (err < 0)
2766 printk(KERN_WARNING "maestro3: no MIDI support.\n"); 2767 dev_warn(card->dev, "no MIDI support.\n");
2767#endif 2768#endif
2768 2769
2769 pci_set_drvdata(pci, card); 2770 pci_set_drvdata(pci, card);