ALSA: hda - Release assigned pin/cvt at error path of hdmi_pcm_open()

If the driver detects and invalid ELD, it gives an open error.
But it forgot to release the assigned pin, converter and spdif ctls
before returning.

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

1 files changed, 5 insertions, 1 deletions

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 807a2aa1ff38..1b3b4ee3e8a7 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1100,8 +1100,12 @@ static int hdmi_pcm_open(struct hda_pcm_stream *hinfo,
         if (!static_hdmi_pcm && eld->eld_valid) {
                 snd_hdmi_eld_update_pcm_info(eld, hinfo);
                 if (hinfo->channels_min > hinfo->channels_max ||
-                    !hinfo->rates || !hinfo->formats)
+                    !hinfo->rates || !hinfo->formats) {
+                        per_cvt->assigned = 0;
+                        hinfo->nid = 0;
+                        snd_hda_spdif_ctls_unassign(codec, pin_idx);
                         return -ENODEV;
+                }
         }
 
         /* Store the updated parameters */