Merge branch 'fix/hda' into topic/hda

1 files changed, 27 insertions, 19 deletions

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 197ad936c84d..aa0e4b95c26c 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -3329,18 +3329,26 @@ static int fill_cx_auto_dacs(struct hda_codec *codec, hda_nid_t *dacs)
 /* fill pin_dac_pair list from the pin and dac list */
 static int fill_dacs_for_pins(struct hda_codec *codec, hda_nid_t *pins,
                               int num_pins, hda_nid_t *dacs, int *rest,
-                              struct pin_dac_pair *filled, int type)
+                              struct pin_dac_pair *filled, int nums, 
+                              int type)
 {
-        int i, nums;
+        int i, start = nums;
 
-        nums = 0;
-        for (i = 0; i < num_pins; i++) {
+        for (i = 0; i < num_pins; i++, nums++) {
                 filled[nums].pin = pins[i];
                 filled[nums].type = type;
                 filled[nums].dac = get_unassigned_dac(codec, pins[i], dacs, rest);
-                if (!filled[nums].dac && i > 0 && filled[0].dac)
+                if (filled[nums].dac) 
+                        continue;
+                if (filled[start].dac && get_connection_index(codec, pins[i], filled[start].dac) >= 0) {
+                        filled[nums].dac = filled[start].dac | DAC_SLAVE_FLAG;
+                        continue;
+                }
+                if (filled[0].dac && get_connection_index(codec, pins[i], filled[0].dac) >= 0) {
                         filled[nums].dac = filled[0].dac | DAC_SLAVE_FLAG;
-                nums++;
+                        continue;
+                }
+                snd_printdd("Failed to find a DAC for pin 0x%x", pins[i]);
         }
         return nums;
 }
@@ -3356,14 +3364,14 @@ static void cx_auto_parse_output(struct hda_codec *codec)
         rest = fill_cx_auto_dacs(codec, dacs);
         /* parse all analog output pins */
         nums = fill_dacs_for_pins(codec, cfg->line_out_pins, cfg->line_outs,
-                                  dacs, &rest, spec->dac_info,
-                                  AUTO_PIN_LINE_OUT);
-        nums += fill_dacs_for_pins(codec, cfg->hp_pins, cfg->hp_outs,
-                                  dacs, &rest, spec->dac_info + nums,
-                                  AUTO_PIN_HP_OUT);
-        nums += fill_dacs_for_pins(codec, cfg->speaker_pins, cfg->speaker_outs,
-                                  dacs, &rest, spec->dac_info + nums,
-                                  AUTO_PIN_SPEAKER_OUT);
+                          dacs, &rest, spec->dac_info, 0,
+                          AUTO_PIN_LINE_OUT);
+        nums = fill_dacs_for_pins(codec, cfg->hp_pins, cfg->hp_outs,
+                          dacs, &rest, spec->dac_info, nums,
+                          AUTO_PIN_HP_OUT);
+        nums = fill_dacs_for_pins(codec, cfg->speaker_pins, cfg->speaker_outs,
+                          dacs, &rest, spec->dac_info, nums,
+                          AUTO_PIN_SPEAKER_OUT);
         spec->dac_info_filled = nums;
         /* fill multiout struct */
         for (i = 0; i < nums; i++) {
@@ -4130,9 +4138,11 @@ static int try_add_pb_volume(struct hda_codec *codec, hda_nid_t dac,
                              hda_nid_t pin, const char *name, int idx)
 {
         unsigned int caps;
-        caps = query_amp_caps(codec, dac, HDA_OUTPUT);
-        if (caps & AC_AMPCAP_NUM_STEPS)
-                return cx_auto_add_pb_volume(codec, dac, name, idx);
+        if (dac && !(dac & DAC_SLAVE_FLAG)) {
+                caps = query_amp_caps(codec, dac, HDA_OUTPUT);
+                if (caps & AC_AMPCAP_NUM_STEPS)
+                        return cx_auto_add_pb_volume(codec, dac, name, idx);
+        }
         caps = query_amp_caps(codec, pin, HDA_OUTPUT);
         if (caps & AC_AMPCAP_NUM_STEPS)
                 return cx_auto_add_pb_volume(codec, pin, name, idx);
@@ -4155,8 +4165,6 @@ static int cx_auto_build_output_controls(struct hda_codec *codec)
                 const char *label;
                 int idx, type;
                 hda_nid_t dac = spec->dac_info[i].dac;
-                if (!dac || (dac & DAC_SLAVE_FLAG))
-                        continue;
                 type = spec->dac_info[i].type;
                 if (type == AUTO_PIN_LINE_OUT)
                         type = spec->autocfg.line_out_type;