diff options
author | Takashi Iwai <tiwai@suse.de> | 2013-05-29 06:37:32 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2013-05-29 06:37:32 -0400 |
commit | 20a24225d8f94fc56f74a9068684869d6deebea5 (patch) | |
tree | c7c78bc07df52098a3262942457a02a725cfd15b /sound/pci/ali5451 | |
parent | 4059a42c51f45566a7eb69f0c7af3ff65bee7a52 (diff) |
ALSA: PCI: Remove superfluous pci_set_drvdata(pci, NULL) at remove
As drvdata is cleared to NULL at probe failure or at removal by the
driver core, we don't have to call pci_set_drvdata(pci, NULL) any
longer in each driver.
The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in
hda_intel.c. Since this function itself releases the card instance,
we need to clear drvdata here as well, so that it won't be released
doubly in the remove callback.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/ali5451')
-rw-r--r-- | sound/pci/ali5451/ali5451.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c index 53754f5edeb1..3dfa12b670eb 100644 --- a/sound/pci/ali5451/ali5451.c +++ b/sound/pci/ali5451/ali5451.c | |||
@@ -2298,7 +2298,6 @@ static int snd_ali_probe(struct pci_dev *pci, | |||
2298 | static void snd_ali_remove(struct pci_dev *pci) | 2298 | static void snd_ali_remove(struct pci_dev *pci) |
2299 | { | 2299 | { |
2300 | snd_card_free(pci_get_drvdata(pci)); | 2300 | snd_card_free(pci_get_drvdata(pci)); |
2301 | pci_set_drvdata(pci, NULL); | ||
2302 | } | 2301 | } |
2303 | 2302 | ||
2304 | static struct pci_driver ali5451_driver = { | 2303 | static struct pci_driver ali5451_driver = { |