diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2014-05-19 00:31:10 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2014-05-19 04:08:43 -0400 |
commit | 47c9807425762a08ca93a2ac876eced8d290c94e (patch) | |
tree | f2f43a7dda3311efff57026a46c79b090ede858b /sound/oss | |
parent | d576422eda7fc999bf7c9862fa0a75bf0323417f (diff) |
sound: mpu401.c: make return of 0 explicit
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@
-ret = 0;
... when != ret = e
return
- ret
+ 0
;
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/oss')
-rw-r--r-- | sound/oss/mpu401.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c index 25e4609f8339..3bbc3ec5be82 100644 --- a/sound/oss/mpu401.c +++ b/sound/oss/mpu401.c | |||
@@ -567,7 +567,6 @@ static int mpu401_out(int dev, unsigned char midi_byte) | |||
567 | static int mpu401_command(int dev, mpu_command_rec * cmd) | 567 | static int mpu401_command(int dev, mpu_command_rec * cmd) |
568 | { | 568 | { |
569 | int i, timeout, ok; | 569 | int i, timeout, ok; |
570 | int ret = 0; | ||
571 | unsigned long flags; | 570 | unsigned long flags; |
572 | struct mpu_config *devc; | 571 | struct mpu_config *devc; |
573 | 572 | ||
@@ -644,7 +643,6 @@ retry: | |||
644 | } | 643 | } |
645 | } | 644 | } |
646 | } | 645 | } |
647 | ret = 0; | ||
648 | cmd->data[0] = 0; | 646 | cmd->data[0] = 0; |
649 | 647 | ||
650 | if (cmd->nr_returns) | 648 | if (cmd->nr_returns) |
@@ -666,7 +664,7 @@ retry: | |||
666 | } | 664 | } |
667 | } | 665 | } |
668 | spin_unlock_irqrestore(&devc->lock,flags); | 666 | spin_unlock_irqrestore(&devc->lock,flags); |
669 | return ret; | 667 | return 0; |
670 | } | 668 | } |
671 | 669 | ||
672 | static int mpu_cmd(int dev, int cmd, int data) | 670 | static int mpu_cmd(int dev, int cmd, int data) |