aboutsummaryrefslogtreecommitdiffstats
path: root/sound/oss/sequencer.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2015-04-24 13:31:32 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2015-04-24 13:31:32 -0400
commitd19d133e432248c9b3efa9c10dda5f050cbbcd72 (patch)
tree740eaf643e4a44df7b09b853578d7f63711874de /sound/oss/sequencer.c
parentc6668726d2c2c581e6c417448c472c994d026f5f (diff)
parente8191a8e475551b277d85cd76c3f0f52fdf42e86 (diff)
Merge tag 'sound-fix-4.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
Pull sound fixes from Takashi Iwai: "Here are a few fixes that have been pending since the previous pull request: a regression fix for HD-audio multiple SPDIF / HDMI devices, several ALC256 codec fixes, a couple of i915 HDMI audio fixes, and various small fixes. Nothing exciting, just boring, but things good to have" * tag 'sound-fix-4.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: ALSA: hda - fix headset mic detection problem for one more machine ALSA: hda/realtek - Fix Headphone Mic doesn't recording for ALC256 ALSA: hda - fix "num_steps = 0" error on ALC256 ALSA: usb-audio: Fix audio output on Roland SC-D70 sound module ALSA: hda - add AZX_DCAPS_I915_POWERWELL to Baytrail ALSA: hda - only sync BCLK to the display clock for Haswell & Broadwell ALSA: hda - Mute headphone pin on suspend on XPS13 9333 sound/oss: fix deadlock in sequencer_ioctl(SNDCTL_SEQ_OUTOFBAND) ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN ALSA: hda - potential (but unlikely) uninitialized variable ALSA: hda - Fix regression for slave SPDIF setups ALSA: intel8x0: Check pci_iomap() success for DEVICE_ALI ALSA: hda - simplify azx_has_pm_runtime
Diffstat (limited to 'sound/oss/sequencer.c')
-rw-r--r--sound/oss/sequencer.c12
1 files changed, 2 insertions, 10 deletions
diff --git a/sound/oss/sequencer.c b/sound/oss/sequencer.c
index c0eea1dfe90f..f19da4b47c1d 100644
--- a/sound/oss/sequencer.c
+++ b/sound/oss/sequencer.c
@@ -681,13 +681,8 @@ static int seq_timing_event(unsigned char *event_rec)
681 break; 681 break;
682 682
683 case TMR_ECHO: 683 case TMR_ECHO:
684 if (seq_mode == SEQ_2) 684 parm = (parm << 8 | SEQ_ECHO);
685 seq_copy_to_input(event_rec, 8); 685 seq_copy_to_input((unsigned char *) &parm, 4);
686 else
687 {
688 parm = (parm << 8 | SEQ_ECHO);
689 seq_copy_to_input((unsigned char *) &parm, 4);
690 }
691 break; 686 break;
692 687
693 default:; 688 default:;
@@ -1324,7 +1319,6 @@ int sequencer_ioctl(int dev, struct file *file, unsigned int cmd, void __user *a
1324 int mode = translate_mode(file); 1319 int mode = translate_mode(file);
1325 struct synth_info inf; 1320 struct synth_info inf;
1326 struct seq_event_rec event_rec; 1321 struct seq_event_rec event_rec;
1327 unsigned long flags;
1328 int __user *p = arg; 1322 int __user *p = arg;
1329 1323
1330 orig_dev = dev = dev >> 4; 1324 orig_dev = dev = dev >> 4;
@@ -1479,9 +1473,7 @@ int sequencer_ioctl(int dev, struct file *file, unsigned int cmd, void __user *a
1479 case SNDCTL_SEQ_OUTOFBAND: 1473 case SNDCTL_SEQ_OUTOFBAND:
1480 if (copy_from_user(&event_rec, arg, sizeof(event_rec))) 1474 if (copy_from_user(&event_rec, arg, sizeof(event_rec)))
1481 return -EFAULT; 1475 return -EFAULT;
1482 spin_lock_irqsave(&lock,flags);
1483 play_event(event_rec.arr); 1476 play_event(event_rec.arr);
1484 spin_unlock_irqrestore(&lock,flags);
1485 return 0; 1477 return 0;
1486 1478
1487 case SNDCTL_MIDI_INFO: 1479 case SNDCTL_MIDI_INFO: