diff options
author | Takashi Iwai <tiwai@suse.de> | 2013-11-12 02:06:20 -0500 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2013-11-12 02:06:20 -0500 |
commit | 092f9cd16aac7d054af1755c945f37c1b33399e6 (patch) | |
tree | 6789c6cfac6bb082917f4205bbff967da884a458 /sound/isa | |
parent | c15b149a301ca214ef7ee92e2527b655ad007bb1 (diff) |
ALSA: msnd: Avoid duplicated driver name
msnd_pinnacle.c is used for both snd-msnd-pinnacle and
snd-msnd-classic drivers, and both should have different driver
names. Using the same driver name results in the sysfs warning for
duplicated entries like
kobject: 'msnd-pinnacle.7' (cec33408): kobject_release, parent (null) (delayed)
kobject: 'msnd-pinnacle' (cecd4980): kobject_release, parent cf3ad9b0 (delayed)
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at fs/sysfs/dir.c:486 sysfs_warn_dup+0x7d/0xa0()
sysfs: cannot create duplicate filename '/bus/isa/drivers/msnd-pinnacle'
......
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/isa')
-rw-r--r-- | sound/isa/msnd/msnd_pinnacle.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/isa/msnd/msnd_pinnacle.c b/sound/isa/msnd/msnd_pinnacle.c index 81aeb934261a..0a90bd6ae232 100644 --- a/sound/isa/msnd/msnd_pinnacle.c +++ b/sound/isa/msnd/msnd_pinnacle.c | |||
@@ -73,9 +73,11 @@ | |||
73 | #ifdef MSND_CLASSIC | 73 | #ifdef MSND_CLASSIC |
74 | # include "msnd_classic.h" | 74 | # include "msnd_classic.h" |
75 | # define LOGNAME "msnd_classic" | 75 | # define LOGNAME "msnd_classic" |
76 | # define DEV_NAME "msnd-classic" | ||
76 | #else | 77 | #else |
77 | # include "msnd_pinnacle.h" | 78 | # include "msnd_pinnacle.h" |
78 | # define LOGNAME "snd_msnd_pinnacle" | 79 | # define LOGNAME "snd_msnd_pinnacle" |
80 | # define DEV_NAME "msnd-pinnacle" | ||
79 | #endif | 81 | #endif |
80 | 82 | ||
81 | static void set_default_audio_parameters(struct snd_msnd *chip) | 83 | static void set_default_audio_parameters(struct snd_msnd *chip) |
@@ -1067,8 +1069,6 @@ static int snd_msnd_isa_remove(struct device *pdev, unsigned int dev) | |||
1067 | return 0; | 1069 | return 0; |
1068 | } | 1070 | } |
1069 | 1071 | ||
1070 | #define DEV_NAME "msnd-pinnacle" | ||
1071 | |||
1072 | static struct isa_driver snd_msnd_driver = { | 1072 | static struct isa_driver snd_msnd_driver = { |
1073 | .match = snd_msnd_isa_match, | 1073 | .match = snd_msnd_isa_match, |
1074 | .probe = snd_msnd_isa_probe, | 1074 | .probe = snd_msnd_isa_probe, |