Merge branch 'for-linus' into for-next

Back-merged for refactoring beep stuff.

3 files changed, 20 insertions, 7 deletions

diff --git a/sound/core/seq/oss/seq_oss_event.c b/sound/core/seq/oss/seq_oss_event.c
index 066f5f3e3f4c..c3908862bc8b 100644
--- a/sound/core/seq/oss/seq_oss_event.c
+++ b/sound/core/seq/oss/seq_oss_event.c
@@ -285,7 +285,12 @@ local_event(struct seq_oss_devinfo *dp, union evrec *q, struct snd_seq_event *ev
 static int
 note_on_event(struct seq_oss_devinfo *dp, int dev, int ch, int note, int vel, struct snd_seq_event *ev)
 {
-        struct seq_oss_synthinfo *info = &dp->synths[dev];
+        struct seq_oss_synthinfo *info;
+
+        if (!snd_seq_oss_synth_is_valid(dp, dev))
+                return -ENXIO;
+
+        info = &dp->synths[dev];
         switch (info->arg.event_passing) {
         case SNDRV_SEQ_OSS_PROCESS_EVENTS:
                 if (! info->ch || ch < 0 || ch >= info->nr_voices) {
@@ -340,7 +345,12 @@ note_on_event(struct seq_oss_devinfo *dp, int dev, int ch, int note, int vel, st
 static int
 note_off_event(struct seq_oss_devinfo *dp, int dev, int ch, int note, int vel, struct snd_seq_event *ev)
 {
-        struct seq_oss_synthinfo *info = &dp->synths[dev];
+        struct seq_oss_synthinfo *info;
+
+        if (!snd_seq_oss_synth_is_valid(dp, dev))
+                return -ENXIO;
+
+        info = &dp->synths[dev];
         switch (info->arg.event_passing) {
         case SNDRV_SEQ_OSS_PROCESS_EVENTS:
                 if (! info->ch || ch < 0 || ch >= info->nr_voices) {
diff --git a/sound/core/seq/seq_timer.c b/sound/core/seq/seq_timer.c
index 160b1bd0cd62..24d44b2f61ac 100644
--- a/sound/core/seq/seq_timer.c
+++ b/sound/core/seq/seq_timer.c
@@ -290,10 +290,10 @@ int snd_seq_timer_open(struct snd_seq_queue *q)
                         tid.device = SNDRV_TIMER_GLOBAL_SYSTEM;
                         err = snd_timer_open(&t, str, &tid, q->queue);
                 }
-                if (err < 0) {
-                        snd_printk(KERN_ERR "seq fatal error: cannot create timer (%i)\n", err);
-                        return err;
-                }
+        }
+        if (err < 0) {
+                snd_printk(KERN_ERR "seq fatal error: cannot create timer (%i)\n", err);
+                return err;
         }
         t->callback = snd_seq_timer_interrupt;
         t->callback_data = q;
diff --git a/sound/core/vmaster.c b/sound/core/vmaster.c
index 55c9d8c8d3c1..02f90b4f8b86 100644
--- a/sound/core/vmaster.c
+++ b/sound/core/vmaster.c
@@ -213,7 +213,10 @@ static int slave_put(struct snd_kcontrol *kcontrol,
         }
         if (!changed)
                 return 0;
-        return slave_put_val(slave, ucontrol);
+        err = slave_put_val(slave, ucontrol);
+        if (err < 0)
+                return err;
+        return 1;
 }
 
 static int slave_tlv_cmd(struct snd_kcontrol *kcontrol,