aboutsummaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2010-03-16 00:14:51 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2010-05-21 12:37:29 -0400
commitdb1afffab0b5d9f6d31f8f4bea44c9cb3bc59351 (patch)
tree5ba8fd7a5018c0772d999b8c3aa945c0efb929e0 /security
parentdd336c554d8926c3348a2d5f2a5ef5597f6d1a06 (diff)
kref: remove kref_set
Of the three uses of kref_set in the kernel: One really should be kref_put as the code is letting go of a reference, Two really should be kref_init because the kref is being initialised. This suggests that making kref_set available encourages bad code. So fix the three uses and remove kref_set completely. Signed-off-by: NeilBrown <neilb@suse.de> Acked-by: Mimi Zohar <zohar@us.ibm.com> Acked-by: Serge Hallyn <serue@us.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'security')
-rw-r--r--security/integrity/ima/ima_iint.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/security/integrity/ima/ima_iint.c b/security/integrity/ima/ima_iint.c
index 2dc2d6594145..7625b85c2274 100644
--- a/security/integrity/ima/ima_iint.c
+++ b/security/integrity/ima/ima_iint.c
@@ -94,7 +94,7 @@ void iint_free(struct kref *kref)
94 iint->opencount); 94 iint->opencount);
95 iint->opencount = 0; 95 iint->opencount = 0;
96 } 96 }
97 kref_set(&iint->refcount, 1); 97 kref_init(&iint->refcount);
98 kmem_cache_free(iint_cache, iint); 98 kmem_cache_free(iint_cache, iint);
99} 99}
100 100
@@ -133,7 +133,7 @@ static void init_once(void *foo)
133 iint->readcount = 0; 133 iint->readcount = 0;
134 iint->writecount = 0; 134 iint->writecount = 0;
135 iint->opencount = 0; 135 iint->opencount = 0;
136 kref_set(&iint->refcount, 1); 136 kref_init(&iint->refcount);
137} 137}
138 138
139static int __init ima_iintcache_init(void) 139static int __init ima_iintcache_init(void)