diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-05-17 09:42:35 -0400 |
|---|---|---|
| committer | James Morris <jmorris@namei.org> | 2010-05-17 18:50:55 -0400 |
| commit | 4d09ec0f705cf88a12add029c058b53f288cfaa2 (patch) | |
| tree | d756921f5391953295404ccf3ba570ddaaca404f /security | |
| parent | c80901f2755c582e3096e6708028a8daca59e6e2 (diff) | |
KEYS: Return more accurate error codes
We were using the wrong variable here so the error codes weren't being returned
properly. The original code returns -ENOKEY.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security')
| -rw-r--r-- | security/keys/process_keys.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c index 06c2ccf26ed3..20a38fed61b1 100644 --- a/security/keys/process_keys.c +++ b/security/keys/process_keys.c | |||
| @@ -508,7 +508,7 @@ try_again: | |||
| 508 | 508 | ||
| 509 | ret = install_thread_keyring(); | 509 | ret = install_thread_keyring(); |
| 510 | if (ret < 0) { | 510 | if (ret < 0) { |
| 511 | key = ERR_PTR(ret); | 511 | key_ref = ERR_PTR(ret); |
| 512 | goto error; | 512 | goto error; |
| 513 | } | 513 | } |
| 514 | goto reget_creds; | 514 | goto reget_creds; |
| @@ -526,7 +526,7 @@ try_again: | |||
| 526 | 526 | ||
| 527 | ret = install_process_keyring(); | 527 | ret = install_process_keyring(); |
| 528 | if (ret < 0) { | 528 | if (ret < 0) { |
| 529 | key = ERR_PTR(ret); | 529 | key_ref = ERR_PTR(ret); |
| 530 | goto error; | 530 | goto error; |
| 531 | } | 531 | } |
| 532 | goto reget_creds; | 532 | goto reget_creds; |
| @@ -585,7 +585,7 @@ try_again: | |||
| 585 | 585 | ||
| 586 | case KEY_SPEC_GROUP_KEYRING: | 586 | case KEY_SPEC_GROUP_KEYRING: |
| 587 | /* group keyrings are not yet supported */ | 587 | /* group keyrings are not yet supported */ |
| 588 | key = ERR_PTR(-EINVAL); | 588 | key_ref = ERR_PTR(-EINVAL); |
| 589 | goto error; | 589 | goto error; |
| 590 | 590 | ||
| 591 | case KEY_SPEC_REQKEY_AUTH_KEY: | 591 | case KEY_SPEC_REQKEY_AUTH_KEY: |
