diff options
author | Joe Perches <joe@perches.com> | 2011-01-12 19:59:56 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-01-13 11:03:11 -0500 |
commit | caf2a54f101a55ec318c2a20253a1977802f7de4 (patch) | |
tree | 0eaa61afa0af0754a42b8a1f5c642500c4a54026 /scripts | |
parent | 78c377d1b5e7ef15c8c307c2aa2511602a0829c3 (diff) |
scripts/checkpatch.pl: add check for multiple terminating semicolons and casts of vmalloc
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/checkpatch.pl | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index e3c7fc0dca38..36d6851f97d0 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -2785,10 +2785,15 @@ sub process { | |||
2785 | } | 2785 | } |
2786 | 2786 | ||
2787 | # check for pointless casting of kmalloc return | 2787 | # check for pointless casting of kmalloc return |
2788 | if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) { | 2788 | if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) { |
2789 | WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr); | 2789 | WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr); |
2790 | } | 2790 | } |
2791 | 2791 | ||
2792 | # check for multiple semicolons | ||
2793 | if ($line =~ /;\s*;\s*$/) { | ||
2794 | WARN("Statements terminations use 1 semicolon\n" . $herecurr); | ||
2795 | } | ||
2796 | |||
2792 | # check for gcc specific __FUNCTION__ | 2797 | # check for gcc specific __FUNCTION__ |
2793 | if ($line =~ /__FUNCTION__/) { | 2798 | if ($line =~ /__FUNCTION__/) { |
2794 | WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); | 2799 | WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); |