diff options
author | Eric Nelson <eric.nelson@boundarydevices.com> | 2012-05-31 19:26:09 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-31 20:49:27 -0400 |
commit | 9a4cad4e25b91f48494f13fce3d25ea44bec7472 (patch) | |
tree | 6b7cbfdf1517792f826f23408b8ca023ee2b3229 /scripts | |
parent | 133fd9f5cda2d86904126f4b9fa4e8f4330c9569 (diff) |
checkpatch: check for whitespace before semicolon at EOL
Requires --strict option during invocation:
~/linux$ scripts/checkpatch --strict foo.patch
This tests for a bad habits of mine like this:
return 0 ;
Note that it does allow a special case of a bare semicolon
for empty loops:
while (foo())
;
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/checkpatch.pl | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index faea0ec612bf..2262e1f57fa6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -2448,6 +2448,13 @@ sub process { | |||
2448 | "space prohibited between function name and open parenthesis '('\n" . $herecurr); | 2448 | "space prohibited between function name and open parenthesis '('\n" . $herecurr); |
2449 | } | 2449 | } |
2450 | } | 2450 | } |
2451 | |||
2452 | # check for whitespace before a non-naked semicolon | ||
2453 | if ($line =~ /^\+.*\S\s+;/) { | ||
2454 | CHK("SPACING", | ||
2455 | "space prohibited before semicolon\n" . $herecurr); | ||
2456 | } | ||
2457 | |||
2451 | # Check operator spacing. | 2458 | # Check operator spacing. |
2452 | if (!($line=~/\#\s*include/)) { | 2459 | if (!($line=~/\#\s*include/)) { |
2453 | my $ops = qr{ | 2460 | my $ops = qr{ |