diff options
| author | Andrew Morton <akpm@linux-foundation.org> | 2014-04-03 17:49:29 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-04-03 19:21:15 -0400 |
| commit | 74915c7dd0e144cc735058a77a3901c98f1e7039 (patch) | |
| tree | 30973190ba41e70204a81f07c1f631cfecd2c0f3 /scripts | |
| parent | 3b617e3b80548096eda92ebd8382f76b139e011c (diff) | |
scripts/checkpatch.pl: __GFP_NOFAIL isn't going away
Revert commit 7e4915e78992 ("checkpatch: add warning of future
__GFP_NOFAIL use").
There are no plans to remove __GFP_NOFAIL.
__GFP_NOFAIL exists to
a) centralise the retry-allocation-for-ever operation into the core
allocator, which is the appropriate implementation site and
b) permit us to identify code sites which aren't handling memory
exhaustion appropriately.
Cc: David Rientjes <rientjes@google.com>
Cc: Joe Perches <joe@perches.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/checkpatch.pl | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 33072d6c1b5a..d9b09eb767bb 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
| @@ -4330,12 +4330,6 @@ sub process { | |||
| 4330 | "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr); | 4330 | "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr); |
| 4331 | } | 4331 | } |
| 4332 | 4332 | ||
| 4333 | # check for GFP_NOWAIT use | ||
| 4334 | if ($line =~ /\b__GFP_NOFAIL\b/) { | ||
| 4335 | WARN("__GFP_NOFAIL", | ||
| 4336 | "Use of __GFP_NOFAIL is deprecated, no new users should be added\n" . $herecurr); | ||
| 4337 | } | ||
| 4338 | |||
| 4339 | # check for multiple semicolons | 4333 | # check for multiple semicolons |
| 4340 | if ($line =~ /;\s*;\s*$/) { | 4334 | if ($line =~ /;\s*;\s*$/) { |
| 4341 | if (WARN("ONE_SEMICOLON", | 4335 | if (WARN("ONE_SEMICOLON", |
