diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-04 20:31:11 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-04 20:31:11 -0400 |
commit | 27703bb4a66df49ff16b44b864d307d2eb71774c (patch) | |
tree | 356ce249a0af9775b3291a93fc56e466ffc5d1f8 /scripts | |
parent | 6f3bc58d84e9e4c4ed8584e020365f996a26a153 (diff) | |
parent | ad151d544475df40ee0d18be7d5c945e29c1b545 (diff) |
Merge tag 'PTR_RET-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux
Pull PTR_RET() removal patches from Rusty Russell:
"PTR_RET() is a weird name, and led to some confusing usage. We ended
up with PTR_ERR_OR_ZERO(), and replacing or fixing all the usages.
This has been sitting in linux-next for a whole cycle"
[ There are still some PTR_RET users scattered about, with some of them
possibly being new, but most of them existing in Rusty's tree too. We
have that
#define PTR_RET(p) PTR_ERR_OR_ZERO(p)
thing in <linux/err.h>, so they continue to work for now - Linus ]
* tag 'PTR_RET-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux:
GFS2: Replace PTR_RET with PTR_ERR_OR_ZERO
Btrfs: volume: Replace PTR_RET with PTR_ERR_OR_ZERO
drm/cma: Replace PTR_RET with PTR_ERR_OR_ZERO
sh_veu: Replace PTR_RET with PTR_ERR_OR_ZERO
dma-buf: Replace PTR_RET with PTR_ERR_OR_ZERO
drivers/rtc: Replace PTR_RET with PTR_ERR_OR_ZERO
mm/oom_kill: remove weird use of ERR_PTR()/PTR_ERR().
staging/zcache: don't use PTR_RET().
remoteproc: don't use PTR_RET().
pinctrl: don't use PTR_RET().
acpi: Replace weird use of PTR_RET.
s390: Replace weird use of PTR_RET.
PTR_RET is now PTR_ERR_OR_ZERO(): Replace most.
PTR_RET is now PTR_ERR_OR_ZERO
Diffstat (limited to 'scripts')
-rw-r--r-- | scripts/coccinelle/api/ptr_ret.cocci | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/scripts/coccinelle/api/ptr_ret.cocci b/scripts/coccinelle/api/ptr_ret.cocci index 2274638d005b..e18f8402e37c 100644 --- a/scripts/coccinelle/api/ptr_ret.cocci +++ b/scripts/coccinelle/api/ptr_ret.cocci | |||
@@ -1,5 +1,5 @@ | |||
1 | /// | 1 | /// |
2 | /// Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR | 2 | /// Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR |
3 | /// | 3 | /// |
4 | // Confidence: High | 4 | // Confidence: High |
5 | // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. | 5 | // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. |
@@ -7,7 +7,7 @@ | |||
7 | // URL: http://coccinelle.lip6.fr/ | 7 | // URL: http://coccinelle.lip6.fr/ |
8 | // Options: --no-includes --include-headers | 8 | // Options: --no-includes --include-headers |
9 | // | 9 | // |
10 | // Keywords: ERR_PTR, PTR_ERR, PTR_RET | 10 | // Keywords: ERR_PTR, PTR_ERR, PTR_RET, PTR_ERR_OR_ZERO |
11 | // Version min: 2.6.39 | 11 | // Version min: 2.6.39 |
12 | // | 12 | // |
13 | 13 | ||
@@ -21,21 +21,21 @@ expression ptr; | |||
21 | @@ | 21 | @@ |
22 | 22 | ||
23 | - if (IS_ERR(ptr)) return PTR_ERR(ptr); else return 0; | 23 | - if (IS_ERR(ptr)) return PTR_ERR(ptr); else return 0; |
24 | + return PTR_RET(ptr); | 24 | + return PTR_ERR_OR_ZERO(ptr); |
25 | 25 | ||
26 | @depends on patch@ | 26 | @depends on patch@ |
27 | expression ptr; | 27 | expression ptr; |
28 | @@ | 28 | @@ |
29 | 29 | ||
30 | - if (IS_ERR(ptr)) return PTR_ERR(ptr); return 0; | 30 | - if (IS_ERR(ptr)) return PTR_ERR(ptr); return 0; |
31 | + return PTR_RET(ptr); | 31 | + return PTR_ERR_OR_ZERO(ptr); |
32 | 32 | ||
33 | @depends on patch@ | 33 | @depends on patch@ |
34 | expression ptr; | 34 | expression ptr; |
35 | @@ | 35 | @@ |
36 | 36 | ||
37 | - (IS_ERR(ptr) ? PTR_ERR(ptr) : 0) | 37 | - (IS_ERR(ptr) ? PTR_ERR(ptr) : 0) |
38 | + PTR_RET(ptr) | 38 | + PTR_ERR_OR_ZERO(ptr) |
39 | 39 | ||
40 | @r1 depends on !patch@ | 40 | @r1 depends on !patch@ |
41 | expression ptr; | 41 | expression ptr; |