Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG"

This reverts commit 422c809f03f043d0950d8362214818e956a9daee.
It causes more harm than it solves issues.

Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Michal Marek <mmarek@suse.cz>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Greg KH <greg@kroah.com>

1 files changed, 3 insertions, 4 deletions

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index fc45fc137875..43eda40c3838 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -288,6 +288,8 @@ load:
         for_all_symbols(i, sym) {
                 sym->flags |= SYMBOL_CHANGED;
                 sym->flags &= ~(def_flags|SYMBOL_VALID);
+                if (sym_is_choice(sym))
+                        sym->flags |= def_flags;
                 switch (sym->type) {
                 case S_INT:
                 case S_HEX:
@@ -377,13 +379,13 @@ setsym:
                         case mod:
                                 if (cs->def[def].tri == yes) {
                                         conf_warning("%s creates inconsistent choice state", sym->name);
+                                        cs->flags &= ~def_flags;
                                 }
                                 break;
                         case yes:
                                 if (cs->def[def].tri != no)
                                         conf_warning("override: %s changes choice state", sym->name);
                                 cs->def[def].val = sym;
-                                cs->flags |= def_flags;
                                 break;
                         }
                         cs->def[def].tri = EXPR_OR(cs->def[def].tri, sym->def[def].tri);
@@ -789,8 +791,6 @@ int conf_write(const char *name)
                         sym_calc_value(sym);
                         if (!(sym->flags & SYMBOL_WRITE))
                                 goto next;
-                        if (sym_is_choice_value(sym) && !menu_is_visible(menu->parent))
-                                goto next;
                         sym->flags &= ~SYMBOL_WRITE;
 
                         conf_write_symbol(out, sym, &kconfig_printer_cb, NULL);
@@ -1077,7 +1077,6 @@ static void randomize_choice_values(struct symbol *csym)
                 else {
                         sym->def[S_DEF_USER].tri = no;
                 }
-                sym->flags &= ~(SYMBOL_VALID);
         }
         csym->flags |= SYMBOL_DEF_USER;
         /* clear VALID to get value calculated */