Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core

Pull perf/core improvements and fixes from Arnaldo Carvalho de Melo:

 * Fix include order for bison/flex-generated C files, from Ben Hutchings

 * Build fixes and documentation corrections from David Ahern

 * Group parsing support, from Jiri Olsa

 * UI/gtk refactorings and improvements from Namhyung Kim

 * NULL deref fix for perf script, from Namhyung Kim

 * Assorted cleanups from Robert Richter

 * Let O= makes handle relative paths, from Steven Rostedt

 * perf script python fixes, from Feng Tang.

 * Improve 'perf lock' error message when the needed tracepoints
   are not present, from David Ahern.

 * Initial bash completion support, from Frederic Weisbecker

 * Allow building without libelf, from Namhyung Kim.

 * Support DWARF CFI based unwind to have callchains when %bp
   based unwinding is not possible, from Jiri Olsa.

 * Symbol resolution fixes, while fixing support PPC64 files with an .opt ELF
   section was the end goal, several fixes for code that handles all
   architectures and cleanups are included, from Cody Schafer.

 * Add a description for the JIT interface, from Andi Kleen.

 * Assorted fixes for Documentation and build in 32 bit, from Robert Richter

 * Add support for non-tracepoint events in perf script python, from Feng Tang

 * Cache the libtraceevent event_format associated to each evsel early, so that we
   avoid relookups, i.e. calling pevent_find_event repeatedly when processing
   tracepoint events.

   [ This is to reduce the surface contact with libtraceevents and make clear what
     is that the perf tools needs from that lib: so far parsing the common and per
     event fields. ]

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>

1 files changed, 68 insertions, 3 deletions

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e5bd60ff48e3..913d6bdfdda3 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1600,13 +1600,17 @@ sub process {
 
 # Check signature styles
                 if (!$in_header_lines &&
-                    $line =~ /^(\s*)($signature_tags)(\s*)(.*)/) {
+                    $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
                         my $space_before = $1;
                         my $sign_off = $2;
                         my $space_after = $3;
                         my $email = $4;
                         my $ucfirst_sign_off = ucfirst(lc($sign_off));
 
+                        if ($sign_off !~ /$signature_tags/) {
+                                WARN("BAD_SIGN_OFF",
+                                     "Non-standard signature: $sign_off\n" . $herecurr);
+                        }
                         if (defined $space_before && $space_before ne "") {
                                 WARN("BAD_SIGN_OFF",
                                      "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);
@@ -1848,8 +1852,8 @@ sub process {
 
                         my $pos = pos_last_openparen($rest);
                         if ($pos >= 0) {
-                                $line =~ /^\+([ \t]*)/;
-                                my $newindent = $1;
+                                $line =~ /^(\+| )([ \t]*)/;
+                                my $newindent = $2;
 
                                 my $goodtabindent = $oldindent .
                                         "\t" x ($pos / 8) .
@@ -2984,6 +2988,45 @@ sub process {
                         }
                 }
 
+# do {} while (0) macro tests:
+# single-statement macros do not need to be enclosed in do while (0) loop,
+# macro should not end with a semicolon
+                if ($^V && $^V ge 5.10.0 &&
+                    $realfile !~ m@/vmlinux.lds.h$@ &&
+                    $line =~ /^.\s*\#\s*define\s+$Ident(\()?/) {
+                        my $ln = $linenr;
+                        my $cnt = $realcnt;
+                        my ($off, $dstat, $dcond, $rest);
+                        my $ctx = '';
+                        ($dstat, $dcond, $ln, $cnt, $off) =
+                                ctx_statement_block($linenr, $realcnt, 0);
+                        $ctx = $dstat;
+
+                        $dstat =~ s/\\\n.//g;
+
+                        if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
+                                my $stmts = $2;
+                                my $semis = $3;
+
+                                $ctx =~ s/\n*$//;
+                                my $cnt = statement_rawlines($ctx);
+                                my $herectx = $here . "\n";
+
+                                for (my $n = 0; $n < $cnt; $n++) {
+                                        $herectx .= raw_line($linenr, $n) . "\n";
+                                }
+
+                                if (($stmts =~ tr/;/;/) == 1) {
+                                        WARN("SINGLE_STATEMENT_DO_WHILE_MACRO",
+                                             "Single statement macros should not use a do {} while (0) loop\n" . "$herectx");
+                                }
+                                if (defined $semis && $semis ne "") {
+                                        WARN("DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON",
+                                             "do {} while (0) macros should not be semicolon terminated\n" . "$herectx");
+                                }
+                        }
+                }
+
 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
 # all assignments may have only one of the following with an assignment:
 #       .
@@ -3261,6 +3304,12 @@ sub process {
                              "sizeof(& should be avoided\n" . $herecurr);
                 }
 
+# check for sizeof without parenthesis
+                if ($line =~ /\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/) {
+                        WARN("SIZEOF_PARENTHESIS",
+                             "sizeof $1 should be sizeof($1)\n" . $herecurr);
+                }
+
 # check for line continuations in quoted strings with odd counts of "
                 if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
                         WARN("LINE_CONTINUATIONS",
@@ -3309,6 +3358,22 @@ sub process {
                         }
                 }
 
+# check usleep_range arguments
+                if ($^V && $^V ge 5.10.0 &&
+                    defined $stat &&
+                    $stat =~ /^\+(?:.*?)\busleep_range\s*\(\s*($FuncArg)\s*,\s*($FuncArg)\s*\)/) {
+                        my $min = $1;
+                        my $max = $7;
+                        if ($min eq $max) {
+                                WARN("USLEEP_RANGE",
+                                     "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
+                        } elsif ($min =~ /^\d+$/ && $max =~ /^\d+$/ &&
+                                 $min > $max) {
+                                WARN("USLEEP_RANGE",
+                                     "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
+                        }
+                }
+
 # check for new externs in .c files.
                 if ($realfile =~ /\.c$/ && defined $stat &&
                     $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)