diff options
author | viresh kumar <viresh.kumar@linaro.org> | 2014-01-22 01:53:33 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-01-23 00:57:05 -0500 |
commit | f618002b0b598036ebb8feceb44ea8e05f4cd37b (patch) | |
tree | 0273785b7340ba3490ae27afae6f8dc320fa2070 /net | |
parent | 906e073f3e842877b59d669b25aa76f65ba775b3 (diff) |
net/neighbour: queue work on power efficient wq
Workqueue used in neighbour layer have no real dependency of scheduling these on
the cpu which scheduled them.
On a idle system, it is observed that an idle cpu wakes up many times just to
service this work. It would be better if we can schedule it on a cpu which the
scheduler believes to be the most appropriate one.
This patch replaces normal workqueues with power efficient versions. This
doesn't change existing behavior of code unless CONFIG_WQ_POWER_EFFICIENT is
enabled.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/core/neighbour.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index f8012feddf6d..b9e9e0d38672 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c | |||
@@ -828,7 +828,7 @@ out: | |||
828 | * ARP entry timeouts range from 1/2 BASE_REACHABLE_TIME to 3/2 | 828 | * ARP entry timeouts range from 1/2 BASE_REACHABLE_TIME to 3/2 |
829 | * BASE_REACHABLE_TIME. | 829 | * BASE_REACHABLE_TIME. |
830 | */ | 830 | */ |
831 | schedule_delayed_work(&tbl->gc_work, | 831 | queue_delayed_work(system_power_efficient_wq, &tbl->gc_work, |
832 | NEIGH_VAR(&tbl->parms, BASE_REACHABLE_TIME) >> 1); | 832 | NEIGH_VAR(&tbl->parms, BASE_REACHABLE_TIME) >> 1); |
833 | write_unlock_bh(&tbl->lock); | 833 | write_unlock_bh(&tbl->lock); |
834 | } | 834 | } |
@@ -1565,7 +1565,8 @@ static void neigh_table_init_no_netlink(struct neigh_table *tbl) | |||
1565 | 1565 | ||
1566 | rwlock_init(&tbl->lock); | 1566 | rwlock_init(&tbl->lock); |
1567 | INIT_DEFERRABLE_WORK(&tbl->gc_work, neigh_periodic_work); | 1567 | INIT_DEFERRABLE_WORK(&tbl->gc_work, neigh_periodic_work); |
1568 | schedule_delayed_work(&tbl->gc_work, tbl->parms.reachable_time); | 1568 | queue_delayed_work(system_power_efficient_wq, &tbl->gc_work, |
1569 | tbl->parms.reachable_time); | ||
1569 | setup_timer(&tbl->proxy_timer, neigh_proxy_process, (unsigned long)tbl); | 1570 | setup_timer(&tbl->proxy_timer, neigh_proxy_process, (unsigned long)tbl); |
1570 | skb_queue_head_init_class(&tbl->proxy_queue, | 1571 | skb_queue_head_init_class(&tbl->proxy_queue, |
1571 | &neigh_table_proxy_queue_class); | 1572 | &neigh_table_proxy_queue_class); |