diff options
author | Chuck Lever <cel@citi.umich.edu> | 2005-08-11 16:25:14 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2005-09-23 12:38:06 -0400 |
commit | eab5c084b858fd95a873fc2b97de9a9ad937b4ed (patch) | |
tree | 6ba8287570ecc83fed1512bd4901df979221c2ab /net | |
parent | da35187801732397a7e05fb9e77f3700cc35f5db (diff) |
[PATCH] NFS: use a constant value for TCP retransmit timeouts
Implement a best practice: don't use exponential backoff when computing
retransmit timeout values on TCP connections, but simply retransmit
at regular intervals.
This also fixes a bug introduced when xprt_reset_majortimeo() was added.
Test-plan:
Enable RPC debugging and watch timeout behavior on a NFS/TCP mount.
Version: Thu, 11 Aug 2005 16:02:19 -0400
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net')
-rw-r--r-- | net/sunrpc/xprt.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c index b28ea0cc0cb7..0e4ffdaa0129 100644 --- a/net/sunrpc/xprt.c +++ b/net/sunrpc/xprt.c | |||
@@ -1453,7 +1453,7 @@ xprt_default_timeout(struct rpc_timeout *to, int proto) | |||
1453 | if (proto == IPPROTO_UDP) | 1453 | if (proto == IPPROTO_UDP) |
1454 | xprt_set_timeout(to, 5, 5 * HZ); | 1454 | xprt_set_timeout(to, 5, 5 * HZ); |
1455 | else | 1455 | else |
1456 | xprt_set_timeout(to, 5, 60 * HZ); | 1456 | xprt_set_timeout(to, 2, 60 * HZ); |
1457 | } | 1457 | } |
1458 | 1458 | ||
1459 | /* | 1459 | /* |
@@ -1464,7 +1464,7 @@ xprt_set_timeout(struct rpc_timeout *to, unsigned int retr, unsigned long incr) | |||
1464 | { | 1464 | { |
1465 | to->to_initval = | 1465 | to->to_initval = |
1466 | to->to_increment = incr; | 1466 | to->to_increment = incr; |
1467 | to->to_maxval = incr * retr; | 1467 | to->to_maxval = to->to_initval + (incr * retr); |
1468 | to->to_retries = retr; | 1468 | to->to_retries = retr; |
1469 | to->to_exponential = 0; | 1469 | to->to_exponential = 0; |
1470 | } | 1470 | } |