diff options
author | Johannes Berg <johannes.berg@intel.com> | 2014-10-31 09:16:12 -0400 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2014-10-31 09:19:19 -0400 |
commit | de4fcbadde68e3429cc533c29abf6fbceda4628f (patch) | |
tree | 6f797d624377a194d2a327f740b827898ce868d9 /net | |
parent | 579a05f29611dcef94b6bda21f1d059ab189a263 (diff) |
cfg80211: avoid using default in interface type switch
Most code avoids having a default case in interface type switch
statements already, to make it easier to find places that need
to be extended. Change the code in the __cfg80211_leave() and
nl80211_key_allowed() functions to not have a default case.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net')
-rw-r--r-- | net/wireless/core.c | 14 | ||||
-rw-r--r-- | net/wireless/nl80211.c | 6 |
2 files changed, 18 insertions, 2 deletions
diff --git a/net/wireless/core.c b/net/wireless/core.c index 87bb502bc8de..da4dcb65ade4 100644 --- a/net/wireless/core.c +++ b/net/wireless/core.c | |||
@@ -869,7 +869,19 @@ void __cfg80211_leave(struct cfg80211_registered_device *rdev, | |||
869 | case NL80211_IFTYPE_P2P_GO: | 869 | case NL80211_IFTYPE_P2P_GO: |
870 | __cfg80211_stop_ap(rdev, dev, true); | 870 | __cfg80211_stop_ap(rdev, dev, true); |
871 | break; | 871 | break; |
872 | default: | 872 | case NL80211_IFTYPE_WDS: |
873 | /* must be handled by mac80211/driver, has no APIs */ | ||
874 | break; | ||
875 | case NL80211_IFTYPE_P2P_DEVICE: | ||
876 | /* cannot happen, has no netdev */ | ||
877 | break; | ||
878 | case NL80211_IFTYPE_AP_VLAN: | ||
879 | case NL80211_IFTYPE_MONITOR: | ||
880 | /* nothing to do */ | ||
881 | break; | ||
882 | case NL80211_IFTYPE_UNSPECIFIED: | ||
883 | case NUM_NL80211_IFTYPES: | ||
884 | /* invalid */ | ||
873 | break; | 885 | break; |
874 | } | 886 | } |
875 | } | 887 | } |
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 33aff7466f2f..f7d918858d32 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c | |||
@@ -884,7 +884,11 @@ static int nl80211_key_allowed(struct wireless_dev *wdev) | |||
884 | if (!wdev->current_bss) | 884 | if (!wdev->current_bss) |
885 | return -ENOLINK; | 885 | return -ENOLINK; |
886 | break; | 886 | break; |
887 | default: | 887 | case NL80211_IFTYPE_UNSPECIFIED: |
888 | case NL80211_IFTYPE_MONITOR: | ||
889 | case NL80211_IFTYPE_P2P_DEVICE: | ||
890 | case NL80211_IFTYPE_WDS: | ||
891 | case NUM_NL80211_IFTYPES: | ||
888 | return -EINVAL; | 892 | return -EINVAL; |
889 | } | 893 | } |
890 | 894 | ||