aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorAlex Elder <elder@inktank.com>2012-11-09 09:43:15 -0500
committerAlex Elder <elder@inktank.com>2013-01-17 16:52:01 -0500
commitaf77f26caa35a95af09d1dac5c513b3901de7e37 (patch)
tree9c5efeda0e8eead5ece30957f88d6155f677cb0c /net
parent0ec8ce87f3bb5e4a561190f5320934e003405b6f (diff)
rbd: drop oid parameters from ceph_osdc_build_request()
The last two parameters to ceph_osd_build_request() describe the object id, but the values passed always come from the osd request structure whose address is also provided. Get rid of those last two parameters. Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
Diffstat (limited to 'net')
-rw-r--r--net/ceph/osd_client.c13
1 files changed, 5 insertions, 8 deletions
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index eade41bb7102..7d38327a8e89 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -376,9 +376,7 @@ void ceph_osdc_build_request(struct ceph_osd_request *req,
376 u64 off, u64 *plen, 376 u64 off, u64 *plen,
377 struct ceph_osd_req_op *src_ops, 377 struct ceph_osd_req_op *src_ops,
378 struct ceph_snap_context *snapc, 378 struct ceph_snap_context *snapc,
379 struct timespec *mtime, 379 struct timespec *mtime)
380 const char *oid,
381 int oid_len)
382{ 380{
383 struct ceph_msg *msg = req->r_request; 381 struct ceph_msg *msg = req->r_request;
384 struct ceph_osd_request_head *head; 382 struct ceph_osd_request_head *head;
@@ -405,9 +403,9 @@ void ceph_osdc_build_request(struct ceph_osd_request *req,
405 403
406 404
407 /* fill in oid */ 405 /* fill in oid */
408 head->object_len = cpu_to_le32(oid_len); 406 head->object_len = cpu_to_le32(req->r_oid_len);
409 memcpy(p, oid, oid_len); 407 memcpy(p, req->r_oid, req->r_oid_len);
410 p += oid_len; 408 p += req->r_oid_len;
411 409
412 src_op = src_ops; 410 src_op = src_ops;
413 while (src_op->op) { 411 while (src_op->op) {
@@ -506,8 +504,7 @@ struct ceph_osd_request *ceph_osdc_new_request(struct ceph_osd_client *osdc,
506 504
507 ceph_osdc_build_request(req, off, plen, ops, 505 ceph_osdc_build_request(req, off, plen, ops,
508 snapc, 506 snapc,
509 mtime, 507 mtime);
510 req->r_oid, req->r_oid_len);
511 508
512 return req; 509 return req;
513} 510}