rxrpc: switch rxrpc_send_data() to iov_iter primitives

Convert skb_add_data() to iov_iter; allows to get rid of the explicit
messing with iovec in its only caller - skb_add_data() will keep advancing
->msg_iter for us, so there's no need to similate that manually.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

1 files changed, 10 insertions, 33 deletions

diff --git a/net/rxrpc/ar-output.c b/net/rxrpc/ar-output.c
index e1a9373e5979..963a5b91f3e8 100644
--- a/net/rxrpc/ar-output.c
+++ b/net/rxrpc/ar-output.c
@@ -529,13 +529,11 @@ static int rxrpc_send_data(struct kiocb *iocb,
                            struct msghdr *msg, size_t len)
 {
         struct rxrpc_skb_priv *sp;
-        unsigned char __user *from;
         struct sk_buff *skb;
-        const struct iovec *iov;
         struct sock *sk = &rx->sk;
         long timeo;
         bool more;
-        int ret, ioc, segment, copied;
+        int ret, copied;
 
         timeo = sock_sndtimeo(sk, msg->msg_flags & MSG_DONTWAIT);
 
@@ -545,25 +543,17 @@ static int rxrpc_send_data(struct kiocb *iocb,
         if (sk->sk_err || (sk->sk_shutdown & SEND_SHUTDOWN))
                 return -EPIPE;
 
-        iov = msg->msg_iter.iov;
-        ioc = msg->msg_iter.nr_segs - 1;
-        from = iov->iov_base;
-        segment = iov->iov_len;
-        iov++;
         more = msg->msg_flags & MSG_MORE;
 
         skb = call->tx_pending;
         call->tx_pending = NULL;
 
         copied = 0;
-        do {
+        if (len > iov_iter_count(&msg->msg_iter))
+                len = iov_iter_count(&msg->msg_iter);
+        while (len) {
                 int copy;
 
-                if (segment > len)
-                        segment = len;
-
-                _debug("SEGMENT %d @%p", segment, from);
-
                 if (!skb) {
                         size_t size, chunk, max, space;
 
@@ -631,13 +621,13 @@ static int rxrpc_send_data(struct kiocb *iocb,
                 /* append next segment of data to the current buffer */
                 copy = skb_tailroom(skb);
                 ASSERTCMP(copy, >, 0);
-                if (copy > segment)
-                        copy = segment;
+                if (copy > len)
+                        copy = len;
                 if (copy > sp->remain)
                         copy = sp->remain;
 
                 _debug("add");
-                ret = skb_add_data(skb, from, copy);
+                ret = skb_add_data(skb, &msg->msg_iter, copy);
                 _debug("added");
                 if (ret < 0)
                         goto efault;
@@ -646,18 +636,6 @@ static int rxrpc_send_data(struct kiocb *iocb,
                 copied += copy;
 
                 len -= copy;
-                segment -= copy;
-                from += copy;
-                while (segment == 0 && ioc > 0) {
-                        from = iov->iov_base;
-                        segment = iov->iov_len;
-                        iov++;
-                        ioc--;
-                }
-                if (len == 0) {
-                        segment = 0;
-                        ioc = 0;
-                }
 
                 /* check for the far side aborting the call or a network error
                  * occurring */
@@ -665,7 +643,7 @@ static int rxrpc_send_data(struct kiocb *iocb,
                         goto call_aborted;
 
                 /* add the packet to the send queue if it's now full */
-                if (sp->remain <= 0 || (segment == 0 && !more)) {
+                if (sp->remain <= 0 || (!len && !more)) {
                         struct rxrpc_connection *conn = call->conn;
                         uint32_t seq;
                         size_t pad;
@@ -711,11 +689,10 @@ static int rxrpc_send_data(struct kiocb *iocb,
 
                         memcpy(skb->head, &sp->hdr,
                                sizeof(struct rxrpc_header));
-                        rxrpc_queue_packet(call, skb, segment == 0 && !more);
+                        rxrpc_queue_packet(call, skb, !iov_iter_count(&msg->msg_iter) && !more);
                         skb = NULL;
                 }
-
-        } while (segment > 0);
+        }
 
 success:
         ret = copied;