pkt_sched: Fix missed RCU unlock in dev_queue_xmit()

Noticed by Jarek Poplawski.

Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 4 insertions, 6 deletions

diff --git a/net/core/dev.c b/net/core/dev.c
index 819f0175bdc9..8d133802372b 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1805,14 +1805,12 @@ gso:
                 spin_lock(root_lock);
 
                 if (unlikely(test_bit(__QDISC_STATE_DEACTIVATED, &q->state))) {
-                        spin_unlock(root_lock);
+                        kfree_skb(skb);
                         rc = NET_XMIT_DROP;
-                        goto out_kfree_skb;
+                } else {
+                        rc = qdisc_enqueue_root(skb, q);
+                        qdisc_run(q);
                 }
-
-                rc = qdisc_enqueue_root(skb, q);
-                qdisc_run(q);
-
                 spin_unlock(root_lock);
 
                 goto out;