diff options
author | Hirofumi Nakagawa <hnakagawa@miraclelinux.com> | 2008-04-29 04:03:09 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-29 11:06:25 -0400 |
commit | 801678c5a3b4c79236970bcca27c733f5559e0d1 (patch) | |
tree | 5ad4761f539525077895f261b64fccda4d1303c4 /net | |
parent | 9a6f70bbed4e8b72dd340812d7c606bfd5e00b47 (diff) |
Remove duplicated unlikely() in IS_ERR()
Some drivers have duplicated unlikely() macros. IS_ERR() already has
unlikely() in itself.
This patch cleans up such pointless code.
Signed-off-by: Hirofumi Nakagawa <hnakagawa@miraclelinux.com>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Jeff Garzik <jeff@garzik.org>
Cc: Paul Clements <paul.clements@steeleye.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: David Brownell <david-b@pacbell.net>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Michael Halcrow <mhalcrow@us.ibm.com>
Cc: Anton Altaparmakov <aia21@cantab.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Carsten Otte <cotte@de.ibm.com>
Cc: Patrick McHardy <kaber@trash.net>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net')
-rw-r--r-- | net/core/dev.c | 2 | ||||
-rw-r--r-- | net/ipv4/af_inet.c | 2 | ||||
-rw-r--r-- | net/netfilter/nf_queue.c | 2 | ||||
-rw-r--r-- | net/xfrm/xfrm_output.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index e1df1ab3e04a..ed49da592051 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
@@ -1524,7 +1524,7 @@ static int dev_gso_segment(struct sk_buff *skb) | |||
1524 | if (!segs) | 1524 | if (!segs) |
1525 | return 0; | 1525 | return 0; |
1526 | 1526 | ||
1527 | if (unlikely(IS_ERR(segs))) | 1527 | if (IS_ERR(segs)) |
1528 | return PTR_ERR(segs); | 1528 | return PTR_ERR(segs); |
1529 | 1529 | ||
1530 | skb->next = segs; | 1530 | skb->next = segs; |
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index f2b5270efdaa..24eca23c2db3 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c | |||
@@ -1234,7 +1234,7 @@ static struct sk_buff *inet_gso_segment(struct sk_buff *skb, int features) | |||
1234 | segs = ops->gso_segment(skb, features); | 1234 | segs = ops->gso_segment(skb, features); |
1235 | rcu_read_unlock(); | 1235 | rcu_read_unlock(); |
1236 | 1236 | ||
1237 | if (!segs || unlikely(IS_ERR(segs))) | 1237 | if (!segs || IS_ERR(segs)) |
1238 | goto out; | 1238 | goto out; |
1239 | 1239 | ||
1240 | skb = segs; | 1240 | skb = segs; |
diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c index bbd26893c0c4..582ec3efc8a5 100644 --- a/net/netfilter/nf_queue.c +++ b/net/netfilter/nf_queue.c | |||
@@ -214,7 +214,7 @@ int nf_queue(struct sk_buff *skb, | |||
214 | 214 | ||
215 | segs = skb_gso_segment(skb, 0); | 215 | segs = skb_gso_segment(skb, 0); |
216 | kfree_skb(skb); | 216 | kfree_skb(skb); |
217 | if (unlikely(IS_ERR(segs))) | 217 | if (IS_ERR(segs)) |
218 | return 1; | 218 | return 1; |
219 | 219 | ||
220 | do { | 220 | do { |
diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c index 2519129c6d21..09cd9c0c2d80 100644 --- a/net/xfrm/xfrm_output.c +++ b/net/xfrm/xfrm_output.c | |||
@@ -150,7 +150,7 @@ static int xfrm_output_gso(struct sk_buff *skb) | |||
150 | 150 | ||
151 | segs = skb_gso_segment(skb, 0); | 151 | segs = skb_gso_segment(skb, 0); |
152 | kfree_skb(skb); | 152 | kfree_skb(skb); |
153 | if (unlikely(IS_ERR(segs))) | 153 | if (IS_ERR(segs)) |
154 | return PTR_ERR(segs); | 154 | return PTR_ERR(segs); |
155 | 155 | ||
156 | do { | 156 | do { |