SUNRPC: Clean up the RPCSEC_GSS service ticket requests

Instead of hacking specific service names into gss_encode_v1_msg, we should
just allow the caller to specify the service name explicitly.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Acked-by: J. Bruce Fields <bfields@redhat.com>

2 files changed, 27 insertions, 19 deletions

diff --git a/net/sunrpc/auth_generic.c b/net/sunrpc/auth_generic.c
index e010a015d996..1426ec3d0a53 100644
--- a/net/sunrpc/auth_generic.c
+++ b/net/sunrpc/auth_generic.c
@@ -41,15 +41,17 @@ EXPORT_SYMBOL_GPL(rpc_lookup_cred);
 /*
  * Public call interface for looking up machine creds.
  */
-struct rpc_cred *rpc_lookup_machine_cred(void)
+struct rpc_cred *rpc_lookup_machine_cred(const char *service_name)
 {
         struct auth_cred acred = {
                 .uid = RPC_MACHINE_CRED_USERID,
                 .gid = RPC_MACHINE_CRED_GROUPID,
+                .principal = service_name,
                 .machine_cred = 1,
         };
 
-        dprintk("RPC:       looking up machine cred\n");
+        dprintk("RPC:       looking up machine cred for service %s\n",
+                        service_name);
         return generic_auth.au_ops->lookup_cred(&generic_auth, &acred, 0);
 }
 EXPORT_SYMBOL_GPL(rpc_lookup_machine_cred);
diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
index afb56553dfe7..28d72d298735 100644
--- a/net/sunrpc/auth_gss/auth_gss.c
+++ b/net/sunrpc/auth_gss/auth_gss.c
@@ -392,7 +392,8 @@ static void gss_encode_v0_msg(struct gss_upcall_msg *gss_msg)
 }
 
 static void gss_encode_v1_msg(struct gss_upcall_msg *gss_msg,
-                                struct rpc_clnt *clnt, int machine_cred)
+                                struct rpc_clnt *clnt,
+                                const char *service_name)
 {
         struct gss_api_mech *mech = gss_msg->auth->mech;
         char *p = gss_msg->databuf;
@@ -407,12 +408,8 @@ static void gss_encode_v1_msg(struct gss_upcall_msg *gss_msg,
                 p += len;
                 gss_msg->msg.len += len;
         }
-        if (machine_cred) {
-                len = sprintf(p, "service=* ");
-                p += len;
-                gss_msg->msg.len += len;
-        } else if (!strcmp(clnt->cl_program->name, "nfs4_cb")) {
-                len = sprintf(p, "service=nfs ");
+        if (service_name != NULL) {
+                len = sprintf(p, "service=%s ", service_name);
                 p += len;
                 gss_msg->msg.len += len;
         }
@@ -429,17 +426,18 @@ static void gss_encode_v1_msg(struct gss_upcall_msg *gss_msg,
 }
 
 static void gss_encode_msg(struct gss_upcall_msg *gss_msg,
-                                struct rpc_clnt *clnt, int machine_cred)
+                                struct rpc_clnt *clnt,
+                                const char *service_name)
 {
         if (pipe_version == 0)
                 gss_encode_v0_msg(gss_msg);
         else /* pipe_version == 1 */
-                gss_encode_v1_msg(gss_msg, clnt, machine_cred);
+                gss_encode_v1_msg(gss_msg, clnt, service_name);
 }
 
-static inline struct gss_upcall_msg *
-gss_alloc_msg(struct gss_auth *gss_auth, uid_t uid, struct rpc_clnt *clnt,
-                int machine_cred)
+static struct gss_upcall_msg *
+gss_alloc_msg(struct gss_auth *gss_auth, struct rpc_clnt *clnt,
+                uid_t uid, const char *service_name)
 {
         struct gss_upcall_msg *gss_msg;
         int vers;
@@ -459,7 +457,7 @@ gss_alloc_msg(struct gss_auth *gss_auth, uid_t uid, struct rpc_clnt *clnt,
         atomic_set(&gss_msg->count, 1);
         gss_msg->uid = uid;
         gss_msg->auth = gss_auth;
-        gss_encode_msg(gss_msg, clnt, machine_cred);
+        gss_encode_msg(gss_msg, clnt, service_name);
         return gss_msg;
 }
 
@@ -471,7 +469,7 @@ gss_setup_upcall(struct rpc_clnt *clnt, struct gss_auth *gss_auth, struct rpc_cr
         struct gss_upcall_msg *gss_new, *gss_msg;
         uid_t uid = cred->cr_uid;
 
-        gss_new = gss_alloc_msg(gss_auth, uid, clnt, gss_cred->gc_machine_cred);
+        gss_new = gss_alloc_msg(gss_auth, clnt, uid, gss_cred->gc_principal);
         if (IS_ERR(gss_new))
                 return gss_new;
         gss_msg = gss_add_msg(gss_new);
@@ -995,7 +993,9 @@ gss_create_cred(struct rpc_auth *auth, struct auth_cred *acred, int flags)
          */
         cred->gc_base.cr_flags = 1UL << RPCAUTH_CRED_NEW;
         cred->gc_service = gss_auth->service;
-        cred->gc_machine_cred = acred->machine_cred;
+        cred->gc_principal = NULL;
+        if (acred->machine_cred)
+                cred->gc_principal = acred->principal;
         kref_get(&gss_auth->kref);
         return &cred->gc_base;
 
@@ -1030,7 +1030,12 @@ gss_match(struct auth_cred *acred, struct rpc_cred *rc, int flags)
         if (!test_bit(RPCAUTH_CRED_UPTODATE, &rc->cr_flags))
                 return 0;
 out:
-        if (acred->machine_cred != gss_cred->gc_machine_cred)
+        if (acred->principal != NULL) {
+                if (gss_cred->gc_principal == NULL)
+                        return 0;
+                return strcmp(acred->principal, gss_cred->gc_principal) == 0;
+        }
+        if (gss_cred->gc_principal != NULL)
                 return 0;
         return rc->cr_uid == acred->uid;
 }
@@ -1104,7 +1109,8 @@ static int gss_renew_cred(struct rpc_task *task)
         struct rpc_auth *auth = oldcred->cr_auth;
         struct auth_cred acred = {
                 .uid = oldcred->cr_uid,
-                .machine_cred = gss_cred->gc_machine_cred,
+                .principal = gss_cred->gc_principal,
+                .machine_cred = (gss_cred->gc_principal != NULL ? 1 : 0),
         };
         struct rpc_cred *new;