diff options
| author | Jiri Pirko <jpirko@redhat.com> | 2010-02-07 23:30:35 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-02-12 14:38:58 -0500 |
| commit | 4cd24eaf0c6ee7f0242e34ee77ec899f255e66b5 (patch) | |
| tree | 99f57f6374a58022e1e5ed1cbc12699288c7eae1 /net | |
| parent | 8e5574211d96c0552f84c757718475fdb4021be7 (diff) | |
net: use netdev_mc_count and netdev_mc_empty when appropriate
This patch replaces dev->mc_count in all drivers (hopefully I didn't miss
anything). Used spatch and did small tweaks and conding style changes when
it was suitable.
Jirka
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/bluetooth/bnep/netdev.c | 6 | ||||
| -rw-r--r-- | net/core/dev.c | 2 | ||||
| -rw-r--r-- | net/irda/irlan/irlan_eth.c | 5 | ||||
| -rw-r--r-- | net/mac80211/iface.c | 2 |
4 files changed, 9 insertions, 6 deletions
diff --git a/net/bluetooth/bnep/netdev.c b/net/bluetooth/bnep/netdev.c index 26fb831ef7e0..b6234b73c4cf 100644 --- a/net/bluetooth/bnep/netdev.c +++ b/net/bluetooth/bnep/netdev.c | |||
| @@ -64,7 +64,7 @@ static void bnep_net_set_mc_list(struct net_device *dev) | |||
| 64 | struct sk_buff *skb; | 64 | struct sk_buff *skb; |
| 65 | int size; | 65 | int size; |
| 66 | 66 | ||
| 67 | BT_DBG("%s mc_count %d", dev->name, dev->mc_count); | 67 | BT_DBG("%s mc_count %d", dev->name, netdev_mc_count(dev)); |
| 68 | 68 | ||
| 69 | size = sizeof(*r) + (BNEP_MAX_MULTICAST_FILTERS + 1) * ETH_ALEN * 2; | 69 | size = sizeof(*r) + (BNEP_MAX_MULTICAST_FILTERS + 1) * ETH_ALEN * 2; |
| 70 | skb = alloc_skb(size, GFP_ATOMIC); | 70 | skb = alloc_skb(size, GFP_ATOMIC); |
| @@ -97,7 +97,9 @@ static void bnep_net_set_mc_list(struct net_device *dev) | |||
| 97 | 97 | ||
| 98 | /* FIXME: We should group addresses here. */ | 98 | /* FIXME: We should group addresses here. */ |
| 99 | 99 | ||
| 100 | for (i = 0; i < dev->mc_count && i < BNEP_MAX_MULTICAST_FILTERS; i++) { | 100 | for (i = 0; |
| 101 | i < netdev_mc_count(dev) && i < BNEP_MAX_MULTICAST_FILTERS; | ||
| 102 | i++) { | ||
| 101 | memcpy(__skb_put(skb, ETH_ALEN), dmi->dmi_addr, ETH_ALEN); | 103 | memcpy(__skb_put(skb, ETH_ALEN), dmi->dmi_addr, ETH_ALEN); |
| 102 | memcpy(__skb_put(skb, ETH_ALEN), dmi->dmi_addr, ETH_ALEN); | 104 | memcpy(__skb_put(skb, ETH_ALEN), dmi->dmi_addr, ETH_ALEN); |
| 103 | dmi = dmi->next; | 105 | dmi = dmi->next; |
diff --git a/net/core/dev.c b/net/core/dev.c index ae75f25ac0a5..d1cf53d0d597 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
| @@ -4263,7 +4263,7 @@ static void dev_addr_discard(struct net_device *dev) | |||
| 4263 | netif_addr_lock_bh(dev); | 4263 | netif_addr_lock_bh(dev); |
| 4264 | 4264 | ||
| 4265 | __dev_addr_discard(&dev->mc_list); | 4265 | __dev_addr_discard(&dev->mc_list); |
| 4266 | dev->mc_count = 0; | 4266 | netdev_mc_count(dev) = 0; |
| 4267 | 4267 | ||
| 4268 | netif_addr_unlock_bh(dev); | 4268 | netif_addr_unlock_bh(dev); |
| 4269 | } | 4269 | } |
diff --git a/net/irda/irlan/irlan_eth.c b/net/irda/irlan/irlan_eth.c index d340110f5c0c..9616c32d1076 100644 --- a/net/irda/irlan/irlan_eth.c +++ b/net/irda/irlan/irlan_eth.c | |||
| @@ -321,14 +321,15 @@ static void irlan_eth_set_multicast_list(struct net_device *dev) | |||
| 321 | /* Enable promiscuous mode */ | 321 | /* Enable promiscuous mode */ |
| 322 | IRDA_WARNING("Promiscuous mode not implemented by IrLAN!\n"); | 322 | IRDA_WARNING("Promiscuous mode not implemented by IrLAN!\n"); |
| 323 | } | 323 | } |
| 324 | else if ((dev->flags & IFF_ALLMULTI) || dev->mc_count > HW_MAX_ADDRS) { | 324 | else if ((dev->flags & IFF_ALLMULTI) || |
| 325 | netdev_mc_count(dev) > HW_MAX_ADDRS) { | ||
| 325 | /* Disable promiscuous mode, use normal mode. */ | 326 | /* Disable promiscuous mode, use normal mode. */ |
| 326 | IRDA_DEBUG(4, "%s(), Setting multicast filter\n", __func__ ); | 327 | IRDA_DEBUG(4, "%s(), Setting multicast filter\n", __func__ ); |
| 327 | /* hardware_set_filter(NULL); */ | 328 | /* hardware_set_filter(NULL); */ |
| 328 | 329 | ||
| 329 | irlan_set_multicast_filter(self, TRUE); | 330 | irlan_set_multicast_filter(self, TRUE); |
| 330 | } | 331 | } |
| 331 | else if (dev->mc_count) { | 332 | else if (!netdev_mc_empty(dev)) { |
| 332 | IRDA_DEBUG(4, "%s(), Setting multicast filter\n", __func__ ); | 333 | IRDA_DEBUG(4, "%s(), Setting multicast filter\n", __func__ ); |
| 333 | /* Walk the address list, and load the filter */ | 334 | /* Walk the address list, and load the filter */ |
| 334 | /* hardware_set_filter(dev->mc_list); */ | 335 | /* hardware_set_filter(dev->mc_list); */ |
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 09fff4662e80..f943f5fa7286 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c | |||
| @@ -413,7 +413,7 @@ static int ieee80211_stop(struct net_device *dev) | |||
| 413 | netif_addr_lock_bh(dev); | 413 | netif_addr_lock_bh(dev); |
| 414 | spin_lock_bh(&local->filter_lock); | 414 | spin_lock_bh(&local->filter_lock); |
| 415 | __dev_addr_unsync(&local->mc_list, &local->mc_count, | 415 | __dev_addr_unsync(&local->mc_list, &local->mc_count, |
| 416 | &dev->mc_list, &dev->mc_count); | 416 | &dev->mc_list, dev->mc_count); |
| 417 | spin_unlock_bh(&local->filter_lock); | 417 | spin_unlock_bh(&local->filter_lock); |
| 418 | netif_addr_unlock_bh(dev); | 418 | netif_addr_unlock_bh(dev); |
| 419 | 419 | ||
