diff options
author | Ilya Dryomov <idryomov@redhat.com> | 2014-10-23 08:32:57 -0400 |
---|---|---|
committer | Ilya Dryomov <idryomov@redhat.com> | 2014-12-17 12:09:50 -0500 |
commit | 4965fc38c460b274b2a1789e1165a25fb0409d7e (patch) | |
tree | 540d27c966a31b6e6f5a21bd44608e3edf3d1646 /net | |
parent | 9280be24dc9c7aaee230de3ed33f8357386de9a2 (diff) |
libceph: nuke ceph_kvfree()
Use kvfree() from linux/mm.h instead, which is identical. Also fix the
ceph_buffer comment: we will allocate with kmalloc() up to 32k - the
value of PAGE_ALLOC_COSTLY_ORDER, but that really is just an
implementation detail so don't mention it at all.
Signed-off-by: Ilya Dryomov <idryomov@redhat.com>
Diffstat (limited to 'net')
-rw-r--r-- | net/ceph/buffer.c | 4 | ||||
-rw-r--r-- | net/ceph/ceph_common.c | 8 | ||||
-rw-r--r-- | net/ceph/messenger.c | 2 |
3 files changed, 3 insertions, 11 deletions
diff --git a/net/ceph/buffer.c b/net/ceph/buffer.c index 621b5f65407f..add5f921a0ff 100644 --- a/net/ceph/buffer.c +++ b/net/ceph/buffer.c | |||
@@ -6,7 +6,7 @@ | |||
6 | 6 | ||
7 | #include <linux/ceph/buffer.h> | 7 | #include <linux/ceph/buffer.h> |
8 | #include <linux/ceph/decode.h> | 8 | #include <linux/ceph/decode.h> |
9 | #include <linux/ceph/libceph.h> /* for ceph_kv{malloc,free} */ | 9 | #include <linux/ceph/libceph.h> /* for ceph_kvmalloc */ |
10 | 10 | ||
11 | struct ceph_buffer *ceph_buffer_new(size_t len, gfp_t gfp) | 11 | struct ceph_buffer *ceph_buffer_new(size_t len, gfp_t gfp) |
12 | { | 12 | { |
@@ -35,7 +35,7 @@ void ceph_buffer_release(struct kref *kref) | |||
35 | struct ceph_buffer *b = container_of(kref, struct ceph_buffer, kref); | 35 | struct ceph_buffer *b = container_of(kref, struct ceph_buffer, kref); |
36 | 36 | ||
37 | dout("buffer_release %p\n", b); | 37 | dout("buffer_release %p\n", b); |
38 | ceph_kvfree(b->vec.iov_base); | 38 | kvfree(b->vec.iov_base); |
39 | kfree(b); | 39 | kfree(b); |
40 | } | 40 | } |
41 | EXPORT_SYMBOL(ceph_buffer_release); | 41 | EXPORT_SYMBOL(ceph_buffer_release); |
diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c index 58fbfe134f93..d361a274aee7 100644 --- a/net/ceph/ceph_common.c +++ b/net/ceph/ceph_common.c | |||
@@ -184,14 +184,6 @@ void *ceph_kvmalloc(size_t size, gfp_t flags) | |||
184 | return __vmalloc(size, flags | __GFP_HIGHMEM, PAGE_KERNEL); | 184 | return __vmalloc(size, flags | __GFP_HIGHMEM, PAGE_KERNEL); |
185 | } | 185 | } |
186 | 186 | ||
187 | void ceph_kvfree(const void *ptr) | ||
188 | { | ||
189 | if (is_vmalloc_addr(ptr)) | ||
190 | vfree(ptr); | ||
191 | else | ||
192 | kfree(ptr); | ||
193 | } | ||
194 | |||
195 | 187 | ||
196 | static int parse_fsid(const char *str, struct ceph_fsid *fsid) | 188 | static int parse_fsid(const char *str, struct ceph_fsid *fsid) |
197 | { | 189 | { |
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c index 8d1653caffdb..863d07ab2129 100644 --- a/net/ceph/messenger.c +++ b/net/ceph/messenger.c | |||
@@ -3288,7 +3288,7 @@ static int ceph_con_in_msg_alloc(struct ceph_connection *con, int *skip) | |||
3288 | static void ceph_msg_free(struct ceph_msg *m) | 3288 | static void ceph_msg_free(struct ceph_msg *m) |
3289 | { | 3289 | { |
3290 | dout("%s %p\n", __func__, m); | 3290 | dout("%s %p\n", __func__, m); |
3291 | ceph_kvfree(m->front.iov_base); | 3291 | kvfree(m->front.iov_base); |
3292 | kmem_cache_free(ceph_msg_cache, m); | 3292 | kmem_cache_free(ceph_msg_cache, m); |
3293 | } | 3293 | } |
3294 | 3294 | ||