diff options
| author | Daniel Borkmann <dborkman@redhat.com> | 2014-09-08 02:04:49 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-09-09 19:58:56 -0400 |
| commit | 286aad3c4014ca825c447e07e24f8929e6d266d2 (patch) | |
| tree | 50f1a085ddd7923b2b3c2764c850d0c02447d32a /net | |
| parent | 55309dd3d4cd7420376a3de0526d6ed24ff8fa76 (diff) | |
net: bpf: be friendly to kmemcheck
Reported by Mikulas Patocka, kmemcheck currently barks out a
false positive since we don't have special kmemcheck annotation
for bitfields used in bpf_prog structure.
We currently have jited:1, len:31 and thus when accessing len
while CONFIG_KMEMCHECK enabled, kmemcheck throws a warning that
we're reading uninitialized memory.
As we don't need the whole bit universe for pages member, we
can just split it to u16 and use a bool flag for jited instead
of a bitfield.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/filter.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/filter.c b/net/core/filter.c index fa5b7d0f77ac..dfc716ffa44b 100644 --- a/net/core/filter.c +++ b/net/core/filter.c | |||
| @@ -972,7 +972,7 @@ static struct bpf_prog *bpf_prepare_filter(struct bpf_prog *fp) | |||
| 972 | int err; | 972 | int err; |
| 973 | 973 | ||
| 974 | fp->bpf_func = NULL; | 974 | fp->bpf_func = NULL; |
| 975 | fp->jited = 0; | 975 | fp->jited = false; |
| 976 | 976 | ||
| 977 | err = bpf_check_classic(fp->insns, fp->len); | 977 | err = bpf_check_classic(fp->insns, fp->len); |
| 978 | if (err) { | 978 | if (err) { |