diff options
author | Chuck Lever <chuck.lever@oracle.com> | 2007-09-11 18:00:41 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2007-10-09 17:16:53 -0400 |
commit | 2429cbf6a1566b8e92436d615387e4250feab46b (patch) | |
tree | e3d4906948d68a3d9bcb546b6eb6563f1cffaa60 /net | |
parent | 4784cb51a3f66d401f8a08810231aa7dc8f44e43 (diff) |
SUNRPC: Add a new error code for retry waiting for another binder
Add new error code processing to the kernel's rpcbind client and to
call_bind_status() to distinguish two cases:
Case 1: the remote has replied that the program/version tuple is not
registered (returns -EACCES)
Case 2: another process is already in the middle of binding on this
transport (now returns -EAGAIN)
This change allows more specific retry processing for each of these two
cases.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net')
-rw-r--r-- | net/sunrpc/clnt.c | 6 | ||||
-rw-r--r-- | net/sunrpc/rpcb_clnt.c | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 7a7cd3b7acce..e53d71827132 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c | |||
@@ -950,6 +950,12 @@ call_bind_status(struct rpc_task *task) | |||
950 | } | 950 | } |
951 | 951 | ||
952 | switch (task->tk_status) { | 952 | switch (task->tk_status) { |
953 | case -EAGAIN: | ||
954 | dprintk("RPC: %5u rpcbind waiting for another request " | ||
955 | "to finish\n", task->tk_pid); | ||
956 | /* avoid busy-waiting here -- could be a network outage. */ | ||
957 | rpc_delay(task, 5*HZ); | ||
958 | goto retry_timeout; | ||
953 | case -EACCES: | 959 | case -EACCES: |
954 | dprintk("RPC: %5u remote rpcbind: RPC program/version " | 960 | dprintk("RPC: %5u remote rpcbind: RPC program/version " |
955 | "unavailable\n", task->tk_pid); | 961 | "unavailable\n", task->tk_pid); |
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c index a0c9f6905517..9b06a217ab86 100644 --- a/net/sunrpc/rpcb_clnt.c +++ b/net/sunrpc/rpcb_clnt.c | |||
@@ -341,7 +341,7 @@ void rpcb_getport_async(struct rpc_task *task) | |||
341 | BUG_ON(clnt->cl_parent != clnt); | 341 | BUG_ON(clnt->cl_parent != clnt); |
342 | 342 | ||
343 | if (xprt_test_and_set_binding(xprt)) { | 343 | if (xprt_test_and_set_binding(xprt)) { |
344 | status = -EACCES; /* tell caller to check again */ | 344 | status = -EAGAIN; /* tell caller to check again */ |
345 | dprintk("RPC: %5u %s: waiting for another binder\n", | 345 | dprintk("RPC: %5u %s: waiting for another binder\n", |
346 | task->tk_pid, __FUNCTION__); | 346 | task->tk_pid, __FUNCTION__); |
347 | goto bailout_nowake; | 347 | goto bailout_nowake; |