diff options
author | Alexei Starovoitov <ast@plumgrid.com> | 2014-06-05 17:39:36 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-06-05 18:40:38 -0400 |
commit | 0dcceabb0c1bf2d4c12a748df9933fad303072a7 (patch) | |
tree | 42b5b392bddc1c0add13fd61b3ab91e5c32b08ac /net | |
parent | 78c8dbb6524c92f28ea56a09ce3960b435d8ed92 (diff) |
net: filter: fix SKF_AD_PKTTYPE extension on big-endian
BPF classic->internal converter broke SKF_AD_PKTTYPE extension, since
pkt_type_offset() was failing to find skb->pkt_type field which is defined as:
__u8 pkt_type:3,
fclone:2,
ipvs_property:1,
peeked:1,
nf_trace:1;
Fix it by searching for 3 most significant bits and shift them by 5 at run-time
Fixes: bd4cf0ed331a ("net: filter: rework/optimize internal BPF interpreter's instruction set")
Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Tested-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/core/filter.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/net/core/filter.c b/net/core/filter.c index 4aec7b93f1a9..ab3c74e49f07 100644 --- a/net/core/filter.c +++ b/net/core/filter.c | |||
@@ -578,7 +578,11 @@ EXPORT_SYMBOL_GPL(sk_run_filter_int_skb); | |||
578 | * to make sure its still a 3bit field starting at a byte boundary; | 578 | * to make sure its still a 3bit field starting at a byte boundary; |
579 | * taken from arch/x86/net/bpf_jit_comp.c. | 579 | * taken from arch/x86/net/bpf_jit_comp.c. |
580 | */ | 580 | */ |
581 | #ifdef __BIG_ENDIAN_BITFIELD | ||
582 | #define PKT_TYPE_MAX (7 << 5) | ||
583 | #else | ||
581 | #define PKT_TYPE_MAX 7 | 584 | #define PKT_TYPE_MAX 7 |
585 | #endif | ||
582 | static unsigned int pkt_type_offset(void) | 586 | static unsigned int pkt_type_offset(void) |
583 | { | 587 | { |
584 | struct sk_buff skb_probe = { .pkt_type = ~0, }; | 588 | struct sk_buff skb_probe = { .pkt_type = ~0, }; |
@@ -685,6 +689,13 @@ static bool convert_bpf_extensions(struct sock_filter *fp, | |||
685 | insn->code = BPF_ALU | BPF_AND | BPF_K; | 689 | insn->code = BPF_ALU | BPF_AND | BPF_K; |
686 | insn->a_reg = A_REG; | 690 | insn->a_reg = A_REG; |
687 | insn->imm = PKT_TYPE_MAX; | 691 | insn->imm = PKT_TYPE_MAX; |
692 | #ifdef __BIG_ENDIAN_BITFIELD | ||
693 | insn++; | ||
694 | |||
695 | insn->code = BPF_ALU | BPF_RSH | BPF_K; | ||
696 | insn->a_reg = A_REG; | ||
697 | insn->imm = 5; | ||
698 | #endif | ||
688 | break; | 699 | break; |
689 | 700 | ||
690 | case SKF_AD_OFF + SKF_AD_IFINDEX: | 701 | case SKF_AD_OFF + SKF_AD_IFINDEX: |