aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-02-23 03:05:26 -0500
committerDavid S. Miller <davem@davemloft.net>2014-02-24 19:16:44 -0500
commit04091142826e5823e31cc6418942ac447b3edb0a (patch)
treedbc0275ae1f732f7985d601b91fbad0dba7ed01b /net
parente5a727f6632654098fa4e87d8551a5873e8f658a (diff)
bridge: netfilter: Use ether_addr_copy
Convert the uses of memcpy to ether_addr_copy because for some architectures it is smaller and faster. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/bridge/br_netfilter.c2
-rw-r--r--net/bridge/netfilter/ebt_among.c2
-rw-r--r--net/bridge/netfilter/ebt_dnat.c2
-rw-r--r--net/bridge/netfilter/ebt_redirect.c6
-rw-r--r--net/bridge/netfilter/ebt_snat.c2
5 files changed, 7 insertions, 7 deletions
diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c
index b008c59a92c4..df0f114fb8cb 100644
--- a/net/bridge/br_netfilter.c
+++ b/net/bridge/br_netfilter.c
@@ -506,7 +506,7 @@ bridged_dnat:
506 1); 506 1);
507 return 0; 507 return 0;
508 } 508 }
509 memcpy(eth_hdr(skb)->h_dest, dev->dev_addr, ETH_ALEN); 509 ether_addr_copy(eth_hdr(skb)->h_dest, dev->dev_addr);
510 skb->pkt_type = PACKET_HOST; 510 skb->pkt_type = PACKET_HOST;
511 } 511 }
512 } else { 512 } else {
diff --git a/net/bridge/netfilter/ebt_among.c b/net/bridge/netfilter/ebt_among.c
index 3fb3c848affe..9024283d2bca 100644
--- a/net/bridge/netfilter/ebt_among.c
+++ b/net/bridge/netfilter/ebt_among.c
@@ -28,7 +28,7 @@ static bool ebt_mac_wormhash_contains(const struct ebt_mac_wormhash *wh,
28 uint32_t cmp[2] = { 0, 0 }; 28 uint32_t cmp[2] = { 0, 0 };
29 int key = ((const unsigned char *)mac)[5]; 29 int key = ((const unsigned char *)mac)[5];
30 30
31 memcpy(((char *) cmp) + 2, mac, ETH_ALEN); 31 ether_addr_copy(((char *) cmp) + 2, mac);
32 start = wh->table[key]; 32 start = wh->table[key];
33 limit = wh->table[key + 1]; 33 limit = wh->table[key + 1];
34 if (ip) { 34 if (ip) {
diff --git a/net/bridge/netfilter/ebt_dnat.c b/net/bridge/netfilter/ebt_dnat.c
index c59f7bfae6e2..4e0b0c359325 100644
--- a/net/bridge/netfilter/ebt_dnat.c
+++ b/net/bridge/netfilter/ebt_dnat.c
@@ -22,7 +22,7 @@ ebt_dnat_tg(struct sk_buff *skb, const struct xt_action_param *par)
22 if (!skb_make_writable(skb, 0)) 22 if (!skb_make_writable(skb, 0))
23 return EBT_DROP; 23 return EBT_DROP;
24 24
25 memcpy(eth_hdr(skb)->h_dest, info->mac, ETH_ALEN); 25 ether_addr_copy(eth_hdr(skb)->h_dest, info->mac);
26 return info->target; 26 return info->target;
27} 27}
28 28
diff --git a/net/bridge/netfilter/ebt_redirect.c b/net/bridge/netfilter/ebt_redirect.c
index 46624bb6d9be..203964997a51 100644
--- a/net/bridge/netfilter/ebt_redirect.c
+++ b/net/bridge/netfilter/ebt_redirect.c
@@ -25,10 +25,10 @@ ebt_redirect_tg(struct sk_buff *skb, const struct xt_action_param *par)
25 25
26 if (par->hooknum != NF_BR_BROUTING) 26 if (par->hooknum != NF_BR_BROUTING)
27 /* rcu_read_lock()ed by nf_hook_slow */ 27 /* rcu_read_lock()ed by nf_hook_slow */
28 memcpy(eth_hdr(skb)->h_dest, 28 ether_addr_copy(eth_hdr(skb)->h_dest,
29 br_port_get_rcu(par->in)->br->dev->dev_addr, ETH_ALEN); 29 br_port_get_rcu(par->in)->br->dev->dev_addr);
30 else 30 else
31 memcpy(eth_hdr(skb)->h_dest, par->in->dev_addr, ETH_ALEN); 31 ether_addr_copy(eth_hdr(skb)->h_dest, par->in->dev_addr);
32 skb->pkt_type = PACKET_HOST; 32 skb->pkt_type = PACKET_HOST;
33 return info->target; 33 return info->target;
34} 34}
diff --git a/net/bridge/netfilter/ebt_snat.c b/net/bridge/netfilter/ebt_snat.c
index 0f6b118d6cb2..e56ccd060d26 100644
--- a/net/bridge/netfilter/ebt_snat.c
+++ b/net/bridge/netfilter/ebt_snat.c
@@ -24,7 +24,7 @@ ebt_snat_tg(struct sk_buff *skb, const struct xt_action_param *par)
24 if (!skb_make_writable(skb, 0)) 24 if (!skb_make_writable(skb, 0))
25 return EBT_DROP; 25 return EBT_DROP;
26 26
27 memcpy(eth_hdr(skb)->h_source, info->mac, ETH_ALEN); 27 ether_addr_copy(eth_hdr(skb)->h_source, info->mac);
28 if (!(info->target & NAT_ARP_BIT) && 28 if (!(info->target & NAT_ARP_BIT) &&
29 eth_hdr(skb)->h_proto == htons(ETH_P_ARP)) { 29 eth_hdr(skb)->h_proto == htons(ETH_P_ARP)) {
30 const struct arphdr *ap; 30 const struct arphdr *ap;