diff options
author | Allan Stephens <allan.stephens@windriver.com> | 2011-10-18 14:47:02 -0400 |
---|---|---|
committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2011-12-27 11:33:40 -0500 |
commit | bfec73d7e45cdf570d649a547050295789e1e6fb (patch) | |
tree | 5dad32b2f41b1c250a60c88fc5f4877253b88d13 /net/tipc | |
parent | 5c216e1d28c82332db0fa53e30536577fb6130c6 (diff) |
tipc: Revise comment justifying release of configuration spinlock
Comment-only change to better explain why TIPC's configuration lock is
temporarily released while activating support for network interfaces,
and why the existing activation code doesn't require rework.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Diffstat (limited to 'net/tipc')
-rw-r--r-- | net/tipc/config.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/net/tipc/config.c b/net/tipc/config.c index b25a396b7e1e..4785bf26cdf4 100644 --- a/net/tipc/config.c +++ b/net/tipc/config.c | |||
@@ -184,13 +184,12 @@ static struct sk_buff *cfg_set_own_addr(void) | |||
184 | " (cannot change node address once assigned)"); | 184 | " (cannot change node address once assigned)"); |
185 | 185 | ||
186 | /* | 186 | /* |
187 | * Must release all spinlocks before calling start_net() because | 187 | * Must temporarily release configuration spinlock while switching into |
188 | * Linux version of TIPC calls eth_media_start() which calls | 188 | * networking mode as it calls tipc_eth_media_start(), which may sleep. |
189 | * register_netdevice_notifier() which may block! | 189 | * Releasing the lock is harmless as other locally-issued configuration |
190 | * | 190 | * commands won't occur until this one completes, and remotely-issued |
191 | * Temporarily releasing the lock should be harmless for non-Linux TIPC, | 191 | * configuration commands can't be received until a local configuration |
192 | * but Linux version of eth_media_start() should really be reworked | 192 | * command to enable the first bearer is received and processed. |
193 | * so that it can be called with spinlocks held. | ||
194 | */ | 193 | */ |
195 | 194 | ||
196 | spin_unlock_bh(&config_lock); | 195 | spin_unlock_bh(&config_lock); |