diff options
author | Ying Xue <ying.xue@windriver.com> | 2014-12-09 02:17:56 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-12-09 18:27:03 -0500 |
commit | 023160bc8f100ad949ebaee0d3a1b7398d938171 (patch) | |
tree | 23c6403901add558eb44802cd9e019434f9dbe39 /net/tipc | |
parent | fb3b596d3c4a8b6e3867079794856637db4e5283 (diff) |
tipc: avoid double lock 'spin_lock:&seq->lock'
The commit fb9962f3cefe ("tipc: ensure all name sequences are properly
protected with its lock") involves below errors:
net/tipc/name_table.c:980 tipc_purge_publications() error: double lock 'spin_lock:&seq->lock'
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc')
-rw-r--r-- | net/tipc/name_table.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c index aafa684c4db9..c8df0223371a 100644 --- a/net/tipc/name_table.c +++ b/net/tipc/name_table.c | |||
@@ -979,7 +979,7 @@ static void tipc_purge_publications(struct name_seq *seq) | |||
979 | } | 979 | } |
980 | hlist_del_init_rcu(&seq->ns_list); | 980 | hlist_del_init_rcu(&seq->ns_list); |
981 | kfree(seq->sseqs); | 981 | kfree(seq->sseqs); |
982 | spin_lock_bh(&seq->lock); | 982 | spin_unlock_bh(&seq->lock); |
983 | 983 | ||
984 | kfree_rcu(seq, rcu); | 984 | kfree_rcu(seq, rcu); |
985 | } | 985 | } |